From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org, Julien Grall <jgrall@amazon.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
michal.orzel@arm.com, olaf@aepfle.de
Subject: [PATCH] tools/xen-foreign: Update the size for vcpu_guest_{core_regs, context}
Date: Tue, 6 Jul 2021 14:20:00 +0100 [thread overview]
Message-ID: <20210706132000.29892-1-julien@xen.org> (raw)
From: Julien Grall <jgrall@amazon.com>
Commit 918b8842a852 ("arm64: Change type of hsr, cpsr, spsr_el1 to
uint64_t") updated the size of the structure vcpu_guest_core_regs and
indirectly vcpu_guest_context.
On Arm, the two structures are only accessible to the tools and the
hypervisor (and therefore stable). However, they are still checked
by the scripts in tools/include/xen-foreign are not able to understand
that.
Ideally we should rework the scripts so we don't have to update
the size for non-stable structure. But I don't have limited time
to spend on the issue. So chose the simple solution and update
the size accordingly.
Note that we need to keep vcpu_guest_core_regs around because
the structure is used by vcpu_guest_context and therefore the
scripts expects the generated header to contain it.
Fixes: 918b8842a852 ("arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
Cc: michal.orzel@arm.com
Cc: olaf@aepfle.de
---
tools/include/xen-foreign/reference.size | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/include/xen-foreign/reference.size b/tools/include/xen-foreign/reference.size
index a0409db5c458..11a06a7a432c 100644
--- a/tools/include/xen-foreign/reference.size
+++ b/tools/include/xen-foreign/reference.size
@@ -4,8 +4,8 @@ structs | arm32 arm64 x86_32 x86_64
start_info | - - 1112 1168
trap_info | - - 8 16
cpu_user_regs | - - 68 200
-vcpu_guest_core_regs | 304 304 - -
-vcpu_guest_context | 344 344 2800 5168
+vcpu_guest_core_regs | 312 312 - -
+vcpu_guest_context | 352 352 2800 5168
arch_vcpu_info | 0 0 24 16
vcpu_time_info | 32 32 32 32
vcpu_info | 48 48 64 64
--
2.17.1
next reply other threads:[~2021-07-06 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 13:20 Julien Grall [this message]
2021-07-06 13:37 ` [PATCH] tools/xen-foreign: Update the size for vcpu_guest_{core_regs, context} Bertrand Marquis
2021-07-06 14:07 ` Jan Beulich
2021-07-06 14:24 ` Julien Grall
2021-07-06 15:10 ` Jan Beulich
2021-07-06 15:23 ` Julien Grall
2021-07-07 7:44 ` Michal Orzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706132000.29892-1-julien@xen.org \
--to=julien@xen.org \
--cc=iwj@xenproject.org \
--cc=jgrall@amazon.com \
--cc=michal.orzel@arm.com \
--cc=olaf@aepfle.de \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.