All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ohhoon Kwon <ohoono.kwon@samsung.com>
To: david@redhat.com, ohoono.kwon@samsung.com,
	akpm@linux-foundation.org, mhocko@suse.com
Cc: bhe@redhat.com, rppt@linux.ibm.com, ohkwon1043@gmail.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 1/3] mm: sparse: pass section_nr to section_mark_present
Date: Thu,  8 Jul 2021 00:02:10 +0900	[thread overview]
Message-ID: <20210707150212.855-2-ohoono.kwon@samsung.com> (raw)
In-Reply-To: <20210707150212.855-1-ohoono.kwon@samsung.com>

With CONFIG_SPARSEMEM_EXTREME enabled, __section_nr() which converts
mem_section to section_nr could be costly since it iterates all
section roots to check if the given mem_section is in its range.

Since both callers of section_mark_present already know section_nr,
let's also pass section_nr as well as mem_section in order to reduce
costly translation.

Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com>
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
 mm/sparse.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/mm/sparse.c b/mm/sparse.c
index 6326cdf36c4f..8018ee7fcda5 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -187,10 +187,9 @@ void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn,
  * those loops early.
  */
 unsigned long __highest_present_section_nr;
-static void section_mark_present(struct mem_section *ms)
+static void __section_mark_present(struct mem_section *ms,
+		unsigned long section_nr)
 {
-	unsigned long section_nr = __section_nr(ms);
-
 	if (section_nr > __highest_present_section_nr)
 		__highest_present_section_nr = section_nr;
 
@@ -280,7 +279,7 @@ static void __init memory_present(int nid, unsigned long start, unsigned long en
 		if (!ms->section_mem_map) {
 			ms->section_mem_map = sparse_encode_early_nid(nid) |
 							SECTION_IS_ONLINE;
-			section_mark_present(ms);
+			__section_mark_present(ms, section);
 		}
 	}
 }
@@ -934,7 +933,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn,
 
 	ms = __nr_to_section(section_nr);
 	set_section_nid(section_nr, nid);
-	section_mark_present(ms);
+	__section_mark_present(ms, section_nr);
 
 	/* Align memmap to section boundary in the subsection case */
 	if (section_nr_to_pfn(section_nr) != start_pfn)
-- 
2.17.1


  parent reply	other threads:[~2021-07-07 15:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210707150538epcas1p35450f5b6058e2ea9e06446f10d9bf662@epcas1p3.samsung.com>
2021-07-07 15:02 ` [PATCH v4 0/3] mm: sparse: remove __section_nr() function Ohhoon Kwon
     [not found]   ` <CGME20210707150538epcas1p4b893d4fcd9eab24e4e06714efc24299e@epcas1p4.samsung.com>
2021-07-07 15:02     ` Ohhoon Kwon [this message]
     [not found]   ` <CGME20210707150538epcas1p2b2424d8303874d62d3ede60c38db6b59@epcas1p2.samsung.com>
2021-07-07 15:02     ` [PATCH v4 2/3] mm: sparse: pass section_nr to find_memory_block Ohhoon Kwon
     [not found]   ` <CGME20210707150538epcas1p149f866bf9b4c900a091c006df7162a23@epcas1p1.samsung.com>
2021-07-07 15:02     ` [PATCH v4 3/3] mm: sparse: remove __section_nr() function Ohhoon Kwon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210707150212.855-2-ohoono.kwon@samsung.com \
    --to=ohoono.kwon@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=ohkwon1043@gmail.com \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.