All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James Smart <jsmart2021@gmail.com>, Justin Tee <justin.tee@broadcom.com>
Subject: [PATCH 01/20] lpfc: Fix NVME support reporting in log message
Date: Wed,  7 Jul 2021 11:43:32 -0700	[thread overview]
Message-ID: <20210707184351.67872-2-jsmart2021@gmail.com> (raw)
In-Reply-To: <20210707184351.67872-1-jsmart2021@gmail.com>

The NVME support indicator in log message 6422 is displaying a field
that was initialized but never set to indicate NVME support.  Remove
obsolete nvme_support element from the lpfc_hba structure and change
log message to display NVME support status as reported in SLI4 Config
Parameters mailbox command.

Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
---
 drivers/scsi/lpfc/lpfc.h      | 1 -
 drivers/scsi/lpfc/lpfc_init.c | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h
index 17028861234b..dd3ddfa5f761 100644
--- a/drivers/scsi/lpfc/lpfc.h
+++ b/drivers/scsi/lpfc/lpfc.h
@@ -922,7 +922,6 @@ struct lpfc_hba {
 	uint8_t  wwpn[8];
 	uint32_t RandomData[7];
 	uint8_t  fcp_embed_io;
-	uint8_t  nvme_support;	/* Firmware supports NVME */
 	uint8_t  nvmet_support;	/* driver supports NVMET */
 #define LPFC_NVMET_MAX_PORTS	32
 	uint8_t  mds_diags_support;
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index f3032e30c3e4..cf5bfd27058a 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -12241,7 +12241,6 @@ lpfc_get_sli4_parameters(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq)
 					bf_get(cfg_xib, mbx_sli4_parameters),
 					phba->cfg_enable_fc4_type);
 fcponly:
-			phba->nvme_support = 0;
 			phba->nvmet_support = 0;
 			phba->cfg_nvmet_mrq = 0;
 			phba->cfg_nvme_seg_cnt = 0;
@@ -12299,7 +12298,7 @@ lpfc_get_sli4_parameters(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq)
 			"6422 XIB %d PBDE %d: FCP %d NVME %d %d %d\n",
 			bf_get(cfg_xib, mbx_sli4_parameters),
 			phba->cfg_enable_pbde,
-			phba->fcp_embed_io, phba->nvme_support,
+			phba->fcp_embed_io, sli4_params->nvme,
 			phba->cfg_nvme_embed_cmd, phba->cfg_suppress_rsp);
 
 	if ((bf_get(lpfc_sli_intf_if_type, &phba->sli4_hba.sli_intf) ==
-- 
2.26.2


  reply	other threads:[~2021-07-07 18:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 18:43 [PATCH 00/20] lpfc: Update lpfc to revision 12.8.0.11 James Smart
2021-07-07 18:43 ` James Smart [this message]
2021-07-07 18:43 ` [PATCH 02/20] lpfc: Remove use of kmalloc in trace event logging James Smart
2021-07-07 18:43 ` [PATCH 03/20] lpfc: Improve firmware download logging James Smart
2021-07-07 18:43 ` [PATCH 04/20] lpfc: Fix function description comments for vmid routines James Smart
2021-07-07 18:43 ` [PATCH 05/20] lpfc: Discovery state machine fixes for LOGO handling James Smart
2021-07-07 18:43 ` [PATCH 06/20] lpfc: Fix target reset handler from falsely returning FAILURE James Smart
2021-07-07 18:43 ` [PATCH 07/20] lpfc: Keep ndlp reference until after freeing the iocb after els handling James Smart
2021-07-07 18:43 ` [PATCH 08/20] lpfc: Fix null ptr dereference with NPIV ports for RDF handling James Smart
2021-07-07 18:43 ` [PATCH 09/20] lpfc: Fix memory leaks in error paths while issuing ELS RDF/SCR request James Smart
2021-07-07 18:43 ` [PATCH 10/20] lpfc: Remove REG_LOGIN check requirement to issue an ELS RDF James Smart
2021-07-07 18:43 ` [PATCH 11/20] lpfc: Fix KASAN slab-out-of-bounds in lpfc_unreg_rpi routine James Smart
2021-07-07 18:43 ` [PATCH 12/20] lpfc: Clear outstanding active mailbox during PCI function reset James Smart
2021-07-07 18:43 ` [PATCH 13/20] lpfc: Use PBDE feature enabled bit to determine PBDE support James Smart
2021-07-07 18:43 ` [PATCH 14/20] lpfc: Enable adisc discovery after RSCN by default James Smart
2021-07-07 18:43 ` [PATCH 15/20] lpfc: Delay unregistering from transport until GIDFT or ADISC completes James Smart
2021-07-07 18:43 ` [PATCH 16/20] lpfc: Call discovery state machine when handling PLOGI/ADISC completions James Smart
2021-07-07 18:43 ` [PATCH 17/20] lpfc: Skip reg_vpi when link is down for SLI3 in ADISC cmpl path James Smart
2021-07-07 18:43 ` [PATCH 18/20] lpfc: Skip issuing ADISC when node is in NPR state James Smart
2021-07-07 18:43 ` [PATCH 19/20] lpfc: Update lpfc version to 12.8.0.11 James Smart
2021-07-07 18:43 ` [PATCH 20/20] lpfc: Copyright updates for 12.8.0.11 patches James Smart
2021-07-19  2:31 ` [PATCH 00/20] lpfc: Update lpfc to revision 12.8.0.11 Martin K. Petersen
2021-07-24  2:13 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210707184351.67872-2-jsmart2021@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=justin.tee@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.