From: "Antti Keränen" <detegr@rbx.email>
To: linux-iio@vger.kernel.org
Cc: "Antti Keränen" <detegr@rbx.email>,
"Hannu Hartikainen" <hannu@hrtk.in>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sa" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2] iio: adis: set GPIO reset pin direction
Date: Thu, 8 Jul 2021 12:54:29 +0300 [thread overview]
Message-ID: <20210708095425.13295-1-detegr@rbx.email> (raw)
In-Reply-To: <60e5ac8c.1c69fb81.c69f0.abab@mx.google.com>
Set reset pin direction to output as the reset pin needs to be an active
low output pin.
Co-developed-by: Hannu Hartikainen <hannu@hrtk.in>
Signed-off-by: Hannu Hartikainen <hannu@hrtk.in>
Signed-off-by: Antti Keränen <detegr@rbx.email>
---
Removed unnecessary toggling of the pin as requested by Lars-Peter. I
missed out on the conversation, but I agree this is better.
drivers/iio/imu/adis.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
index 319b64b2fd88..f8b7837d8b8f 100644
--- a/drivers/iio/imu/adis.c
+++ b/drivers/iio/imu/adis.c
@@ -415,12 +415,11 @@ int __adis_initial_startup(struct adis *adis)
int ret;
/* check if the device has rst pin low */
- gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_ASIS);
+ gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(gpio))
return PTR_ERR(gpio);
if (gpio) {
- gpiod_set_value_cansleep(gpio, 1);
msleep(10);
/* bring device out of reset */
gpiod_set_value_cansleep(gpio, 0);
--
2.32.0
next prev parent reply other threads:[~2021-07-08 9:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 9:29 [RESEND PATCH] iio: adis: set GPIO reset pin direction Antti Keränen
2021-07-07 8:18 ` Lars-Peter Clausen
2021-07-07 8:36 ` Sa, Nuno
2021-07-07 11:53 ` Hannu Hartikainen
2021-07-07 12:25 ` Lars-Peter Clausen
2021-07-07 13:30 ` Hannu Hartikainen
2021-07-08 9:54 ` Antti Keränen [this message]
2021-07-08 10:05 ` [PATCH v2] " Sa, Nuno
2021-07-10 17:35 ` Jonathan Cameron
2021-07-13 17:53 ` Jonathan Cameron
2021-07-14 10:04 ` Antti Keränen
2021-07-14 12:40 ` Jonathan Cameron
2021-07-14 18:25 ` Antti Keränen
2021-07-17 17:41 ` Jonathan Cameron
2021-07-07 12:32 ` [RESEND PATCH] " Sa, Nuno
2021-07-07 12:32 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708095425.13295-1-detegr@rbx.email \
--to=detegr@rbx.email \
--cc=Michael.Hennerich@analog.com \
--cc=hannu@hrtk.in \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.