All of lore.kernel.org
 help / color / mirror / Atom feed
From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs: mark compressed range uptodate only if all bio succeed
Date: Fri, 9 Jul 2021 11:29:22 -0500	[thread overview]
Message-ID: <20210709162922.udxjidc3kgxkgzx3@fiona> (raw)

In compression write endio sequence, the range which the compressed_bio
writes is marked as uptodate if the last bio of the compressed (sub)bios
is completed successfully. There could be previous bio which may
have failed which is recorded in cb->errors.

Set the writeback range as uptodate only if cb->errors is zero, as opposed
to checking only the last bio's status.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
 fs/btrfs/compression.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index 9a023ae0f98b..30d82cdf128c 100644
--- a/fs/btrfs/compression.c
+++ b/fs/btrfs/compression.c
@@ -352,7 +352,7 @@ static void end_compressed_bio_write(struct bio *bio)
 	btrfs_record_physical_zoned(inode, cb->start, bio);
 	btrfs_writepage_endio_finish_ordered(BTRFS_I(inode), NULL,
 			cb->start, cb->start + cb->len - 1,
-			bio->bi_status == BLK_STS_OK);
+			!cb->errors);
 
 	end_compressed_writeback(inode, cb);
 	/* note, our inode could be gone now */
-- 
2.32.0

             reply	other threads:[~2021-07-09 16:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09 16:29 Goldwyn Rodrigues [this message]
2021-07-22 14:34 ` [PATCH] btrfs: mark compressed range uptodate only if all bio succeed David Sterba
2021-07-22 19:34   ` Goldwyn Rodrigues
2021-07-31  6:33 FAILED: patch "[PATCH] btrfs: mark compressed range uptodate only if all bio succeed" failed to apply to 4.9-stable tree gregkh
2021-08-02 14:31 ` [PATCH] btrfs: mark compressed range uptodate only if all bio succeed Goldwyn Rodrigues
2021-07-31  6:33 FAILED: patch "[PATCH] btrfs: mark compressed range uptodate only if all bio succeed" failed to apply to 4.4-stable tree gregkh
2021-08-02 14:30 ` [PATCH] btrfs: mark compressed range uptodate only if all bio succeed Goldwyn Rodrigues
2021-07-31  6:33 FAILED: patch "[PATCH] btrfs: mark compressed range uptodate only if all bio succeed" failed to apply to 4.19-stable tree gregkh
2021-08-02 14:32 ` [PATCH] btrfs: mark compressed range uptodate only if all bio succeed Goldwyn Rodrigues
2021-08-02 19:41   ` Sasha Levin
2021-07-31  6:33 FAILED: patch "[PATCH] btrfs: mark compressed range uptodate only if all bio succeed" failed to apply to 4.14-stable tree gregkh
2021-08-02 14:31 ` [PATCH] btrfs: mark compressed range uptodate only if all bio succeed Goldwyn Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709162922.udxjidc3kgxkgzx3@fiona \
    --to=rgoldwyn@suse.de \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.