From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, "Intel Graphics Development" <intel-gfx@lists.freedesktop.org>, "Jason Ekstrand" <jason@jlekstrand.net>, "Daniel Vetter" <daniel.vetter@intel.com> Subject: [PATCH v4 16/18] drm/i915: delete exclude argument from i915_sw_fence_await_reservation Date: Mon, 12 Jul 2021 19:53:50 +0200 [thread overview] Message-ID: <20210712175352.802687-17-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20210712175352.802687-1-daniel.vetter@ffwll.ch> No longer used, the last user disappeared with commit d07f0e59b2c762584478920cd2d11fba2980a94a Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Fri Oct 28 13:58:44 2016 +0100 drm/i915: Move GEM activity tracking into a common struct reservation_object Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/i915_sw_fence.c | 6 +----- drivers/gpu/drm/i915/i915_sw_fence.h | 1 - 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 98e0f4ed7e4a..678c7839034e 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -11119,7 +11119,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane, */ if (intel_crtc_needs_modeset(crtc_state)) { ret = i915_sw_fence_await_reservation(&state->commit_ready, - old_obj->base.resv, NULL, + old_obj->base.resv, false, 0, GFP_KERNEL); if (ret < 0) @@ -11153,7 +11153,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane, struct dma_fence *fence; ret = i915_sw_fence_await_reservation(&state->commit_ready, - obj->base.resv, NULL, + obj->base.resv, false, i915_fence_timeout(dev_priv), GFP_KERNEL); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_clflush.c b/drivers/gpu/drm/i915/gem/i915_gem_clflush.c index daf9284ef1f5..93439d2c7a58 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_clflush.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_clflush.c @@ -106,7 +106,7 @@ bool i915_gem_clflush_object(struct drm_i915_gem_object *obj, clflush = clflush_work_create(obj); if (clflush) { i915_sw_fence_await_reservation(&clflush->base.chain, - obj->base.resv, NULL, true, + obj->base.resv, true, i915_fence_timeout(to_i915(obj->base.dev)), I915_FENCE_GFP); dma_resv_add_excl_fence(obj->base.resv, &clflush->base.dma); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index b95c8927d465..b4a77eba8631 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -2087,7 +2087,7 @@ static int eb_parse_pipeline(struct i915_execbuffer *eb, /* Wait for all writes (and relocs) into the batch to complete */ err = i915_sw_fence_await_reservation(&pw->base.chain, - pw->batch->resv, NULL, false, + pw->batch->resv, false, 0, I915_FENCE_GFP); if (err < 0) goto err_commit; diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c index c589a681da77..91711a46b1c7 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence.c +++ b/drivers/gpu/drm/i915/i915_sw_fence.c @@ -567,7 +567,6 @@ int __i915_sw_fence_await_dma_fence(struct i915_sw_fence *fence, int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, struct dma_resv *resv, - const struct dma_fence_ops *exclude, bool write, unsigned long timeout, gfp_t gfp) @@ -587,9 +586,6 @@ int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, return ret; for (i = 0; i < count; i++) { - if (shared[i]->ops == exclude) - continue; - pending = i915_sw_fence_await_dma_fence(fence, shared[i], timeout, @@ -609,7 +605,7 @@ int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, excl = dma_resv_get_excl_unlocked(resv); } - if (ret >= 0 && excl && excl->ops != exclude) { + if (ret >= 0 && excl) { pending = i915_sw_fence_await_dma_fence(fence, excl, timeout, diff --git a/drivers/gpu/drm/i915/i915_sw_fence.h b/drivers/gpu/drm/i915/i915_sw_fence.h index 30a863353ee6..6572f01668e4 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence.h +++ b/drivers/gpu/drm/i915/i915_sw_fence.h @@ -86,7 +86,6 @@ int i915_sw_fence_await_dma_fence(struct i915_sw_fence *fence, int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, struct dma_resv *resv, - const struct dma_fence_ops *exclude, bool write, unsigned long timeout, gfp_t gfp); -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, "Intel Graphics Development" <intel-gfx@lists.freedesktop.org>, "Daniel Vetter" <daniel.vetter@intel.com> Subject: [Intel-gfx] [PATCH v4 16/18] drm/i915: delete exclude argument from i915_sw_fence_await_reservation Date: Mon, 12 Jul 2021 19:53:50 +0200 [thread overview] Message-ID: <20210712175352.802687-17-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20210712175352.802687-1-daniel.vetter@ffwll.ch> No longer used, the last user disappeared with commit d07f0e59b2c762584478920cd2d11fba2980a94a Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Fri Oct 28 13:58:44 2016 +0100 drm/i915: Move GEM activity tracking into a common struct reservation_object Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/i915_sw_fence.c | 6 +----- drivers/gpu/drm/i915/i915_sw_fence.h | 1 - 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 98e0f4ed7e4a..678c7839034e 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -11119,7 +11119,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane, */ if (intel_crtc_needs_modeset(crtc_state)) { ret = i915_sw_fence_await_reservation(&state->commit_ready, - old_obj->base.resv, NULL, + old_obj->base.resv, false, 0, GFP_KERNEL); if (ret < 0) @@ -11153,7 +11153,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane, struct dma_fence *fence; ret = i915_sw_fence_await_reservation(&state->commit_ready, - obj->base.resv, NULL, + obj->base.resv, false, i915_fence_timeout(dev_priv), GFP_KERNEL); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_clflush.c b/drivers/gpu/drm/i915/gem/i915_gem_clflush.c index daf9284ef1f5..93439d2c7a58 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_clflush.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_clflush.c @@ -106,7 +106,7 @@ bool i915_gem_clflush_object(struct drm_i915_gem_object *obj, clflush = clflush_work_create(obj); if (clflush) { i915_sw_fence_await_reservation(&clflush->base.chain, - obj->base.resv, NULL, true, + obj->base.resv, true, i915_fence_timeout(to_i915(obj->base.dev)), I915_FENCE_GFP); dma_resv_add_excl_fence(obj->base.resv, &clflush->base.dma); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index b95c8927d465..b4a77eba8631 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -2087,7 +2087,7 @@ static int eb_parse_pipeline(struct i915_execbuffer *eb, /* Wait for all writes (and relocs) into the batch to complete */ err = i915_sw_fence_await_reservation(&pw->base.chain, - pw->batch->resv, NULL, false, + pw->batch->resv, false, 0, I915_FENCE_GFP); if (err < 0) goto err_commit; diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c index c589a681da77..91711a46b1c7 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence.c +++ b/drivers/gpu/drm/i915/i915_sw_fence.c @@ -567,7 +567,6 @@ int __i915_sw_fence_await_dma_fence(struct i915_sw_fence *fence, int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, struct dma_resv *resv, - const struct dma_fence_ops *exclude, bool write, unsigned long timeout, gfp_t gfp) @@ -587,9 +586,6 @@ int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, return ret; for (i = 0; i < count; i++) { - if (shared[i]->ops == exclude) - continue; - pending = i915_sw_fence_await_dma_fence(fence, shared[i], timeout, @@ -609,7 +605,7 @@ int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, excl = dma_resv_get_excl_unlocked(resv); } - if (ret >= 0 && excl && excl->ops != exclude) { + if (ret >= 0 && excl) { pending = i915_sw_fence_await_dma_fence(fence, excl, timeout, diff --git a/drivers/gpu/drm/i915/i915_sw_fence.h b/drivers/gpu/drm/i915/i915_sw_fence.h index 30a863353ee6..6572f01668e4 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence.h +++ b/drivers/gpu/drm/i915/i915_sw_fence.h @@ -86,7 +86,6 @@ int i915_sw_fence_await_dma_fence(struct i915_sw_fence *fence, int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, struct dma_resv *resv, - const struct dma_fence_ops *exclude, bool write, unsigned long timeout, gfp_t gfp); -- 2.32.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-07-12 20:02 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-12 17:53 [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 01/18] drm/sched: Split drm_sched_job_init Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter 2021-07-12 20:22 ` Emma Anholt 2021-07-12 20:22 ` [Intel-gfx] " Emma Anholt 2021-07-12 20:22 ` Emma Anholt 2021-07-13 6:40 ` Christian König 2021-07-13 6:40 ` [Intel-gfx] " Christian König 2021-07-13 6:40 ` Christian König 2021-07-13 6:53 ` Daniel Vetter 2021-07-13 6:53 ` [Intel-gfx] " Daniel Vetter 2021-07-13 6:53 ` Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-13 6:35 ` Christian König 2021-07-13 6:35 ` [Intel-gfx] " Christian König 2021-07-13 6:50 ` Daniel Vetter 2021-07-13 6:50 ` [Intel-gfx] " Daniel Vetter 2021-07-13 7:25 ` Christian König 2021-07-13 7:25 ` [Intel-gfx] " Christian König 2021-07-13 9:10 ` Daniel Vetter 2021-07-13 9:10 ` [Intel-gfx] " Daniel Vetter 2021-07-13 11:20 ` Christian König 2021-07-13 11:20 ` [Intel-gfx] " Christian König 2021-07-13 16:11 ` Andrey Grodzovsky 2021-07-13 16:11 ` [Intel-gfx] " Andrey Grodzovsky 2021-07-13 16:45 ` Daniel Vetter 2021-07-13 16:45 ` [Intel-gfx] " Daniel Vetter 2021-07-14 22:12 ` Andrey Grodzovsky 2021-07-14 22:12 ` [Intel-gfx] " Andrey Grodzovsky 2021-07-15 10:16 ` Daniel Vetter 2021-07-15 10:16 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 03/18] drm/sched: Add dependency tracking Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter 2021-07-27 11:09 ` Daniel Vetter 2021-07-27 11:09 ` [Intel-gfx] " Daniel Vetter 2021-07-27 11:09 ` Daniel Vetter 2021-07-28 11:28 ` [Linaro-mm-sig] " Christian König 2021-07-28 11:28 ` [Intel-gfx] " Christian König 2021-07-28 11:28 ` Christian König 2021-07-28 12:09 ` Daniel Vetter 2021-07-28 12:09 ` [Intel-gfx] " Daniel Vetter 2021-07-28 12:09 ` Daniel Vetter 2021-07-28 12:46 ` Christian König 2021-07-28 12:46 ` [Intel-gfx] " Christian König 2021-07-28 12:46 ` Christian König 2021-07-28 15:20 ` Melissa Wen 2021-07-28 15:20 ` [Intel-gfx] " Melissa Wen 2021-07-28 15:20 ` Melissa Wen 2021-07-12 17:53 ` [PATCH v4 04/18] drm/sched: drop entity parameter from drm_sched_push_job Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 05/18] drm/sched: improve docs around drm_sched_entity Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 06/18] drm/panfrost: use scheduler dependency tracking Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 07/18] drm/lima: " Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 08/18] drm/v3d: Move drm_sched_job_init to v3d_job_init Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-14 9:34 ` Melissa Wen 2021-07-14 9:34 ` [Intel-gfx] " Melissa Wen 2021-07-12 17:53 ` [PATCH v4 09/18] drm/v3d: Use scheduler dependency handling Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-14 9:37 ` Melissa Wen 2021-07-14 9:37 ` [Intel-gfx] " Melissa Wen 2021-07-12 17:53 ` [PATCH v4 10/18] drm/etnaviv: " Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 11/18] drm/gem: Delete gem array fencing helpers Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 12/18] drm/sched: Don't store self-dependencies Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 13/18] drm/sched: Check locking in drm_sched_job_await_implicit Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 14/18] drm/msm: Don't break exclusive fence ordering Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter 2021-07-13 16:55 ` Rob Clark 2021-07-13 16:55 ` [Intel-gfx] " Rob Clark 2021-07-13 16:55 ` Rob Clark 2021-07-13 16:58 ` Daniel Vetter 2021-07-13 16:58 ` [Intel-gfx] " Daniel Vetter 2021-07-13 16:58 ` Daniel Vetter 2021-07-13 17:46 ` Rob Clark 2021-07-13 17:46 ` [Intel-gfx] " Rob Clark 2021-07-13 17:46 ` Rob Clark 2021-07-13 17:45 ` Daniel Vetter 2021-07-13 17:45 ` [Intel-gfx] " Daniel Vetter 2021-07-13 17:45 ` Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 15/18] drm/etnaviv: " Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter [this message] 2021-07-12 17:53 ` [Intel-gfx] [PATCH v4 16/18] drm/i915: delete exclude argument from i915_sw_fence_await_reservation Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 17/18] drm/i915: Don't break exclusive fence ordering Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` [PATCH v4 18/18] dma-resv: Give the docs a do-over Daniel Vetter 2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter 2021-07-12 17:53 ` Daniel Vetter 2021-07-12 20:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/sched dependency tracking and dma-resv fixes (rev3) Patchwork 2021-07-12 21:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-07-12 23:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-07-27 11:51 ` [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes Boris Brezillon 2021-07-27 11:51 ` [Intel-gfx] " Boris Brezillon 2021-07-27 14:47 ` Melissa Wen 2021-07-27 14:47 ` [Intel-gfx] " Melissa Wen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210712175352.802687-17-daniel.vetter@ffwll.ch \ --to=daniel.vetter@ffwll.ch \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jason@jlekstrand.net \ --cc=thomas.hellstrom@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.