All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Willian Rampazzo" <wrampazz@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Kamil Rytarowski" <kamil@netbsd.org>,
	"Reinoud Zandijk" <reinoud@netbsd.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Eric Auger" <eric.auger@redhat.com>,
	qemu-arm@nongnu.org, "Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Ryo ONODERA" <ryoon@netbsd.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PULL 22/23] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp
Date: Tue, 13 Jul 2021 17:19:22 -0400	[thread overview]
Message-ID: <20210713211923.3809241-23-crosa@redhat.com> (raw)
In-Reply-To: <20210713211923.3809241-1-crosa@redhat.com>

These tests' setUp do not do anything beyong what their base class do.
And while they do decorate the setUp() we can decorate the classes
instead, so no functionality is lost here.

This is possible because since Avocado 76.0 we can decorate setUp()
directly.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210415215141.1865467-4-crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
[PMD: added note to commit message about Avocado feature/version]
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/acceptance/linux_ssh_mips_malta.py | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tests/acceptance/linux_ssh_mips_malta.py b/tests/acceptance/linux_ssh_mips_malta.py
index 61c9079d04..4de1947418 100644
--- a/tests/acceptance/linux_ssh_mips_malta.py
+++ b/tests/acceptance/linux_ssh_mips_malta.py
@@ -19,6 +19,8 @@
 from avocado.utils import ssh
 
 
+@skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
+@skipUnless(ssh.SSH_CLIENT_BINARY, 'No SSH client available')
 class LinuxSSH(Test, LinuxSSHMixIn):
 
     timeout = 150 # Not for 'configure --enable-debug --enable-debug-tcg'
@@ -65,11 +67,6 @@ def get_kernel_info(self, endianess, wordsize):
         kernel_hash = self.IMAGE_INFO[endianess]['kernel_hash'][wordsize]
         return kernel_url, kernel_hash
 
-    @skipUnless(ssh.SSH_CLIENT_BINARY, 'No SSH client available')
-    @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
-    def setUp(self):
-        super(LinuxSSH, self).setUp()
-
     def ssh_disconnect_vm(self):
         self.ssh_session.quit()
 
-- 
2.31.1



  parent reply	other threads:[~2021-07-13 21:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 21:19 [PULL 00/23] Python and Acceptance Tests Cleber Rosa
2021-07-13 21:19 ` [PULL 01/23] Acceptance Tests: use the job work directory for created VMs Cleber Rosa
2021-07-13 21:19 ` [PULL 02/23] Acceptance Tests: log information when creating QEMUMachine Cleber Rosa
2021-07-13 21:19 ` [PULL 03/23] Acceptance Tests: distinguish between temp and logs dir Cleber Rosa
2021-07-13 21:19 ` [PULL 04/23] Acceptance Tests: rename attribute holding the distro image checksum Cleber Rosa
2021-07-13 21:19 ` [PULL 05/23] Acceptance Tests: move definition of distro checksums to the framework Cleber Rosa
2021-07-13 21:19 ` [PULL 06/23] Acceptance Tests: support choosing specific distro and version Cleber Rosa
2021-07-13 21:19 ` [PULL 07/23] tests/acceptance: Ignore binary data sent on serial console Cleber Rosa
2021-07-13 21:19 ` [PULL 08/23] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class Cleber Rosa
2021-07-13 21:19 ` [PULL 09/23] Acceptance Tests: Add default kernel params and pxeboot url to the KNOWN_DISTROS collection Cleber Rosa
2021-07-13 21:19 ` [PULL 10/23] avocado_qemu: Add SMMUv3 tests Cleber Rosa
2021-07-13 21:19 ` [PULL 11/23] avocado_qemu: Add Intel iommu tests Cleber Rosa
2021-07-13 21:19 ` [PULL 12/23] tests/acceptance: Tag NetBSD tests as 'os:netbsd' Cleber Rosa
2021-07-13 21:19 ` [PULL 13/23] tests/acceptance: Automatic set -cpu to the test vm Cleber Rosa
2021-07-13 21:19 ` [PULL 14/23] tests/acceptance: Fix mismatch on cpu tagged tests Cleber Rosa
2021-07-13 21:19 ` [PULL 15/23] tests/acceptance: Let the framework handle "cpu:VALUE" " Cleber Rosa
2021-07-13 21:19 ` [PULL 16/23] tests/acceptance: Tagging tests with "cpu:VALUE" Cleber Rosa
2021-07-13 21:19 ` [PULL 17/23] python/qemu: Add args property to the QEMUMachine class Cleber Rosa
2021-07-13 21:19 ` [PULL 18/23] tests/acceptance: Add set_vm_arg() to the Test class Cleber Rosa
2021-07-13 21:19 ` [PULL 19/23] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests Cleber Rosa
2021-07-13 21:19 ` [PULL 20/23] python: Configure tox to skip missing interpreters Cleber Rosa
2021-07-13 21:19 ` [PULL 21/23] Acceptance tests: do not try to reuse packages from the system Cleber Rosa
2021-07-13 21:19 ` Cleber Rosa [this message]
2021-07-13 21:19 ` [PULL 23/23] tests/acceptance/cpu_queries.py: use the proper logging channels Cleber Rosa
2021-07-14 19:33 ` [PULL 00/23] Python and Acceptance Tests Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210713211923.3809241-23-crosa@redhat.com \
    --to=crosa@redhat.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=bleal@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=groug@kaod.org \
    --cc=hpoussin@reactos.org \
    --cc=jsnow@redhat.com \
    --cc=kamil@netbsd.org \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=reinoud@netbsd.org \
    --cc=ryoon@netbsd.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.