From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
<julien@xen.org>
Cc: <Bertrand.Marquis@arm.com>, <Penny.Zheng@arm.com>,
<Wei.Chen@arm.com>, <jbeulich@suse.com>, <nd@arm.com>
Subject: [PATCH V3 09/10] xen/arm: check "xen,static-mem" property during domain construction
Date: Thu, 15 Jul 2021 05:18:18 +0000 [thread overview]
Message-ID: <20210715051819.3073628-10-penny.zheng@arm.com> (raw)
In-Reply-To: <20210715051819.3073628-1-penny.zheng@arm.com>
This commit checks "xen,static-mem" device tree property in /domUx node,
to determine whether domain is on Static Allocation, when constructing
domain during boot-up.
Right now, the implementation of allocate_static_memory is missing, and
will be introduced later. It just BUG() out at the moment.
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v3 change:
- parse "xen,static-mem" in way of phandle back to property
- The return for dt_property_read_u32() shall be checked.
- "memory" property shall be mandatory
---
xen/arch/arm/domain_build.c | 37 ++++++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 6c86d52781..cdb16f2086 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2425,6 +2425,37 @@ static int __init construct_domU(struct domain *d,
struct kernel_info kinfo = {};
int rc;
u64 mem;
+ const struct dt_property *static_mem_prop;
+ u32 static_mem_addr_cells, static_mem_size_cells;
+ bool static_mem = false;
+
+ /*
+ * Guest RAM could be static memory which will be specified through
+ * "xen,static-mem" property.
+ */
+ static_mem_prop = dt_find_property(node, "xen,static-mem", NULL);
+ if ( static_mem_prop )
+ {
+ static_mem = true;
+
+ if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells",
+ &static_mem_addr_cells) )
+ {
+ printk("Error building DomU: cannot read "
+ "\"#xen,static-mem-address-cells\" property\n");
+ return -EINVAL;
+ }
+
+ if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells",
+ &static_mem_size_cells) )
+ {
+ printk("Error building DomU: cannot read "
+ "\"#xen,static-mem-size-cells\" property\n");
+ return -EINVAL;
+ }
+
+ BUG_ON(static_mem_size_cells > 2 || static_mem_addr_cells > 2);
+ }
rc = dt_property_read_u64(node, "memory", &mem);
if ( !rc )
@@ -2452,7 +2483,11 @@ static int __init construct_domU(struct domain *d,
/* type must be set before allocate memory */
d->arch.type = kinfo.type;
#endif
- allocate_memory(d, &kinfo);
+ if ( !static_mem )
+ allocate_memory(d, &kinfo);
+ else
+ /* TODO: allocate_static_memory(...). */
+ BUG();
rc = prepare_dtb_domU(d, &kinfo);
if ( rc < 0 )
--
2.25.1
next prev parent reply other threads:[~2021-07-15 5:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 5:18 [PATCH V3 00/10] Domain on Static Allocation Penny Zheng
2021-07-15 5:18 ` [PATCH V3 01/10] xen/arm: introduce domain " Penny Zheng
2021-07-15 5:18 ` [PATCH V3 02/10] xen/arm: introduce new helper device_tree_get_meminfo Penny Zheng
2021-07-15 5:18 ` [PATCH V3 03/10] xen/arm: handle static memory in dt_unreserved_regions Penny Zheng
2021-07-15 5:18 ` [PATCH V3 04/10] xen: introduce mark_page_free Penny Zheng
2021-07-19 8:13 ` Jan Beulich
2021-07-15 5:18 ` [PATCH V3 05/10] xen/arm: static memory initialization Penny Zheng
2021-07-19 8:20 ` Jan Beulich
2021-07-21 3:07 ` Penny Zheng
2021-07-21 8:15 ` Jan Beulich
2021-07-19 8:25 ` Jan Beulich
2021-07-15 5:18 ` [PATCH V3 06/10] xen/arm: introduce PGC_reserved Penny Zheng
2021-07-15 5:18 ` [PATCH V3 07/10] xen: re-define assign_pages and introduce assign_page Penny Zheng
2021-07-19 8:41 ` Jan Beulich
2021-07-21 5:53 ` Penny Zheng
2021-07-15 5:18 ` [PATCH V3 08/10] xen/arm: introduce acquire_staticmem_pages and acquire_domstatic_pages Penny Zheng
2021-07-19 9:26 ` Jan Beulich
2021-07-19 10:00 ` Julien Grall
2021-07-21 7:52 ` Penny Zheng
2021-07-21 7:37 ` Penny Zheng
2021-07-15 5:18 ` Penny Zheng [this message]
2021-07-15 5:18 ` [PATCH V3 10/10] xen/arm: introduce allocate_static_memory Penny Zheng
2021-07-27 3:44 ` Penny Zheng
2021-07-27 6:18 ` Penny Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715051819.3073628-10-penny.zheng@arm.com \
--to=penny.zheng@arm.com \
--cc=Bertrand.Marquis@arm.com \
--cc=Wei.Chen@arm.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=nd@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.