All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hui Liu <hui.liu@mediatek.com>
To: <robh+dt@kernel.org>, <jic23@kernel.org>, <knaack.h@gmx.de>,
	<lars@metafoo.de>, <pmeerw@pmeerw.net>
Cc: <srv_heupstream@mediatek.com>, <hui.liu@mediatek.com>,
	<zhiyong.tao@mediatek.com>, <chun-hung.wu@mediatek.com>,
	<yingjoe.chen@mediatek.com>, <seiya.wang@mediatek.com>,
	<matthias.bgg@gmail.com>, <s.hauer@pengutronix.de>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-iio@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: [PATCH] iio: mtk-auxadc: add mutex_destroy
Date: Thu, 15 Jul 2021 17:35:23 +0800	[thread overview]
Message-ID: <20210715093523.29844-2-hui.liu@mediatek.com> (raw)
In-Reply-To: <20210715093523.29844-1-hui.liu@mediatek.com>

Add mutex_destroy when probe fail and remove device.

Signed-off-by: Hui Liu <hui.liu@mediatek.com>
---
 drivers/iio/adc/mt6577_auxadc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index 79c1dd68b909..d57243037ad6 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -289,6 +289,7 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
 	ret = iio_device_register(indio_dev);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to register iio device\n");
+		mutex_destroy(&adc_dev->lock);
 		goto err_power_off;
 	}
 
@@ -313,6 +314,7 @@ static int mt6577_auxadc_remove(struct platform_device *pdev)
 			      0, MT6577_AUXADC_PDN_EN);
 
 	clk_disable_unprepare(adc_dev->adc_clk);
+	mutex_destroy(&adc_dev->lock);
 
 	return 0;
 }
-- 
2.18.0


  reply	other threads:[~2021-07-15  9:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15  9:35 [PATCH 0/1] AUXADC: Mediatek auxadc driver Hui Liu
2021-07-15  9:35 ` Hui Liu [this message]
2021-07-17 16:44   ` [PATCH] iio: mtk-auxadc: add mutex_destroy Jonathan Cameron
2021-07-17 16:44     ` Jonathan Cameron
2021-07-17 16:44     ` Jonathan Cameron
     [not found]     ` <1627042875.27985.15.camel@mhfsdcap03>
2021-07-24 17:30       ` Jonathan Cameron
2021-07-24 17:30         ` Jonathan Cameron
2021-07-24 17:30         ` Jonathan Cameron
     [not found]         ` <1627300994.11261.11.camel@mhfsdcap03>
2021-07-31 17:52           ` Jonathan Cameron
2021-07-31 17:52             ` Jonathan Cameron
2021-07-31 17:52             ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210715093523.29844-2-hui.liu@mediatek.com \
    --to=hui.liu@mediatek.com \
    --cc=chun-hung.wu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=seiya.wang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=yingjoe.chen@mediatek.com \
    --cc=zhiyong.tao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.