All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudiu Beznea <claudiu.beznea@microchip.com>
To: <linux@armlinux.org.uk>, <nicolas.ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>
Cc: <eugen.hristev@microchip.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<sfr@canb.auug.org.au>,
	Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: [PATCH 1/2] ARM: at91: fix link error
Date: Mon, 19 Jul 2021 11:03:16 +0300	[thread overview]
Message-ID: <20210719080317.1045832-2-claudiu.beznea@microchip.com> (raw)
In-Reply-To: <20210719080317.1045832-1-claudiu.beznea@microchip.com>

PM support for SAMA7G5 has been submitted to mailing list before SAMA7G5
soc support thus the SAMA7G5 was not present in AT91 Kconfig file at
that moment. SoC support for SAMA7G5 hasn't added the proper PM flags to
Kconfig thus the link error bellow:

arch/arm/mach-at91/sama7.o: In function `sama7_dt_device_init':
sama7.c:(.init.text+0x18): undefined reference to `sama7_pm_init'
make: *** [Makefile:1176: vmlinux] Error 1

Add proper flags to AT91 Kconfig file to solve the issue.

Fixes: 5617a08dd9e1 ("ARM: at91: pm: add pm support for SAMA7G5")
Fixes: 18d694ecd91e ("ARM: at91: add new SoC sama7g5") 
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/mach-at91/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index f52b46bccd85..b09bb2279f7f 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -204,6 +204,9 @@ config ATMEL_PM
 config SOC_SAMA7
 	bool
 	select ARM_GIC
+	select ATMEL_PM if PM
+	select ATMEL_SDRAMC
 	select MEMORY
 	select SOC_SAM_V7
+	select SRAM if PM
 endif
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Claudiu Beznea <claudiu.beznea@microchip.com>
To: <linux@armlinux.org.uk>, <nicolas.ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>
Cc: <eugen.hristev@microchip.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<sfr@canb.auug.org.au>,
	Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: [PATCH 1/2] ARM: at91: fix link error
Date: Mon, 19 Jul 2021 11:03:16 +0300	[thread overview]
Message-ID: <20210719080317.1045832-2-claudiu.beznea@microchip.com> (raw)
In-Reply-To: <20210719080317.1045832-1-claudiu.beznea@microchip.com>

PM support for SAMA7G5 has been submitted to mailing list before SAMA7G5
soc support thus the SAMA7G5 was not present in AT91 Kconfig file at
that moment. SoC support for SAMA7G5 hasn't added the proper PM flags to
Kconfig thus the link error bellow:

arch/arm/mach-at91/sama7.o: In function `sama7_dt_device_init':
sama7.c:(.init.text+0x18): undefined reference to `sama7_pm_init'
make: *** [Makefile:1176: vmlinux] Error 1

Add proper flags to AT91 Kconfig file to solve the issue.

Fixes: 5617a08dd9e1 ("ARM: at91: pm: add pm support for SAMA7G5")
Fixes: 18d694ecd91e ("ARM: at91: add new SoC sama7g5") 
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/mach-at91/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index f52b46bccd85..b09bb2279f7f 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -204,6 +204,9 @@ config ATMEL_PM
 config SOC_SAMA7
 	bool
 	select ARM_GIC
+	select ATMEL_PM if PM
+	select ATMEL_SDRAMC
 	select MEMORY
 	select SOC_SAM_V7
+	select SRAM if PM
 endif
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-19  8:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  8:03 [PATCH 0/2] ARM: at91: fix compilation errors after SAMA7G5 Claudiu Beznea
2021-07-19  8:03 ` Claudiu Beznea
2021-07-19  8:03 ` Claudiu Beznea [this message]
2021-07-19  8:03   ` [PATCH 1/2] ARM: at91: fix link error Claudiu Beznea
2021-07-19 12:40   ` Nicolas Ferre
2021-07-19 12:40     ` Nicolas Ferre
2021-07-19 13:17     ` Claudiu.Beznea
2021-07-19 13:17       ` Claudiu.Beznea
2021-07-19  8:03 ` [PATCH 2/2] clk: at91: add register definition for sama7g5's master clock Claudiu Beznea
2021-07-19  8:03   ` Claudiu Beznea
2021-07-19 12:46   ` Nicolas Ferre
2021-07-19 12:46     ` Nicolas Ferre
2021-07-27  1:19     ` Stephen Boyd
2021-07-27  1:19       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210719080317.1045832-2-claudiu.beznea@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=eugen.hristev@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ludovic.desroches@microchip.com \
    --cc=mturquette@baylibre.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=sboyd@kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.