All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Shiyang Ruan <ruansy.fnst@fujitsu.com>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, nvdimm@lists.linux.dev,
	cluster-devel@redhat.com
Subject: [PATCH 04/27] fs: mark the iomap argument to __block_write_begin_int const
Date: Mon, 19 Jul 2021 12:34:57 +0200	[thread overview]
Message-ID: <20210719103520.495450-5-hch@lst.de> (raw)
In-Reply-To: <20210719103520.495450-1-hch@lst.de>

__block_write_begin_int never modifies the passed in iomap, so mark it
const.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/buffer.c   | 4 ++--
 fs/internal.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index 6290c3afdba488..bd6a9e9fbd64c9 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1912,7 +1912,7 @@ EXPORT_SYMBOL(page_zero_new_buffers);
 
 static void
 iomap_to_bh(struct inode *inode, sector_t block, struct buffer_head *bh,
-		struct iomap *iomap)
+		const struct iomap *iomap)
 {
 	loff_t offset = block << inode->i_blkbits;
 
@@ -1966,7 +1966,7 @@ iomap_to_bh(struct inode *inode, sector_t block, struct buffer_head *bh,
 }
 
 int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
-		get_block_t *get_block, struct iomap *iomap)
+		get_block_t *get_block, const struct iomap *iomap)
 {
 	unsigned from = pos & (PAGE_SIZE - 1);
 	unsigned to = from + len;
diff --git a/fs/internal.h b/fs/internal.h
index 3ce8edbaa3ca2f..9ad6b5157584b8 100644
--- a/fs/internal.h
+++ b/fs/internal.h
@@ -48,8 +48,8 @@ static inline int emergency_thaw_bdev(struct super_block *sb)
 /*
  * buffer.c
  */
-extern int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
-		get_block_t *get_block, struct iomap *iomap);
+int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
+		get_block_t *get_block, const struct iomap *iomap);
 
 /*
  * char_dev.c
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 04/27] fs: mark the iomap argument to __block_write_begin_int const
Date: Mon, 19 Jul 2021 12:34:57 +0200	[thread overview]
Message-ID: <20210719103520.495450-5-hch@lst.de> (raw)
In-Reply-To: <20210719103520.495450-1-hch@lst.de>

__block_write_begin_int never modifies the passed in iomap, so mark it
const.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/buffer.c   | 4 ++--
 fs/internal.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index 6290c3afdba488..bd6a9e9fbd64c9 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1912,7 +1912,7 @@ EXPORT_SYMBOL(page_zero_new_buffers);
 
 static void
 iomap_to_bh(struct inode *inode, sector_t block, struct buffer_head *bh,
-		struct iomap *iomap)
+		const struct iomap *iomap)
 {
 	loff_t offset = block << inode->i_blkbits;
 
@@ -1966,7 +1966,7 @@ iomap_to_bh(struct inode *inode, sector_t block, struct buffer_head *bh,
 }
 
 int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
-		get_block_t *get_block, struct iomap *iomap)
+		get_block_t *get_block, const struct iomap *iomap)
 {
 	unsigned from = pos & (PAGE_SIZE - 1);
 	unsigned to = from + len;
diff --git a/fs/internal.h b/fs/internal.h
index 3ce8edbaa3ca2f..9ad6b5157584b8 100644
--- a/fs/internal.h
+++ b/fs/internal.h
@@ -48,8 +48,8 @@ static inline int emergency_thaw_bdev(struct super_block *sb)
 /*
  * buffer.c
  */
-extern int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
-		get_block_t *get_block, struct iomap *iomap);
+int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
+		get_block_t *get_block, const struct iomap *iomap);
 
 /*
  * char_dev.c
-- 
2.30.2



  parent reply	other threads:[~2021-07-19 10:41 UTC|newest]

Thread overview: 117+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 10:34 RFC: switch iomap to an iterator model Christoph Hellwig
2021-07-19 10:34 ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:34 ` [PATCH 01/27] iomap: fix a trivial comment typo in trace.h Christoph Hellwig
2021-07-19 10:34   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 16:00   ` Darrick J. Wong
2021-07-19 16:00     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:34 ` [PATCH 02/27] iomap: remove the iomap arguments to ->page_{prepare,done} Christoph Hellwig
2021-07-19 10:34   ` [Cluster-devel] [PATCH 02/27] iomap: remove the iomap arguments to ->page_{prepare, done} Christoph Hellwig
2021-07-19 16:04   ` [PATCH 02/27] iomap: remove the iomap arguments to ->page_{prepare,done} Darrick J. Wong
2021-07-19 16:04     ` [Cluster-devel] [PATCH 02/27] iomap: remove the iomap arguments to ->page_{prepare, done} Darrick J. Wong
2021-07-19 10:34 ` [PATCH 03/27] iomap: mark the iomap argument to iomap_sector const Christoph Hellwig
2021-07-19 10:34   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 16:08   ` Darrick J. Wong
2021-07-19 16:08     ` [Cluster-devel] " Darrick J. Wong
2021-07-20  9:52     ` Nikolay Borisov
2021-07-20  9:52       ` [Cluster-devel] " Nikolay Borisov
2021-07-26  8:12     ` Christoph Hellwig
2021-07-26  8:12       ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:34 ` Christoph Hellwig [this message]
2021-07-19 10:34   ` [Cluster-devel] [PATCH 04/27] fs: mark the iomap argument to __block_write_begin_int const Christoph Hellwig
2021-07-19 17:35   ` Darrick J. Wong
2021-07-19 17:35     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:34 ` [PATCH 05/27] fsdax: mark the iomap argument to dax_iomap_sector as const Christoph Hellwig
2021-07-19 10:34   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:35   ` Darrick J. Wong
2021-07-19 17:35     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:34 ` [PATCH 06/27] iomap: mark the iomap argument to iomap_read_inline_data const Christoph Hellwig
2021-07-19 10:34   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:35   ` Darrick J. Wong
2021-07-19 17:35     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:35 ` [PATCH 07/27] iomap: mark the iomap argument to iomap_read_page_sync const Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:35   ` Darrick J. Wong
2021-07-19 17:35     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:35 ` [PATCH 08/27] iomap: add the new iomap_iter model Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 16:56   ` Darrick J. Wong
2021-07-19 16:56     ` [Cluster-devel] " Darrick J. Wong
2021-07-26  8:15     ` Christoph Hellwig
2021-07-26  8:15       ` [Cluster-devel] " Christoph Hellwig
2021-07-19 21:48   ` Dave Chinner
2021-07-19 21:48     ` [Cluster-devel] " Dave Chinner
2021-07-26  8:17     ` Christoph Hellwig
2021-07-26  8:17       ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 09/27] iomap: switch readahead and readpage to use iomap_iter Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 10/27] iomap: switch iomap_file_buffered_write " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 11/27] iomap: switch iomap_file_unshare " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 12/27] iomap: switch iomap_zero_range " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 13/27] iomap: switch iomap_page_mkwrite " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 14/27] iomap: switch __iomap_dio_rw " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 15/27] iomap: switch iomap_fiemap " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 16/27] iomap: switch iomap_bmap " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:05   ` Darrick J. Wong
2021-07-19 17:05     ` [Cluster-devel] " Darrick J. Wong
2021-07-26  8:19     ` Christoph Hellwig
2021-07-26  8:19       ` [Cluster-devel] " Christoph Hellwig
2021-07-26 16:39       ` Darrick J. Wong
2021-07-26 16:39         ` [Cluster-devel] " Darrick J. Wong
2021-07-27  6:31         ` Christoph Hellwig
2021-07-27  6:31           ` [Cluster-devel] " Christoph Hellwig
2021-07-27 14:32           ` Darrick J. Wong
2021-07-27 14:32             ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:35 ` [PATCH 17/27] iomap: switch iomap_seek_hole " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:22   ` Darrick J. Wong
2021-07-19 17:22     ` [Cluster-devel] " Darrick J. Wong
2021-07-26  8:22     ` Christoph Hellwig
2021-07-26  8:22       ` [Cluster-devel] " Christoph Hellwig
2021-07-26 16:41       ` Darrick J. Wong
2021-07-26 16:41         ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:35 ` [PATCH 18/27] iomap: switch iomap_seek_data " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 19/27] iomap: switch iomap_swapfile_activate " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 20/27] fsdax: switch dax_iomap_rw " Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 22:10   ` Dave Chinner
2021-07-19 22:10     ` [Cluster-devel] " Dave Chinner
2021-07-26  8:25     ` Christoph Hellwig
2021-07-26  8:25       ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 21/27] iomap: remove iomap_apply Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:48   ` Darrick J. Wong
2021-07-19 17:48     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:35 ` [PATCH 22/27] iomap: pass an iomap_iter to various buffered I/O helpers Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:48   ` Darrick J. Wong
2021-07-19 17:48     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:35 ` [PATCH 23/27] iomap: rework unshare flag Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:44   ` Darrick J. Wong
2021-07-19 17:44     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:35 ` [PATCH 24/27] fsdax: factor out helpers to simplify the dax fault code Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 25/27] fsdax: factor out a dax_fault_actor() helper Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 10:35 ` [PATCH 26/27] fsdax: switch the fault handlers to use iomap_iter Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:35   ` Darrick J. Wong
2021-07-19 17:35     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 10:35 ` [PATCH 27/27] iomap: constify iomap_iter_srcmap Christoph Hellwig
2021-07-19 10:35   ` [Cluster-devel] " Christoph Hellwig
2021-07-19 17:44   ` Darrick J. Wong
2021-07-19 17:44     ` [Cluster-devel] " Darrick J. Wong
2021-07-19 17:57 ` RFC: switch iomap to an iterator model Darrick J. Wong
2021-07-19 17:57   ` [Cluster-devel] " Darrick J. Wong
2021-07-27  8:07   ` DAX setup pains, was " Christoph Hellwig
2021-07-29 20:33 ` Darrick J. Wong
2021-07-29 20:33   ` [Cluster-devel] " Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210719103520.495450-5-hch@lst.de \
    --to=hch@lst.de \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=djwong@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=ruansy.fnst@fujitsu.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.