From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: kernel test robot <lkp@intel.com>
Subject: [PATCH net-next 1/2] net: switchdev: remove stray semicolon in switchdev_handle_fdb_del_to_device shim
Date: Tue, 20 Jul 2021 20:35:56 +0300 [thread overview]
Message-ID: <20210720173557.999534-2-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20210720173557.999534-1-vladimir.oltean@nxp.com>
With the semicolon at the end, the compiler sees the shim function as a
declaration and not as a definition, and warns:
'switchdev_handle_fdb_del_to_device' declared 'static' but never defined
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 8ca07176ab00 ("net: switchdev: introduce a fanout helper for SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
include/net/switchdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 6f57eb2e89cc..66468ff8cc0a 100644
--- a/include/net/switchdev.h
+++ b/include/net/switchdev.h
@@ -406,7 +406,7 @@ switchdev_handle_fdb_del_to_device(struct net_device *dev,
const struct switchdev_notifier_fdb_info *fdb_info),
int (*lag_del_cb)(struct net_device *dev,
const struct net_device *orig_dev, const void *ctx,
- const struct switchdev_notifier_fdb_info *fdb_info));
+ const struct switchdev_notifier_fdb_info *fdb_info))
{
return 0;
}
--
2.25.1
next prev parent reply other threads:[~2021-07-20 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 17:35 [PATCH net-next 0/2] Fixes for the switchdev FDB fan-out helpers Vladimir Oltean
2021-07-20 17:35 ` Vladimir Oltean [this message]
2021-07-21 7:57 ` [PATCH net-next 1/2] net: switchdev: remove stray semicolon in switchdev_handle_fdb_del_to_device shim Matthieu Baerts
2021-07-20 17:35 ` [PATCH net-next 2/2] net: switchdev: recurse into __switchdev_handle_fdb_del_to_device Vladimir Oltean
2021-07-21 15:10 ` [PATCH net-next 0/2] Fixes for the switchdev FDB fan-out helpers patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720173557.999534-2-vladimir.oltean@nxp.com \
--to=vladimir.oltean@nxp.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.