From: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com> To: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, davem@davemloft.net, kuba@kernel.org, matthieu.baerts@tessares.net, stefan@datenfreihafen.org Cc: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, gregkh@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [PATCH v3 0/2] Bluetooth: fix inconsistent lock states Date: Wed, 21 Jul 2021 17:38:30 +0800 [thread overview] Message-ID: <20210721093832.78081-1-desmondcheongzx@gmail.com> (raw) Hi, This series addresses inconsistent lock states first identified by Syzbot here: https://syzkaller.appspot.com/bug?extid=2f6d7c28bb4bf7e82060 v2 -> v3: - Split SCO and RFCOMM code changes, as suggested by Luiz Augusto von Dentz. - Simplify local bh disabling in SCO by using local_bh_disable/enable inside sco_chan_del. The rationale is inside the commit message, but in summary I initially wanted to avoid nesting local_bh_disable until I learned that local_bh_disable/enable pairs are reentrant. v1 -> v2: - Instead of pulling out the clean-up code out from sco_chan_del and using it directly in sco_conn_del, disable local softirqs for relevant sections. - Disable local softirqs more thoroughly for instances of bh_lock_sock/bh_lock_sock_nested in the bluetooth subsystem. Specifically, the calls in af_bluetooth.c and rfcomm/sock.c are now made with local softirqs disabled as well. Best wishes, Desmond Desmond Cheong Zhi Xi (2): Bluetooth: fix inconsistent lock state in SCO Bluetooth: fix inconsistent lock state in rfcomm_connect_ind net/bluetooth/rfcomm/sock.c | 2 ++ net/bluetooth/sco.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com> To: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, davem@davemloft.net, kuba@kernel.org, matthieu.baerts@tessares.net, stefan@datenfreihafen.org Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>, linux-kernel-mentees@lists.linuxfoundation.org Subject: [PATCH v3 0/2] Bluetooth: fix inconsistent lock states Date: Wed, 21 Jul 2021 17:38:30 +0800 [thread overview] Message-ID: <20210721093832.78081-1-desmondcheongzx@gmail.com> (raw) Hi, This series addresses inconsistent lock states first identified by Syzbot here: https://syzkaller.appspot.com/bug?extid=2f6d7c28bb4bf7e82060 v2 -> v3: - Split SCO and RFCOMM code changes, as suggested by Luiz Augusto von Dentz. - Simplify local bh disabling in SCO by using local_bh_disable/enable inside sco_chan_del. The rationale is inside the commit message, but in summary I initially wanted to avoid nesting local_bh_disable until I learned that local_bh_disable/enable pairs are reentrant. v1 -> v2: - Instead of pulling out the clean-up code out from sco_chan_del and using it directly in sco_conn_del, disable local softirqs for relevant sections. - Disable local softirqs more thoroughly for instances of bh_lock_sock/bh_lock_sock_nested in the bluetooth subsystem. Specifically, the calls in af_bluetooth.c and rfcomm/sock.c are now made with local softirqs disabled as well. Best wishes, Desmond Desmond Cheong Zhi Xi (2): Bluetooth: fix inconsistent lock state in SCO Bluetooth: fix inconsistent lock state in rfcomm_connect_ind net/bluetooth/rfcomm/sock.c | 2 ++ net/bluetooth/sco.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+) -- 2.25.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next reply other threads:[~2021-07-21 9:42 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-21 9:38 Desmond Cheong Zhi Xi [this message] 2021-07-21 9:38 ` [PATCH v3 0/2] Bluetooth: fix inconsistent lock states Desmond Cheong Zhi Xi 2021-07-21 9:38 ` [PATCH v3 1/2] Bluetooth: fix inconsistent lock state in SCO Desmond Cheong Zhi Xi 2021-07-21 9:38 ` Desmond Cheong Zhi Xi 2021-07-21 11:09 ` Bluetooth: fix inconsistent lock states bluez.test.bot 2021-07-27 0:30 ` [PATCH v3 1/2] Bluetooth: fix inconsistent lock state in SCO Luiz Augusto von Dentz 2021-07-27 0:30 ` Luiz Augusto von Dentz 2021-07-27 5:13 ` Desmond Cheong Zhi Xi 2021-07-27 5:13 ` Desmond Cheong Zhi Xi 2021-07-21 9:38 ` [PATCH v3 2/2] Bluetooth: fix inconsistent lock state in rfcomm_connect_ind Desmond Cheong Zhi Xi 2021-07-21 9:38 ` Desmond Cheong Zhi Xi 2021-07-29 19:53 ` Marcel Holtmann 2021-07-29 19:53 ` Marcel Holtmann 2021-07-30 9:06 ` Desmond Cheong Zhi Xi 2021-07-30 9:06 ` Desmond Cheong Zhi Xi 2021-07-30 13:40 ` Marcel Holtmann 2021-07-30 13:40 ` Marcel Holtmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210721093832.78081-1-desmondcheongzx@gmail.com \ --to=desmondcheongzx@gmail.com \ --cc=davem@davemloft.net \ --cc=gregkh@linuxfoundation.org \ --cc=johan.hedberg@gmail.com \ --cc=kuba@kernel.org \ --cc=linux-bluetooth@vger.kernel.org \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luiz.dentz@gmail.com \ --cc=marcel@holtmann.org \ --cc=matthieu.baerts@tessares.net \ --cc=netdev@vger.kernel.org \ --cc=skhan@linuxfoundation.org \ --cc=stefan@datenfreihafen.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.