All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mahmoud Mandour <ma.mandourr@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Mahmoud Mandour" <ma.mandourr@gmail.com>,
	cota@braap.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v3 2/5] plugins/cache: limited the scope of a mutex lock
Date: Thu, 22 Jul 2021 08:54:25 +0200	[thread overview]
Message-ID: <20210722065428.134608-3-ma.mandourr@gmail.com> (raw)
In-Reply-To: <20210722065428.134608-1-ma.mandourr@gmail.com>

It's not necessary to lock the address translation portion of the
vcpu_mem_access callback.

Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
---
 contrib/plugins/cache.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/contrib/plugins/cache.c b/contrib/plugins/cache.c
index 4a71602639..695fb969dc 100644
--- a/contrib/plugins/cache.c
+++ b/contrib/plugins/cache.c
@@ -355,15 +355,14 @@ static void vcpu_mem_access(unsigned int vcpu_index, qemu_plugin_meminfo_t info,
     struct qemu_plugin_hwaddr *hwaddr;
     InsnData *insn;
 
-    g_mutex_lock(&mtx);
     hwaddr = qemu_plugin_get_hwaddr(info, vaddr);
     if (hwaddr && qemu_plugin_hwaddr_is_io(hwaddr)) {
-        g_mutex_unlock(&mtx);
         return;
     }
 
     effective_addr = hwaddr ? qemu_plugin_hwaddr_phys_addr(hwaddr) : vaddr;
 
+    g_mutex_lock(&mtx);
     if (!access_cache(dcache, effective_addr)) {
         insn = (InsnData *) userdata;
         insn->dmisses++;
-- 
2.25.1



  parent reply	other threads:[~2021-07-22  7:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  6:54 [PATCH v3 0/5] plugins/cache: multicore cache modelling and minor tweaks Mahmoud Mandour
2021-07-22  6:54 ` [PATCH v3 1/5] plugins/cache: Fixed a bug with destroying FIFO metadata Mahmoud Mandour
2021-07-22  6:54 ` Mahmoud Mandour [this message]
2021-07-22  6:54 ` [PATCH v3 3/5] plugins/cache: Supported multicore cache modelling Mahmoud Mandour
2021-07-22  6:54 ` [PATCH v3 4/5] docs/devel/tcg-plugins: added cores arg to cache plugin Mahmoud Mandour
2021-07-22  6:54 ` [PATCH v3 5/5] plugins/cache: Fixed "function decl. is not a prototype" warnings Mahmoud Mandour
2021-08-02 11:24 ` [PATCH v3 0/5] plugins/cache: multicore cache modelling and minor tweaks Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210722065428.134608-3-ma.mandourr@gmail.com \
    --to=ma.mandourr@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=cota@braap.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.