All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Dave Gerlach <d-gerlach@ti.com>, Hari Nagalla <hnagalla@ti.com>,
	Praneeth Bajjuri <praneeth@ti.com>, <u-boot@lists.denx.de>,
	Suman Anna <s-anna@ti.com>
Subject: [PATCH 2/5] arm: mach-k3: j721e: Cleanup MAIN R5 boot code from R5 SPL
Date: Mon, 26 Jul 2021 16:13:08 -0500	[thread overview]
Message-ID: <20210726211311.5977-3-s-anna@ti.com> (raw)
In-Reply-To: <20210726211311.5977-1-s-anna@ti.com>

The common J7 specific start_non_linux_remote_cores() override function
implements the logic to load and boot the Main R5FSS Core0 from R5 SPL.
This won't be supported any more for either J721E or J7200 after the R5
SPL rearchitecture for the System Firmware split into TI Foundation
Security (TIFS) and Device Management (DM) firmwares. So, cleanup the
corresponding code and the related SPL env variables.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/mach-k3/j721e_init.c | 40 -----------------------------------
 include/configs/j721e_evm.h   |  2 --
 2 files changed, 42 deletions(-)

diff --git a/arch/arm/mach-k3/j721e_init.c b/arch/arm/mach-k3/j721e_init.c
index 55d738396bd4..78d80be1758e 100644
--- a/arch/arm/mach-k3/j721e_init.c
+++ b/arch/arm/mach-k3/j721e_init.c
@@ -370,43 +370,3 @@ void release_resources_for_core_shutdown(void)
 	}
 }
 #endif
-
-#ifdef CONFIG_SYS_K3_SPL_ATF
-void start_non_linux_remote_cores(void)
-{
-	int size = 0, ret;
-	u32 loadaddr = 0;
-
-	/*
-	 * Skip booting of Main R5FSS Core0 in R5 SPL. This is no longer
-	 * supported after the R5 SPL re-architecture.
-	 */
-	if (soc_is_j721e() || soc_is_j7200())
-		return;
-
-	size = load_firmware("name_mainr5f0_0fw", "addr_mainr5f0_0load",
-			     &loadaddr);
-	if (size <= 0)
-		goto err_load;
-
-	/* assuming remoteproc 2 is aliased for the needed remotecore */
-	ret = rproc_load(2, loadaddr, size);
-	if (ret) {
-		printf("Firmware failed to start on rproc (%d)\n", ret);
-		goto err_load;
-	}
-
-	ret = rproc_start(2);
-	if (ret) {
-		printf("Firmware init failed on rproc (%d)\n", ret);
-		goto err_load;
-	}
-
-	printf("Remoteproc 2 started successfully\n");
-
-	return;
-
-err_load:
-	rproc_reset(2);
-}
-#endif
diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm.h
index cc9faae4be83..4bca62ea91ca 100644
--- a/include/configs/j721e_evm.h
+++ b/include/configs/j721e_evm.h
@@ -82,8 +82,6 @@
 #ifdef CONFIG_SYS_K3_SPL_ATF
 #if defined(CONFIG_TARGET_J721E_R5_EVM)
 #define EXTRA_ENV_R5_SPL_RPROC_FW_ARGS_MMC				\
-	"addr_mainr5f0_0load=0x88000000\0"				\
-	"name_mainr5f0_0fw=/lib/firmware/j7-main-r5f0_0-fw\0"		\
 	"addr_mcur5f0_0load=0x89000000\0"				\
 	"name_mcur5f0_0fw=/lib/firmware/j7-mcu-r5f0_0-fw\0"
 #elif defined(CONFIG_TARGET_J7200_R5_EVM)
-- 
2.32.0


  parent reply	other threads:[~2021-07-26 21:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 21:13 [PATCH 0/5] Cleanup MAIN R5F boot from R5 SPL Suman Anna
2021-07-26 21:13 ` [PATCH 1/5] arm: mach-k3: j721e: Move booting of Main R5FSS Core0 to A72 U-Boot Suman Anna
2021-07-26 21:13 ` Suman Anna [this message]
2021-07-26 21:13 ` [PATCH 3/5] arm: mach-k3: Cleanup common start_non_linux_remote_cores() Suman Anna
2021-07-26 21:13 ` [PATCH 4/5] arm: dts: k3-j721e-r5: Remove MAIN R5FSS0 cluster from SPL Suman Anna
2021-07-26 21:13 ` [PATCH 5/5] configs: j721e_evm_r5: Disable K3 R5F remoteproc Suman Anna
2021-07-26 21:23 ` [PATCH 0/5] Cleanup MAIN R5F boot from R5 SPL Suman Anna
2021-07-29  5:14 ` Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210726211311.5977-3-s-anna@ti.com \
    --to=s-anna@ti.com \
    --cc=d-gerlach@ti.com \
    --cc=hnagalla@ti.com \
    --cc=lokeshvutla@ti.com \
    --cc=praneeth@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.