From: Shiyang Ruan <ruansy.fnst@fujitsu.com> To: <linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>, <nvdimm@lists.linux.dev>, <linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>, <dm-devel@redhat.com> Cc: <djwong@kernel.org>, <dan.j.williams@intel.com>, <david@fromorbit.com>, <hch@lst.de>, <agk@redhat.com>, <snitzer@redhat.com> Subject: [PATCH RESEND v6 9/9] fsdax: add exception for reflinked files Date: Fri, 30 Jul 2021 18:01:58 +0800 [thread overview] Message-ID: <20210730100158.3117319-10-ruansy.fnst@fujitsu.com> (raw) In-Reply-To: <20210730100158.3117319-1-ruansy.fnst@fujitsu.com> For reflinked files, one dax page may be associated more than once with different fime mapping and index. It will report warning. Now, since we have introduced dax-RMAP for this case and also have to keep its functionality for other filesystems who are not support rmap, I add this exception here. Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com> --- fs/dax.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index dce6307a12eb..f5910d178695 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -352,9 +352,10 @@ static void dax_associate_entry(void *entry, struct address_space *mapping, for_each_mapped_pfn(entry, pfn) { struct page *page = pfn_to_page(pfn); - WARN_ON_ONCE(page->mapping); - page->mapping = mapping; - page->index = index + i++; + if (!page->mapping) { + page->mapping = mapping; + page->index = index + i++; + } } } @@ -370,9 +371,10 @@ static void dax_disassociate_entry(void *entry, struct address_space *mapping, struct page *page = pfn_to_page(pfn); WARN_ON_ONCE(trunc && page_ref_count(page) > 1); - WARN_ON_ONCE(page->mapping && page->mapping != mapping); - page->mapping = NULL; - page->index = 0; + if (page->mapping == mapping) { + page->mapping = NULL; + page->index = 0; + } } } -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Shiyang Ruan <ruansy.fnst@fujitsu.com> To: <linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>, <nvdimm@lists.linux.dev>, <linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>, <dm-devel@redhat.com> Cc: snitzer@redhat.com, djwong@kernel.org, david@fromorbit.com, dan.j.williams@intel.com, hch@lst.de, agk@redhat.com Subject: [dm-devel] [PATCH RESEND v6 9/9] fsdax: add exception for reflinked files Date: Fri, 30 Jul 2021 18:01:58 +0800 [thread overview] Message-ID: <20210730100158.3117319-10-ruansy.fnst@fujitsu.com> (raw) In-Reply-To: <20210730100158.3117319-1-ruansy.fnst@fujitsu.com> For reflinked files, one dax page may be associated more than once with different fime mapping and index. It will report warning. Now, since we have introduced dax-RMAP for this case and also have to keep its functionality for other filesystems who are not support rmap, I add this exception here. Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com> --- fs/dax.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index dce6307a12eb..f5910d178695 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -352,9 +352,10 @@ static void dax_associate_entry(void *entry, struct address_space *mapping, for_each_mapped_pfn(entry, pfn) { struct page *page = pfn_to_page(pfn); - WARN_ON_ONCE(page->mapping); - page->mapping = mapping; - page->index = index + i++; + if (!page->mapping) { + page->mapping = mapping; + page->index = index + i++; + } } } @@ -370,9 +371,10 @@ static void dax_disassociate_entry(void *entry, struct address_space *mapping, struct page *page = pfn_to_page(pfn); WARN_ON_ONCE(trunc && page_ref_count(page) > 1); - WARN_ON_ONCE(page->mapping && page->mapping != mapping); - page->mapping = NULL; - page->index = 0; + if (page->mapping == mapping) { + page->mapping = NULL; + page->index = 0; + } } } -- 2.32.0 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-07-30 10:02 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-30 10:01 [PATCH RESEND v6 0/9] fsdax: introduce fs query to support reflink Shiyang Ruan 2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan 2021-07-30 10:01 ` [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure() Shiyang Ruan 2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan 2021-08-06 1:17 ` Jane Chu 2021-08-06 1:17 ` [dm-devel] " Jane Chu 2021-08-16 17:20 ` Jane Chu 2021-08-16 17:20 ` [dm-devel] " Jane Chu 2021-08-17 1:44 ` ruansy.fnst 2021-08-17 1:44 ` [dm-devel] " ruansy.fnst 2021-08-18 5:43 ` Jane Chu 2021-08-18 5:43 ` [dm-devel] " Jane Chu 2021-08-18 6:08 ` Jane Chu 2021-08-18 6:08 ` [dm-devel] " Jane Chu 2021-08-18 7:52 ` ruansy.fnst 2021-08-18 7:52 ` [dm-devel] " ruansy.fnst 2021-08-18 17:10 ` Dan Williams 2021-08-18 17:10 ` [dm-devel] " Dan Williams 2021-08-18 17:10 ` Dan Williams 2021-08-23 13:21 ` hch 2021-08-23 13:21 ` [dm-devel] " hch 2021-08-18 15:52 ` Darrick J. Wong 2021-08-18 15:52 ` [dm-devel] " Darrick J. Wong 2021-08-19 7:18 ` Jane Chu 2021-08-19 7:18 ` [dm-devel] " Jane Chu 2021-08-19 8:11 ` Jane Chu 2021-08-19 8:11 ` [dm-devel] " Jane Chu 2021-08-19 9:10 ` ruansy.fnst 2021-08-19 9:10 ` [dm-devel] " ruansy.fnst 2021-08-19 20:50 ` Jane Chu 2021-08-19 20:50 ` [dm-devel] " Jane Chu 2021-08-20 16:07 ` Dan Williams 2021-08-20 16:07 ` Dan Williams 2021-08-20 16:07 ` [dm-devel] " Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device Shiyang Ruan 2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan 2021-08-06 1:02 ` Jane Chu 2021-08-06 1:02 ` [dm-devel] " Jane Chu 2021-08-17 1:45 ` ruansy.fnst 2021-08-17 1:45 ` [dm-devel] " ruansy.fnst 2021-08-20 16:06 ` Dan Williams 2021-08-20 16:06 ` Dan Williams 2021-08-20 16:06 ` [dm-devel] " Dan Williams 2021-08-20 20:19 ` Dan Williams 2021-08-20 20:19 ` [dm-devel] " Dan Williams 2021-08-20 20:19 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 3/9] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan 2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan 2021-08-06 1:00 ` Jane Chu 2021-08-06 1:00 ` [dm-devel] " Jane Chu 2021-08-20 16:54 ` Dan Williams 2021-08-20 16:54 ` [dm-devel] " Dan Williams 2021-08-20 16:54 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 4/9] pmem,mm: Implement ->memory_failure in pmem driver Shiyang Ruan 2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 4/9] pmem, mm: " Shiyang Ruan 2021-08-20 20:51 ` [PATCH RESEND v6 4/9] pmem,mm: " Dan Williams 2021-08-20 20:51 ` [dm-devel] [PATCH RESEND v6 4/9] pmem, mm: " Dan Williams 2021-08-20 20:51 ` [PATCH RESEND v6 4/9] pmem,mm: " Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 5/9] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan 2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan 2021-08-06 0:59 ` Jane Chu 2021-08-06 0:59 ` [dm-devel] " Jane Chu 2021-08-20 22:40 ` Dan Williams 2021-08-20 22:40 ` [dm-devel] " Dan Williams 2021-08-20 22:40 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 6/9] xfs: Implement ->notify_failure() for XFS Shiyang Ruan 2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan 2021-08-06 0:50 ` Jane Chu 2021-08-06 0:50 ` [dm-devel] " Jane Chu 2021-08-20 22:56 ` Dan Williams 2021-08-20 22:56 ` [dm-devel] " Dan Williams 2021-08-20 22:56 ` Dan Williams 2021-08-20 22:59 ` Dan Williams 2021-08-20 22:59 ` [dm-devel] " Dan Williams 2021-08-20 22:59 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 7/9] dm: Introduce ->rmap() to find bdev offset Shiyang Ruan 2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan 2021-08-20 23:46 ` Dan Williams 2021-08-20 23:46 ` [dm-devel] " Dan Williams 2021-08-20 23:46 ` Dan Williams 2021-07-30 10:01 ` [PATCH RESEND v6 8/9] md: Implement dax_holder_operations Shiyang Ruan 2021-07-30 10:01 ` [dm-devel] " Shiyang Ruan 2021-08-06 0:48 ` Jane Chu 2021-08-06 0:48 ` [dm-devel] " Jane Chu 2021-08-17 1:59 ` ruansy.fnst 2021-08-17 1:59 ` [dm-devel] " ruansy.fnst 2021-07-30 10:01 ` Shiyang Ruan [this message] 2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 9/9] fsdax: add exception for reflinked files Shiyang Ruan 2021-08-06 0:46 ` Jane Chu 2021-08-06 0:46 ` [dm-devel] " Jane Chu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210730100158.3117319-10-ruansy.fnst@fujitsu.com \ --to=ruansy.fnst@fujitsu.com \ --cc=agk@redhat.com \ --cc=dan.j.williams@intel.com \ --cc=david@fromorbit.com \ --cc=djwong@kernel.org \ --cc=dm-devel@redhat.com \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-xfs@vger.kernel.org \ --cc=nvdimm@lists.linux.dev \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.