All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH 13/14 resent] staging: r8188eu: remove DbgPrint and RT_PRINTK macro definitions
Date: Sat, 31 Jul 2021 01:39:36 +0100	[thread overview]
Message-ID: <20210731003937.68615-14-phil@philpotter.co.uk> (raw)
In-Reply-To: <20210731003937.68615-1-phil@philpotter.co.uk>

Remove DbgPrint and RT_PRINTK macro definitions from include/odm_debug.h,
as they are called from nowhere and are therefore superfluous. Also
remove comment in core/rtw_xmit.c referring to DbgPrint so that future
confusion is prevented.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
---
 drivers/staging/r8188eu/core/rtw_xmit.c     | 1 -
 drivers/staging/r8188eu/include/odm_debug.h | 4 ----
 2 files changed, 5 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
index 7ecffadcb61f..c87ecf59b232 100644
--- a/drivers/staging/r8188eu/core/rtw_xmit.c
+++ b/drivers/staging/r8188eu/core/rtw_xmit.c
@@ -670,7 +670,6 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfr
 				rtw_secmicsetkey(&micdata, psecuritypriv->dot118021XGrptxmickey[psecuritypriv->dot118021XGrpKeyid].skey);
 			} else {
 				if (!memcmp(&stainfo->dot11tkiptxmickey.skey[0], null_key, 16)) {
-					/* DbgPrint("\nxmitframe_addmic:stainfo->dot11tkiptxmickey == 0\n"); */
 					/* rtw_msleep_os(10); */
 					return _FAIL;
 				}
diff --git a/drivers/staging/r8188eu/include/odm_debug.h b/drivers/staging/r8188eu/include/odm_debug.h
index 38b07664b07c..c71d890ac552 100644
--- a/drivers/staging/r8188eu/include/odm_debug.h
+++ b/drivers/staging/r8188eu/include/odm_debug.h
@@ -64,10 +64,6 @@
 #define ODM_COMP_INIT					BIT31
 
 /*------------------------Export Marco Definition---------------------------*/
-#define DbgPrint	pr_info
-#define RT_PRINTK(fmt, args...)				\
-	DbgPrint( "%s(): " fmt, __func__, ## args);
-
 void ODM_InitDebugSetting(struct odm_dm_struct *pDM_Odm);
 
 #endif	/*  __ODM_DBG_H__ */
-- 
2.31.1


  parent reply	other threads:[~2021-07-31  0:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31  0:39 [PATCH 00/14 resent] staging: r8188eu: remove include/odm_debug.h Phillip Potter
2021-07-31  0:39 ` [PATCH 01/14 resent] staging: r8188eu: remove ODM_PRINT_ADDR macro definition Phillip Potter
2021-07-31  0:39 ` [PATCH 02/14 resent] staging: r8188eu: remove ODM_dbg_* macro definitions Phillip Potter
2021-07-31  0:39 ` [PATCH 03/14 resent] staging: r8188eu: remove ODM_RT_ASSERT macro definition and caller Phillip Potter
2021-07-31  0:39 ` [PATCH 04/14 resent] staging: r8188eu: remove ODM_RT_TRACE_F macro definition Phillip Potter
2021-07-31  0:39 ` [PATCH 05/14 resent] staging: r8188eu: remove ASSERT ifndef and " Phillip Potter
2021-07-31  0:39 ` [PATCH 06/14 resent] staging: r8188eu: remove ODM_RT_TRACE calls from hal/Hal8188ERateAdaptive.c Phillip Potter
2021-07-31  0:39 ` [PATCH 07/14 resent] staging: r8188eu: remove ODM_RT_TRACE calls from hal/HalPhyRf_8188e.c Phillip Potter
2021-07-31  3:31   ` kernel test robot
2021-07-31  3:31     ` kernel test robot
2021-07-31  0:39 ` [PATCH 08/14 resent] staging: r8188eu: remove ODM_RT_TRACE calls from hal/odm_HWConfig.c Phillip Potter
2021-07-31  0:39 ` [PATCH 09/14 resent] staging: r8188eu: remove ODM_RT_TRACE calls from hal/odm_RTL8188E.c Phillip Potter
2021-07-31  0:39 ` [PATCH 10/14 resent] staging: r8188eu: remove ODM_RT_TRACE calls from hal/odm_RegConfig8188E.c Phillip Potter
2021-07-31  0:39 ` [PATCH 11/14 resent] staging: r8188eu: remove ODM_RT_TRACE calls from hal/odm.c Phillip Potter
2021-07-31  0:39 ` [PATCH 12/14 resent] staging: r8188eu: remove ODM_RT_TRACE macro definition Phillip Potter
2021-07-31  0:39 ` Phillip Potter [this message]
2021-07-31  0:39 ` [PATCH 14/14 resent] staging: r8188eu: remove include/odm_debug.h Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210731003937.68615-14-phil@philpotter.co.uk \
    --to=phil@philpotter.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.