From: Thomas Zimmermann <tzimmermann@suse.de> To: daniel@ffwll.ch, airlied@linux.ie, alexander.deucher@amd.com, christian.koenig@amd.com, liviu.dudau@arm.com, brian.starkey@arm.com, sam@ravnborg.org, bbrezillon@kernel.org, nicolas.ferre@microchip.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, stefan@agner.ch, alison.wang@nxp.com, patrik.r.jakobsson@gmail.com, anitha.chrisanthus@intel.com, robdclark@gmail.com, edmund.j.dea@intel.com, sean@poorly.run, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, jyri.sarha@iki.fi, tomba@kernel.org, Dan.Sneddon@microchip.com, tomi.valkeinen@ideasonboard.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de> Subject: [PATCH v2 06/14] drm/kmb: Convert to Linux IRQ interfaces Date: Tue, 3 Aug 2021 11:06:56 +0200 [thread overview] Message-ID: <20210803090704.32152-7-tzimmermann@suse.de> (raw) In-Reply-To: <20210803090704.32152-1-tzimmermann@suse.de> Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/kmb/kmb_drv.c | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index f54392ec4fab..1c2f4799f421 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -17,7 +17,6 @@ #include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> -#include <drm/drm_irq.h> #include <drm/drm_probe_helper.h> #include <drm/drm_vblank.h> @@ -413,14 +412,29 @@ static void kmb_irq_reset(struct drm_device *drm) kmb_write_lcd(to_kmb(drm), LCD_INT_ENABLE, 0); } +static int kmb_irq_install(struct drm_device *drm, unsigned int irq) +{ + if (irq == IRQ_NOTCONNECTED) + return -ENOTCONN; + + kmb_irq_reset(drm); + + return request_irq(irq, kmb_isr, 0, drm->driver->name, drm); +} + +static void kmb_irq_uninstall(struct drm_device *drm) +{ + struct kmb_drm_private *kmb = to_kmb(drm); + + kmb_irq_reset(drm); + free_irq(kmb->irq_lcd, drm); +} + DEFINE_DRM_GEM_CMA_FOPS(fops); static const struct drm_driver kmb_driver = { .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, - .irq_handler = kmb_isr, - .irq_preinstall = kmb_irq_reset, - .irq_uninstall = kmb_irq_reset, /* GEM Operations */ .fops = &fops, DRM_GEM_CMA_DRIVER_OPS_VMAP, @@ -442,7 +456,7 @@ static int kmb_remove(struct platform_device *pdev) of_node_put(kmb->crtc.port); kmb->crtc.port = NULL; pm_runtime_get_sync(drm->dev); - drm_irq_uninstall(drm); + kmb_irq_uninstall(drm); pm_runtime_put_sync(drm->dev); pm_runtime_disable(drm->dev); @@ -532,7 +546,7 @@ static int kmb_probe(struct platform_device *pdev) if (ret) goto err_free; - ret = drm_irq_install(&kmb->drm, kmb->irq_lcd); + ret = kmb_irq_install(&kmb->drm, kmb->irq_lcd); if (ret < 0) { drm_err(&kmb->drm, "failed to install IRQ handler\n"); goto err_irq; -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de> To: daniel@ffwll.ch, airlied@linux.ie, alexander.deucher@amd.com, christian.koenig@amd.com, liviu.dudau@arm.com, brian.starkey@arm.com, sam@ravnborg.org, bbrezillon@kernel.org, nicolas.ferre@microchip.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, stefan@agner.ch, alison.wang@nxp.com, patrik.r.jakobsson@gmail.com, anitha.chrisanthus@intel.com, robdclark@gmail.com, edmund.j.dea@intel.com, sean@poorly.run, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, jyri.sarha@iki.fi, tomba@kernel.org, Dan.Sneddon@microchip.com, tomi.valkeinen@ideasonboard.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de> Subject: [PATCH v2 06/14] drm/kmb: Convert to Linux IRQ interfaces Date: Tue, 3 Aug 2021 11:06:56 +0200 [thread overview] Message-ID: <20210803090704.32152-7-tzimmermann@suse.de> (raw) In-Reply-To: <20210803090704.32152-1-tzimmermann@suse.de> Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/kmb/kmb_drv.c | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index f54392ec4fab..1c2f4799f421 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -17,7 +17,6 @@ #include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> -#include <drm/drm_irq.h> #include <drm/drm_probe_helper.h> #include <drm/drm_vblank.h> @@ -413,14 +412,29 @@ static void kmb_irq_reset(struct drm_device *drm) kmb_write_lcd(to_kmb(drm), LCD_INT_ENABLE, 0); } +static int kmb_irq_install(struct drm_device *drm, unsigned int irq) +{ + if (irq == IRQ_NOTCONNECTED) + return -ENOTCONN; + + kmb_irq_reset(drm); + + return request_irq(irq, kmb_isr, 0, drm->driver->name, drm); +} + +static void kmb_irq_uninstall(struct drm_device *drm) +{ + struct kmb_drm_private *kmb = to_kmb(drm); + + kmb_irq_reset(drm); + free_irq(kmb->irq_lcd, drm); +} + DEFINE_DRM_GEM_CMA_FOPS(fops); static const struct drm_driver kmb_driver = { .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, - .irq_handler = kmb_isr, - .irq_preinstall = kmb_irq_reset, - .irq_uninstall = kmb_irq_reset, /* GEM Operations */ .fops = &fops, DRM_GEM_CMA_DRIVER_OPS_VMAP, @@ -442,7 +456,7 @@ static int kmb_remove(struct platform_device *pdev) of_node_put(kmb->crtc.port); kmb->crtc.port = NULL; pm_runtime_get_sync(drm->dev); - drm_irq_uninstall(drm); + kmb_irq_uninstall(drm); pm_runtime_put_sync(drm->dev); pm_runtime_disable(drm->dev); @@ -532,7 +546,7 @@ static int kmb_probe(struct platform_device *pdev) if (ret) goto err_free; - ret = drm_irq_install(&kmb->drm, kmb->irq_lcd); + ret = kmb_irq_install(&kmb->drm, kmb->irq_lcd); if (ret < 0) { drm_err(&kmb->drm, "failed to install IRQ handler\n"); goto err_irq; -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-03 9:07 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-03 9:06 [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann 2021-08-03 9:06 ` [PATCH v2 01/14] drm/amdgpu: Convert to Linux IRQ interfaces Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann 2021-08-03 9:06 ` [PATCH v2 02/14] drm/arm/hdlcd: " Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann 2021-08-20 16:05 ` Liviu Dudau 2021-08-20 16:05 ` Liviu Dudau 2021-08-03 9:06 ` [PATCH v2 03/14] drm/atmel-hlcdc: " Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann 2021-08-03 9:06 ` [PATCH v2 04/14] drm/fsl-dcu: " Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann 2021-08-03 9:06 ` [PATCH v2 05/14] drm/gma500: " Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann [this message] 2021-08-03 9:06 ` [PATCH v2 06/14] drm/kmb: " Thomas Zimmermann 2021-08-03 9:06 ` [PATCH v2 07/14] drm/msm: " Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann 2021-08-03 9:37 ` Dmitry Baryshkov 2021-08-03 9:37 ` Dmitry Baryshkov 2021-08-03 15:04 ` Rob Clark 2021-08-03 15:04 ` Rob Clark 2021-08-07 17:08 ` Rob Clark 2021-08-07 17:08 ` Rob Clark 2021-08-07 18:40 ` Thomas Zimmermann 2021-08-07 18:40 ` Thomas Zimmermann 2021-08-07 18:50 ` Rob Clark 2021-08-07 18:50 ` Rob Clark 2021-08-03 17:20 ` [Freedreno] " abhinavk 2021-08-03 9:06 ` [PATCH v2 08/14] drm/mxsfb: " Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann 2021-08-03 9:06 ` [PATCH v2 09/14] drm/radeon: " Thomas Zimmermann 2021-08-03 9:06 ` Thomas Zimmermann 2021-08-03 9:07 ` [PATCH v2 10/14] drm/tidss: " Thomas Zimmermann 2021-08-03 9:07 ` Thomas Zimmermann 2021-08-03 9:07 ` [PATCH v2 11/14] drm/tilcdc: " Thomas Zimmermann 2021-08-03 9:07 ` Thomas Zimmermann 2021-08-03 15:00 ` Sam Ravnborg 2021-08-03 15:00 ` Sam Ravnborg 2021-08-04 18:30 ` Thomas Zimmermann 2021-08-04 18:30 ` Thomas Zimmermann 2021-08-04 18:33 ` Sam Ravnborg 2021-08-04 18:33 ` Sam Ravnborg 2021-08-03 9:07 ` [PATCH v2 12/14] drm/vc4: " Thomas Zimmermann 2021-08-03 9:07 ` Thomas Zimmermann 2021-08-03 9:07 ` [PATCH v2 13/14] drm: Remove unused devm_drm_irq_install() Thomas Zimmermann 2021-08-03 9:07 ` Thomas Zimmermann 2021-08-03 9:07 ` [PATCH v2 14/14] drm: IRQ midlayer is now legacy Thomas Zimmermann 2021-08-03 9:07 ` Thomas Zimmermann 2021-08-03 15:04 ` [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy Sam Ravnborg 2021-08-03 15:04 ` Sam Ravnborg 2021-08-03 18:36 ` Chrisanthus, Anitha 2021-08-03 18:36 ` Chrisanthus, Anitha 2021-08-03 18:36 ` Chrisanthus, Anitha 2021-08-04 7:10 ` Thomas Zimmermann 2021-08-04 7:10 ` Thomas Zimmermann 2021-08-04 7:10 ` Thomas Zimmermann 2021-08-05 23:59 ` Chrisanthus, Anitha 2021-08-05 23:59 ` Chrisanthus, Anitha 2021-08-05 23:59 ` Chrisanthus, Anitha 2021-08-07 6:51 ` Thomas Zimmermann 2021-08-07 6:51 ` Thomas Zimmermann 2021-08-07 6:51 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210803090704.32152-7-tzimmermann@suse.de \ --to=tzimmermann@suse.de \ --cc=Dan.Sneddon@microchip.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=alison.wang@nxp.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=anitha.chrisanthus@intel.com \ --cc=bbrezillon@kernel.org \ --cc=brian.starkey@arm.com \ --cc=christian.koenig@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=edmund.j.dea@intel.com \ --cc=freedreno@lists.freedesktop.org \ --cc=jyri.sarha@iki.fi \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=liviu.dudau@arm.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=patrik.r.jakobsson@gmail.com \ --cc=robdclark@gmail.com \ --cc=s.hauer@pengutronix.de \ --cc=sam@ravnborg.org \ --cc=sean@poorly.run \ --cc=shawnguo@kernel.org \ --cc=stefan@agner.ch \ --cc=tomba@kernel.org \ --cc=tomi.valkeinen@ideasonboard.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.