From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: jack@suse.com, amir73il@gmail.com
Cc: djwong@kernel.org, tytso@mit.edu, david@fromorbit.com,
dhowells@redhat.com, khazhy@google.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-api@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel@collabora.com
Subject: [PATCH v5 00/23] File system wide monitoring
Date: Wed, 4 Aug 2021 12:05:49 -0400 [thread overview]
Message-ID: <20210804160612.3575505-1-krisman@collabora.com> (raw)
Hi,
This is the 5th version of the FAN_FS_ERROR patches. This applies
the feedback from last version (thanks Amir, Jan). Biggest changes are
the split up of the FAN_FS_ERROR patch into something more reviewable,
and the removal of the event_info structure due to the perf regression
shown by unixbench.
This was tested with LTP for regressions, and also using the sample on
the last patch, with a corrupted image. I wrote a new ltp test for this
feature which is being reviewed and is available at:
https://gitlab.collabora.com/krisman/ltp -b fan-fs-error
In addition, I wrote a man-page that can be pulled from:
https://gitlab.collabora.com/krisman/man-pages.git -b fan-fs-error
And is being reviewed at the list.
I also pushed this full series to:
https://gitlab.collabora.com/krisman/linux -b fanotify-notifications-single-slot
Thank you
Original cover letter
---------------------
Hi,
This series follow up on my previous proposal [1] to support file system
wide monitoring. As suggested by Amir, this proposal drops the ring
buffer in favor of a single slot associated with each mark. This
simplifies a bit the implementation, as you can see in the code.
As a reminder, This proposal is limited to an interface for
administrators to monitor the health of a file system, instead of a
generic inteface for file errors. Therefore, this doesn't solve the
problem of writeback errors or the need to watch a specific subtree.
In comparison to the previous RFC, this implementation also drops the
per-fs data and location, and leave those as future extensions.
* Implementation
The feature is implemented on top of fanotify, as a new type of fanotify
mark, FAN_ERROR, which a file system monitoring tool can register to
receive error notifications. When an error occurs a new notification is
generated, in addition followed by this info field:
- FS generic data: A file system agnostic structure that has a generic
error code and identifies the filesystem. Basically, it let's
userspace know something happened on a monitored filesystem. Since
only the first error is recorded since the last read, this also
includes a counter of errors that happened since the last read.
* Testing
This was tested by watching notifications flowing from an intentionally
corrupted filesystem in different places. In addition, other events
were watched in an attempt to detect regressions.
Is there a specific testsuite for fanotify I should be running?
* Patches
This patchset is divided as follows: Patch 1 through 5 are refactoring
to fsnotify/fanotify in preparation for FS_ERROR/FAN_ERROR; patch 6 and
7 implement the FS_ERROR API for filesystems to report error; patch 8
add support for FAN_ERROR in fanotify; Patch 9 is an example
implementation for ext4; patch 10 and 11 provide a sample userspace code
and documentation.
I also pushed the full series to:
https://gitlab.collabora.com/krisman/linux -b fanotify-notifications-single-slot
[1] https://lwn.net/Articles/854545/
[2] https://lwn.net/Articles/856916/
Cc: Darrick J. Wong <djwong@kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Dave Chinner <david@fromorbit.com>
Cc: jack@suse.com
To: amir73il@gmail.com
Cc: dhowells@redhat.com
Cc: khazhy@google.com
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-ext4@vger.kernel.org
Cc: linux-api@vger.kernel.org
Cc: linux-api@vger.kernel.org
Gabriel Krisman Bertazi (23):
fsnotify: Don't insert unmergeable events in hashtable
fanotify: Fold event size calculation to its own function
fanotify: Split fsid check from other fid mode checks
fsnotify: Reserve mark bits for backends
fanotify: Split superblock marks out to a new cache
inotify: Don't force FS_IN_IGNORED
fsnotify: Add helper to detect overflow_event
fsnotify: Add wrapper around fsnotify_add_event
fsnotify: Support passing argument to insert callback on add_event
fsnotify: Allow events reported with an empty inode
fsnotify: Support FS_ERROR event type
fanotify: Expose helper to estimate file handle encoding length
fanotify: Allow file handle encoding for unhashed events
fanotify: Encode invalid file handler when no inode is provided
fanotify: Require fid_mode for any non-fd event
fanotify: Reserve UAPI bits for FAN_FS_ERROR
fanotify: Preallocate per superblock mark error event
fanotify: Handle FAN_FS_ERROR events
fanotify: Report fid info for file related file system errors
fanotify: Emit generic error info type for error event
ext4: Send notifications on error
samples: Add fs error monitoring example
docs: Document the FAN_FS_ERROR event
.../admin-guide/filesystem-monitoring.rst | 70 +++++
Documentation/admin-guide/index.rst | 1 +
fs/ext4/super.c | 8 +
fs/kernfs/file.c | 6 +-
fs/notify/fanotify/fanotify.c | 186 +++++++++---
fs/notify/fanotify/fanotify.h | 80 +++++-
fs/notify/fanotify/fanotify_user.c | 266 +++++++++++++++---
fs/notify/fsnotify.c | 14 +-
fs/notify/inotify/inotify_fsnotify.c | 2 +-
fs/notify/inotify/inotify_user.c | 6 +-
fs/notify/notification.c | 16 +-
include/linux/fanotify.h | 9 +-
include/linux/fsnotify.h | 20 +-
include/linux/fsnotify_backend.h | 76 ++++-
include/uapi/linux/fanotify.h | 8 +
samples/Kconfig | 9 +
samples/Makefile | 1 +
samples/fanotify/Makefile | 5 +
samples/fanotify/fs-monitor.c | 138 +++++++++
19 files changed, 803 insertions(+), 118 deletions(-)
create mode 100644 Documentation/admin-guide/filesystem-monitoring.rst
create mode 100644 samples/fanotify/Makefile
create mode 100644 samples/fanotify/fs-monitor.c
--
2.32.0
next reply other threads:[~2021-08-04 16:06 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 16:05 Gabriel Krisman Bertazi [this message]
2021-08-04 16:05 ` [PATCH v5 01/23] fsnotify: Don't insert unmergeable events in hashtable Gabriel Krisman Bertazi
2021-08-04 16:05 ` [PATCH v5 02/23] fanotify: Fold event size calculation to its own function Gabriel Krisman Bertazi
2021-08-04 16:05 ` [PATCH v5 03/23] fanotify: Split fsid check from other fid mode checks Gabriel Krisman Bertazi
2021-08-04 16:05 ` [PATCH v5 04/23] fsnotify: Reserve mark bits for backends Gabriel Krisman Bertazi
2021-08-05 8:44 ` kernel test robot
2021-08-05 8:44 ` kernel test robot
2021-08-05 9:14 ` Jan Kara
2021-08-04 16:05 ` [PATCH v5 05/23] fanotify: Split superblock marks out to a new cache Gabriel Krisman Bertazi
2021-08-05 9:24 ` Jan Kara
2021-08-04 16:05 ` [PATCH v5 06/23] inotify: Don't force FS_IN_IGNORED Gabriel Krisman Bertazi
2021-08-04 16:05 ` [PATCH v5 07/23] fsnotify: Add helper to detect overflow_event Gabriel Krisman Bertazi
2021-08-04 16:05 ` [PATCH v5 08/23] fsnotify: Add wrapper around fsnotify_add_event Gabriel Krisman Bertazi
2021-08-05 9:28 ` Jan Kara
2021-08-04 16:05 ` [PATCH v5 09/23] fsnotify: Support passing argument to insert callback on add_event Gabriel Krisman Bertazi
2021-08-04 16:05 ` [PATCH v5 10/23] fsnotify: Allow events reported with an empty inode Gabriel Krisman Bertazi
2021-08-05 10:24 ` Jan Kara
2021-08-05 14:14 ` Amir Goldstein
2021-08-05 15:55 ` Jan Kara
2021-08-04 16:06 ` [PATCH v5 11/23] fsnotify: Support FS_ERROR event type Gabriel Krisman Bertazi
2021-08-04 16:06 ` [PATCH v5 12/23] fanotify: Expose helper to estimate file handle encoding length Gabriel Krisman Bertazi
2021-08-04 16:06 ` [PATCH v5 13/23] fanotify: Allow file handle encoding for unhashed events Gabriel Krisman Bertazi
2021-08-05 9:39 ` Jan Kara
2021-08-04 16:06 ` [PATCH v5 14/23] fanotify: Encode invalid file handler when no inode is provided Gabriel Krisman Bertazi
2021-08-05 9:56 ` Jan Kara
2021-08-11 21:12 ` Gabriel Krisman Bertazi
2021-08-12 14:20 ` Jan Kara
2021-08-12 15:14 ` Gabriel Krisman Bertazi
2021-08-12 15:50 ` Amir Goldstein
2021-08-12 15:17 ` Amir Goldstein
2021-08-13 12:09 ` Jan Kara
2021-08-13 17:25 ` Amir Goldstein
2021-08-04 16:06 ` [PATCH v5 15/23] fanotify: Require fid_mode for any non-fd event Gabriel Krisman Bertazi
2021-08-05 10:29 ` Jan Kara
2021-08-04 16:06 ` [PATCH v5 16/23] fanotify: Reserve UAPI bits for FAN_FS_ERROR Gabriel Krisman Bertazi
2021-08-05 10:33 ` Jan Kara
2021-08-04 16:06 ` [PATCH v5 17/23] fanotify: Preallocate per superblock mark error event Gabriel Krisman Bertazi
2021-08-04 16:06 ` [PATCH v5 18/23] fanotify: Handle FAN_FS_ERROR events Gabriel Krisman Bertazi
2021-08-05 12:15 ` Jan Kara
2021-08-05 13:50 ` Amir Goldstein
2021-08-10 1:35 ` Gabriel Krisman Bertazi
2021-08-04 16:06 ` [PATCH v5 19/23] fanotify: Report fid info for file related file system errors Gabriel Krisman Bertazi
2021-08-05 11:28 ` Jan Kara
2021-08-05 12:06 ` Jan Kara
2021-08-04 16:06 ` [PATCH v5 20/23] fanotify: Emit generic error info type for error event Gabriel Krisman Bertazi
2021-08-04 16:06 ` [PATCH v5 21/23] ext4: Send notifications on error Gabriel Krisman Bertazi
2021-08-04 16:06 ` [PATCH v5 22/23] samples: Add fs error monitoring example Gabriel Krisman Bertazi
2021-08-04 16:06 ` [PATCH v5 23/23] docs: Document the FAN_FS_ERROR event Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804160612.3575505-1-krisman@collabora.com \
--to=krisman@collabora.com \
--cc=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=jack@suse.com \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.