From: Jianqun Xu <jay.xu@rock-chips.com> To: linus.walleij@linaro.org, heiko@sntech.de Cc: bgolaszewski@baylibre.com, robh+dt@kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com> Subject: [PATCH v8 8/9] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Date: Mon, 16 Aug 2021 09:21:35 +0800 [thread overview] Message-ID: <20210816012135.1119234-1-jay.xu@rock-chips.com> (raw) In-Reply-To: <20210816011948.1118959-1-jay.xu@rock-chips.com> There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Reviewed-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- v8: - none v7: - none v6: - add reviewed by heiko drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index b2be56040289..036b2d959503 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) irq_set_handler_locked(d, handle_level_irq); raw_spin_lock_irqsave(&bank->slock, flags); - irq_gc_lock(gc); level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type); polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity); @@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type); rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity); out: - irq_gc_unlock(gc); raw_spin_unlock_irqrestore(&bank->slock, flags); return ret; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jianqun Xu <jay.xu@rock-chips.com> To: linus.walleij@linaro.org, heiko@sntech.de Cc: bgolaszewski@baylibre.com, robh+dt@kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com> Subject: [PATCH v8 8/9] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Date: Mon, 16 Aug 2021 09:21:35 +0800 [thread overview] Message-ID: <20210816012135.1119234-1-jay.xu@rock-chips.com> (raw) In-Reply-To: <20210816011948.1118959-1-jay.xu@rock-chips.com> There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Reviewed-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- v8: - none v7: - none v6: - add reviewed by heiko drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index b2be56040289..036b2d959503 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) irq_set_handler_locked(d, handle_level_irq); raw_spin_lock_irqsave(&bank->slock, flags); - irq_gc_lock(gc); level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type); polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity); @@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type); rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity); out: - irq_gc_unlock(gc); raw_spin_unlock_irqrestore(&bank->slock, flags); return ret; -- 2.25.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-08-16 1:21 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-16 1:19 [PATCH v8 0/9] gpio-rockchip driver Jianqun Xu 2021-08-16 1:19 ` Jianqun Xu 2021-08-16 1:19 ` [PATCH v8 1/9] pinctrl/rockchip: always enable clock for gpio controller Jianqun Xu 2021-08-16 1:19 ` Jianqun Xu 2021-08-18 19:57 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianqun Xu 2021-08-16 1:19 ` [PATCH v8 2/9] pinctrl/rockchip: separate struct rockchip_pin_bank to a head file Jianqun Xu 2021-08-16 1:19 ` Jianqun Xu 2021-08-18 19:57 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianqun Xu 2021-08-16 1:19 ` [PATCH v8 3/9] pinctrl/rockchip: add pinctrl device to gpio bank struct Jianqun Xu 2021-08-16 1:19 ` Jianqun Xu 2021-08-18 19:57 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianqun Xu 2021-08-16 1:19 ` [PATCH v8 4/9] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank Jianqun Xu 2021-08-16 1:19 ` [PATCH v8 4/9] dt-bindings: gpio: change items restriction of clock for rockchip, gpio-bank Jianqun Xu 2021-08-18 19:57 ` [irqchip: irq/irqchip-next] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank irqchip-bot for Jianqun Xu 2021-08-16 1:20 ` [PATCH v8 5/9] gpio/rockchip: add driver for rockchip gpio Jianqun Xu 2021-08-16 1:20 ` Jianqun Xu 2021-08-18 19:57 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianqun Xu 2021-08-16 1:21 ` [PATCH v8 6/9] gpio/rockchip: use struct rockchip_gpio_regs for gpio controller Jianqun Xu 2021-08-16 1:21 ` Jianqun Xu 2021-08-18 19:57 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianqun Xu 2021-08-16 1:21 ` [PATCH v8 7/9] gpio/rockchip: support next version " Jianqun Xu 2021-08-16 1:21 ` Jianqun Xu 2021-08-18 19:56 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianqun Xu 2021-08-16 1:21 ` Jianqun Xu [this message] 2021-08-16 1:21 ` [PATCH v8 8/9] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Jianqun Xu 2021-08-18 19:56 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianqun Xu 2021-08-16 1:21 ` [PATCH v8 9/9] pinctrl/rockchip: drop the gpio related codes Jianqun Xu 2021-08-16 1:21 ` Jianqun Xu 2021-08-18 19:56 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianqun Xu 2021-09-27 10:18 ` [PATCH v8 9/9] " Guillaume Tucker 2021-09-27 10:18 ` Guillaume Tucker 2021-09-27 10:18 ` Guillaume Tucker 2021-09-27 21:04 ` Heiko Stuebner 2021-09-27 21:04 ` Heiko Stuebner 2021-09-27 21:04 ` Heiko Stuebner 2021-08-16 19:13 ` [PATCH v8 0/9] gpio-rockchip driver Bartosz Golaszewski 2021-08-16 19:13 ` Bartosz Golaszewski 2021-08-16 23:05 ` Linus Walleij 2021-08-16 23:05 ` Linus Walleij 2021-08-16 23:04 ` Linus Walleij 2021-08-16 23:04 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210816012135.1119234-1-jay.xu@rock-chips.com \ --to=jay.xu@rock-chips.com \ --cc=bgolaszewski@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.