From: Jianqun Xu <jay.xu@rock-chips.com> To: lgirdwood@gmail.com, broonie@kernel.org, ulf.hansson@linaro.org, lee.jones@linaro.org, zhangchangzhong@huawei.com, heiko@sntech.de Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com> Subject: [PATCH 2/4] regulator: core: notify regulator enable with the voltage value Date: Mon, 16 Aug 2021 11:20:01 +0800 [thread overview] Message-ID: <20210816032003.1162779-3-jay.xu@rock-chips.com> (raw) In-Reply-To: <20210816032003.1162779-1-jay.xu@rock-chips.com> Get the voltage of regulator and then pass it as the parameter of notify, the driver could take it. The origin parameter for notify is NULL, so this patch do nothing effect to other driver who not care about the voltage value. Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- drivers/regulator/core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index f192bf19492e..a53f1644a6f4 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2658,8 +2658,12 @@ static int _regulator_enable(struct regulator *regulator) if (ret < 0) goto err_consumer_disable; + ret = _regulator_get_voltage(rdev); + if (ret < 0) + ret = 0; + _notifier_call_chain(rdev, REGULATOR_EVENT_ENABLE, - NULL); + &ret); } else if (ret < 0) { rdev_err(rdev, "is_enabled() failed: %pe\n", ERR_PTR(ret)); goto err_consumer_disable; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jianqun Xu <jay.xu@rock-chips.com> To: lgirdwood@gmail.com, broonie@kernel.org, ulf.hansson@linaro.org, lee.jones@linaro.org, zhangchangzhong@huawei.com, heiko@sntech.de Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com> Subject: [PATCH 2/4] regulator: core: notify regulator enable with the voltage value Date: Mon, 16 Aug 2021 11:20:01 +0800 [thread overview] Message-ID: <20210816032003.1162779-3-jay.xu@rock-chips.com> (raw) In-Reply-To: <20210816032003.1162779-1-jay.xu@rock-chips.com> Get the voltage of regulator and then pass it as the parameter of notify, the driver could take it. The origin parameter for notify is NULL, so this patch do nothing effect to other driver who not care about the voltage value. Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- drivers/regulator/core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index f192bf19492e..a53f1644a6f4 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2658,8 +2658,12 @@ static int _regulator_enable(struct regulator *regulator) if (ret < 0) goto err_consumer_disable; + ret = _regulator_get_voltage(rdev); + if (ret < 0) + ret = 0; + _notifier_call_chain(rdev, REGULATOR_EVENT_ENABLE, - NULL); + &ret); } else if (ret < 0) { rdev_err(rdev, "is_enabled() failed: %pe\n", ERR_PTR(ret)); goto err_consumer_disable; -- 2.25.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-08-16 3:20 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-16 3:19 [PATCH 0/4] regulator pre-enable Jianqun Xu 2021-08-16 3:19 ` Jianqun Xu 2021-08-16 3:20 ` [PATCH 1/4] regulator: add PRE_ENABLE event define Jianqun Xu 2021-08-16 3:20 ` Jianqun Xu 2021-08-16 3:20 ` Jianqun Xu [this message] 2021-08-16 3:20 ` [PATCH 2/4] regulator: core: notify regulator enable with the voltage value Jianqun Xu 2021-08-16 12:00 ` Mark Brown 2021-08-16 12:00 ` Mark Brown 2021-08-17 3:17 ` jay.xu 2021-08-17 3:23 ` jay.xu 2021-08-16 3:20 ` [PATCH 3/4] regulator: core: add pre-enable event notify to regulator Jianqun Xu 2021-08-16 3:20 ` Jianqun Xu 2021-08-16 3:20 ` [PATCH 4/4] soc: rockchip: io-domain: do more thing about regulator notify Jianqun Xu 2021-08-16 3:20 ` Jianqun Xu 2021-08-16 12:39 ` Ulf Hansson 2021-08-16 12:39 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210816032003.1162779-3-jay.xu@rock-chips.com \ --to=jay.xu@rock-chips.com \ --cc=broonie@kernel.org \ --cc=heiko@sntech.de \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=ulf.hansson@linaro.org \ --cc=zhangchangzhong@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.