From: Andrew Jones <drjones@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: "Daniel P . Berrange" <berrange@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Yanan Wang <wangyanan55@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation
Date: Tue, 17 Aug 2021 14:53:56 +0200 [thread overview]
Message-ID: <20210817125356.9461-1-drjones@redhat.com> (raw)
Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
introduced documentation stating that a zero input value for an SMP
parameter indicates that its value should be automatically configured.
This is indeed how things work today, but we'd like to change that.
Avoid documenting behaviors we want to leave undefined for the time
being, giving us freedom to change it later.
Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
qapi/machine.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index c3210ee1fb24..157712f00614 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -1288,7 +1288,7 @@
##
# @SMPConfiguration:
#
-# Schema for CPU topology configuration. "0" or a missing value lets
+# Schema for CPU topology configuration. A missing value lets
# QEMU figure out a suitable value based on the ones that are provided.
#
# @cpus: number of virtual CPUs in the virtual machine
--
2.31.1
next reply other threads:[~2021-08-17 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 12:53 Andrew Jones [this message]
2021-08-17 13:18 ` [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation wangyanan (Y)
2021-08-17 13:21 ` Paolo Bonzini
2021-08-17 13:27 ` Cornelia Huck
2021-08-17 13:50 ` Philippe Mathieu-Daudé
2021-08-17 15:48 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817125356.9461-1-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.