From: Alexandre Bailon <abailon@baylibre.com>
To: ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, robh+dt@kernel.org
Cc: matthias.bgg@gmail.com, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
stephane.leprovost@mediatek.com, gpain@baylibre.com,
khilman@baylibre.com, Alexandre Bailon <abailon@baylibre.com>
Subject: [PATCH v3 0/4] Add support of mt8183 APU
Date: Thu, 19 Aug 2021 17:13:36 +0200 [thread overview]
Message-ID: <20210819151340.741565-1-abailon@baylibre.com> (raw)
Some Mediatek's SoC have an Accelerated Processing Unit.
This adds support of the one available in the mt8183
(aswell some derivative SoC).
This v3 attempt to handle memory differently.
In the v2, the memory was reserved in dts and all dma allocation made by
remoteproc was using it. Since we may load many firmwares with different size,
this could lead to a memory waste or out of memory issues.
In addition, the APU itself expect the memory to mapped at a specific address.
The firmware, because of many hardware / software limitations use hardcoded
address.
To simplify memory management of userspace application, kernel and firmware,
and to rmeove a couple of hacks, we changed the way to manage the memory.
With the v3, only the virtio memory (that won't never change) is reserved
in the dts. The firmware declare resource similar to the CARVOUT_RSC
that used by this driver to allocate and map the memory using the IOMMU.
I am not sure that the best solution but the simplest one I found so far.
Changes in v3:
- Remove IOMMU hack. Instead, manage the IOMMU directly from the driver
- Update the device tree bindings: only use reserved memory for virtio.
All the other memory allocation will be done using DMA API.
This sould simplify the memory management.
- Add more comments
Changes in v2:
- Drop the workarounds needed to load bad firmwares
- There are many name for the APU (most common one is VPU).
Rename many functions and dts nodes to be more consistent.
- Use the bulk clock API, and enable / disable clock at a better place
- add few comments explaining how to start the APU
- update the way to use pinctl for JTAG
- fix some minors issues
- fix device tree bindings
Alexandre Bailon (4):
dt bindings: remoteproc: Add bindings for MT8183 APU
remoteproc: Add a remoteproc driver for the MT8183's APU
remoteproc: mtk_vpu_rproc: Add support of JTAG
ARM64: mt8183: Add support of APU to mt8183
.../bindings/remoteproc/mtk,apu.yaml | 118 ++++
.../boot/dts/mediatek/mt8183-pumpkin.dts | 48 ++
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 40 ++
drivers/remoteproc/Kconfig | 19 +
drivers/remoteproc/Makefile | 1 +
drivers/remoteproc/mtk_apu.c | 590 ++++++++++++++++++
6 files changed, 816 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
create mode 100644 drivers/remoteproc/mtk_apu.c
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Bailon <abailon@baylibre.com>
To: ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, robh+dt@kernel.org
Cc: matthias.bgg@gmail.com, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
stephane.leprovost@mediatek.com, gpain@baylibre.com,
khilman@baylibre.com, Alexandre Bailon <abailon@baylibre.com>
Subject: [PATCH v3 0/4] Add support of mt8183 APU
Date: Thu, 19 Aug 2021 17:13:36 +0200 [thread overview]
Message-ID: <20210819151340.741565-1-abailon@baylibre.com> (raw)
Some Mediatek's SoC have an Accelerated Processing Unit.
This adds support of the one available in the mt8183
(aswell some derivative SoC).
This v3 attempt to handle memory differently.
In the v2, the memory was reserved in dts and all dma allocation made by
remoteproc was using it. Since we may load many firmwares with different size,
this could lead to a memory waste or out of memory issues.
In addition, the APU itself expect the memory to mapped at a specific address.
The firmware, because of many hardware / software limitations use hardcoded
address.
To simplify memory management of userspace application, kernel and firmware,
and to rmeove a couple of hacks, we changed the way to manage the memory.
With the v3, only the virtio memory (that won't never change) is reserved
in the dts. The firmware declare resource similar to the CARVOUT_RSC
that used by this driver to allocate and map the memory using the IOMMU.
I am not sure that the best solution but the simplest one I found so far.
Changes in v3:
- Remove IOMMU hack. Instead, manage the IOMMU directly from the driver
- Update the device tree bindings: only use reserved memory for virtio.
All the other memory allocation will be done using DMA API.
This sould simplify the memory management.
- Add more comments
Changes in v2:
- Drop the workarounds needed to load bad firmwares
- There are many name for the APU (most common one is VPU).
Rename many functions and dts nodes to be more consistent.
- Use the bulk clock API, and enable / disable clock at a better place
- add few comments explaining how to start the APU
- update the way to use pinctl for JTAG
- fix some minors issues
- fix device tree bindings
Alexandre Bailon (4):
dt bindings: remoteproc: Add bindings for MT8183 APU
remoteproc: Add a remoteproc driver for the MT8183's APU
remoteproc: mtk_vpu_rproc: Add support of JTAG
ARM64: mt8183: Add support of APU to mt8183
.../bindings/remoteproc/mtk,apu.yaml | 118 ++++
.../boot/dts/mediatek/mt8183-pumpkin.dts | 48 ++
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 40 ++
drivers/remoteproc/Kconfig | 19 +
drivers/remoteproc/Makefile | 1 +
drivers/remoteproc/mtk_apu.c | 590 ++++++++++++++++++
6 files changed, 816 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
create mode 100644 drivers/remoteproc/mtk_apu.c
--
2.31.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Bailon <abailon@baylibre.com>
To: ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, robh+dt@kernel.org
Cc: matthias.bgg@gmail.com, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
stephane.leprovost@mediatek.com, gpain@baylibre.com,
khilman@baylibre.com, Alexandre Bailon <abailon@baylibre.com>
Subject: [PATCH v3 0/4] Add support of mt8183 APU
Date: Thu, 19 Aug 2021 17:13:36 +0200 [thread overview]
Message-ID: <20210819151340.741565-1-abailon@baylibre.com> (raw)
Some Mediatek's SoC have an Accelerated Processing Unit.
This adds support of the one available in the mt8183
(aswell some derivative SoC).
This v3 attempt to handle memory differently.
In the v2, the memory was reserved in dts and all dma allocation made by
remoteproc was using it. Since we may load many firmwares with different size,
this could lead to a memory waste or out of memory issues.
In addition, the APU itself expect the memory to mapped at a specific address.
The firmware, because of many hardware / software limitations use hardcoded
address.
To simplify memory management of userspace application, kernel and firmware,
and to rmeove a couple of hacks, we changed the way to manage the memory.
With the v3, only the virtio memory (that won't never change) is reserved
in the dts. The firmware declare resource similar to the CARVOUT_RSC
that used by this driver to allocate and map the memory using the IOMMU.
I am not sure that the best solution but the simplest one I found so far.
Changes in v3:
- Remove IOMMU hack. Instead, manage the IOMMU directly from the driver
- Update the device tree bindings: only use reserved memory for virtio.
All the other memory allocation will be done using DMA API.
This sould simplify the memory management.
- Add more comments
Changes in v2:
- Drop the workarounds needed to load bad firmwares
- There are many name for the APU (most common one is VPU).
Rename many functions and dts nodes to be more consistent.
- Use the bulk clock API, and enable / disable clock at a better place
- add few comments explaining how to start the APU
- update the way to use pinctl for JTAG
- fix some minors issues
- fix device tree bindings
Alexandre Bailon (4):
dt bindings: remoteproc: Add bindings for MT8183 APU
remoteproc: Add a remoteproc driver for the MT8183's APU
remoteproc: mtk_vpu_rproc: Add support of JTAG
ARM64: mt8183: Add support of APU to mt8183
.../bindings/remoteproc/mtk,apu.yaml | 118 ++++
.../boot/dts/mediatek/mt8183-pumpkin.dts | 48 ++
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 40 ++
drivers/remoteproc/Kconfig | 19 +
drivers/remoteproc/Makefile | 1 +
drivers/remoteproc/mtk_apu.c | 590 ++++++++++++++++++
6 files changed, 816 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
create mode 100644 drivers/remoteproc/mtk_apu.c
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-08-19 15:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 15:13 Alexandre Bailon [this message]
2021-08-19 15:13 ` [PATCH v3 0/4] Add support of mt8183 APU Alexandre Bailon
2021-08-19 15:13 ` Alexandre Bailon
2021-08-19 15:13 ` [PATCH v3 1/4] dt bindings: remoteproc: Add bindings for MT8183 APU Alexandre Bailon
2021-08-19 15:13 ` Alexandre Bailon
2021-08-19 15:13 ` Alexandre Bailon
2021-08-19 21:19 ` Rob Herring
2021-08-19 21:19 ` Rob Herring
2021-08-19 21:19 ` Rob Herring
2021-08-19 15:13 ` [PATCH v3 2/4] remoteproc: Add a remoteproc driver for the MT8183's APU Alexandre Bailon
2021-08-19 15:13 ` Alexandre Bailon
2021-08-19 15:13 ` Alexandre Bailon
2021-08-19 23:14 ` kernel test robot
2021-08-19 23:14 ` kernel test robot
2021-08-19 23:14 ` kernel test robot
2021-08-30 18:19 ` Mathieu Poirier
2021-08-30 18:19 ` Mathieu Poirier
2021-08-30 18:19 ` Mathieu Poirier
2021-09-08 8:21 ` Alexandre Bailon
2021-09-08 8:21 ` Alexandre Bailon
2021-09-08 8:21 ` Alexandre Bailon
2021-08-19 15:13 ` [PATCH v3 3/4] remoteproc: mtk_vpu_rproc: Add support of JTAG Alexandre Bailon
2021-08-19 15:13 ` Alexandre Bailon
2021-08-19 15:13 ` Alexandre Bailon
2021-08-19 15:13 ` [PATCH v3 4/4] ARM64: mt8183: Add support of APU to mt8183 Alexandre Bailon
2021-08-19 15:13 ` Alexandre Bailon
2021-08-19 15:13 ` Alexandre Bailon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819151340.741565-1-abailon@baylibre.com \
--to=abailon@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gpain@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=stephane.leprovost@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.