From: Oliver Upton <oupton@google.com> To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu Cc: Marc Zyngier <maz@kernel.org>, Peter Shier <pshier@google.com>, Ricardo Koller <ricarkol@google.com>, Jing Zhang <jingzhangos@google.com>, Raghavendra Rao Anata <rananta@google.com>, James Morse <james.morse@arm.com>, Alexandru Elisei <alexandru.elisei@arm.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Andrew Jones <drjones@redhat.com>, Oliver Upton <oupton@google.com> Subject: [PATCH 0/6] KVM: arm64: Implement PSCI SYSTEM_SUSPEND support Date: Thu, 19 Aug 2021 22:36:34 +0000 [thread overview] Message-ID: <20210819223640.3564975-1-oupton@google.com> (raw) Certain VMMs/operators may wish to give their guests the ability to initiate a system suspend that could result in the VM being saved to persistent storage to be resumed at a later time. The PSCI v1.0 specification describes an SMC, SYSTEM_SUSPEND, that allows a kernel to request a system suspend. This call is optional for v1.0, and KVM elected to not support the call in its v1.0 implementation. This series adds support for the SYSTEM_SUSPEND PSCI call to KVM/arm64. Since this is a system-scoped event, KVM cannot quiesce the VM on its own. We add a new system exit type in this series to clue in userspace that a suspend was requested. Per the KVM_EXIT_SYSTEM_EVENT ABI, a VMM that doesn't care about this event can simply resume the guest without issue (we set up the calling vCPU to come out of reset correctly on next KVM_RUN). Patch 1 is unrelated, and is a fix for "KVM: arm64: Enforce reserved bits for PSCI target affinities" on the kvmarm/next branch. Nothing particularly hairy, just an unused param. Patch 2 simplifies the function to check if KVM allows a particular PSCI function. We can generally disallow any PSCI function that sets the SMC64 bit in the PSCI function ID. Patch 3 wraps up the PSCI reset logic used for CPU_ON, which will be needed later to queue up a reset on the vCPU that requested the system suspend. Patch 4 brings in the new UAPI and PSCI call, guarded behind a VM capability for backwards compatibility. Patch 5 is indirectly related to this series, and avoids compiler reordering on PSCI calls in the selftest introduced by "selftests: KVM: Introduce psci_cpu_on_test". Finally, patch 6 extends the PSCI selftest to verify the SYSTEM_SUSPEND PSCI call behaves as intended. These patches apply cleanly to kvmarm/next at the following commit: f2267b87ecd5 ("Merge branch kvm-arm64/misc-5.15 into kvmarm-master/next") The series is intentionally based on kvmarm/next for the sake of fixing patches only present there in [1/6] and [5/6]. Tested on QEMU (ick) since my Mt. Jade box is out to lunch at the moment and for some unknown reason the toolchain on my work computer doesn't play nice with the FVP. Oliver Upton (6): KVM: arm64: Drop unused vcpu param to kvm_psci_valid_affinity() KVM: arm64: Clean up SMC64 PSCI filtering for AArch32 guests KVM: arm64: Encapsulate reset request logic in a helper function KVM: arm64: Add support for SYSTEM_SUSPEND PSCI call selftests: KVM: Promote PSCI hypercalls to asm volatile selftests: KVM: Test SYSTEM_SUSPEND PSCI call arch/arm64/include/asm/kvm_host.h | 3 + arch/arm64/kvm/arm.c | 5 + arch/arm64/kvm/psci.c | 134 +++++++++++++----- include/uapi/linux/kvm.h | 2 + .../selftests/kvm/aarch64/psci_cpu_on_test.c | 126 +++++++++++----- 5 files changed, 202 insertions(+), 68 deletions(-) -- 2.33.0.rc2.250.ged5fa647cd-goog
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oupton@google.com> To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu Cc: Marc Zyngier <maz@kernel.org>, Peter Shier <pshier@google.com>, Raghavendra Rao Anata <rananta@google.com> Subject: [PATCH 0/6] KVM: arm64: Implement PSCI SYSTEM_SUSPEND support Date: Thu, 19 Aug 2021 22:36:34 +0000 [thread overview] Message-ID: <20210819223640.3564975-1-oupton@google.com> (raw) Certain VMMs/operators may wish to give their guests the ability to initiate a system suspend that could result in the VM being saved to persistent storage to be resumed at a later time. The PSCI v1.0 specification describes an SMC, SYSTEM_SUSPEND, that allows a kernel to request a system suspend. This call is optional for v1.0, and KVM elected to not support the call in its v1.0 implementation. This series adds support for the SYSTEM_SUSPEND PSCI call to KVM/arm64. Since this is a system-scoped event, KVM cannot quiesce the VM on its own. We add a new system exit type in this series to clue in userspace that a suspend was requested. Per the KVM_EXIT_SYSTEM_EVENT ABI, a VMM that doesn't care about this event can simply resume the guest without issue (we set up the calling vCPU to come out of reset correctly on next KVM_RUN). Patch 1 is unrelated, and is a fix for "KVM: arm64: Enforce reserved bits for PSCI target affinities" on the kvmarm/next branch. Nothing particularly hairy, just an unused param. Patch 2 simplifies the function to check if KVM allows a particular PSCI function. We can generally disallow any PSCI function that sets the SMC64 bit in the PSCI function ID. Patch 3 wraps up the PSCI reset logic used for CPU_ON, which will be needed later to queue up a reset on the vCPU that requested the system suspend. Patch 4 brings in the new UAPI and PSCI call, guarded behind a VM capability for backwards compatibility. Patch 5 is indirectly related to this series, and avoids compiler reordering on PSCI calls in the selftest introduced by "selftests: KVM: Introduce psci_cpu_on_test". Finally, patch 6 extends the PSCI selftest to verify the SYSTEM_SUSPEND PSCI call behaves as intended. These patches apply cleanly to kvmarm/next at the following commit: f2267b87ecd5 ("Merge branch kvm-arm64/misc-5.15 into kvmarm-master/next") The series is intentionally based on kvmarm/next for the sake of fixing patches only present there in [1/6] and [5/6]. Tested on QEMU (ick) since my Mt. Jade box is out to lunch at the moment and for some unknown reason the toolchain on my work computer doesn't play nice with the FVP. Oliver Upton (6): KVM: arm64: Drop unused vcpu param to kvm_psci_valid_affinity() KVM: arm64: Clean up SMC64 PSCI filtering for AArch32 guests KVM: arm64: Encapsulate reset request logic in a helper function KVM: arm64: Add support for SYSTEM_SUSPEND PSCI call selftests: KVM: Promote PSCI hypercalls to asm volatile selftests: KVM: Test SYSTEM_SUSPEND PSCI call arch/arm64/include/asm/kvm_host.h | 3 + arch/arm64/kvm/arm.c | 5 + arch/arm64/kvm/psci.c | 134 +++++++++++++----- include/uapi/linux/kvm.h | 2 + .../selftests/kvm/aarch64/psci_cpu_on_test.c | 126 +++++++++++----- 5 files changed, 202 insertions(+), 68 deletions(-) -- 2.33.0.rc2.250.ged5fa647cd-goog _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next reply other threads:[~2021-08-19 22:36 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-19 22:36 Oliver Upton [this message] 2021-08-19 22:36 ` [PATCH 0/6] KVM: arm64: Implement PSCI SYSTEM_SUSPEND support Oliver Upton 2021-08-19 22:36 ` [PATCH 1/6] KVM: arm64: Drop unused vcpu param to kvm_psci_valid_affinity() Oliver Upton 2021-08-19 22:36 ` Oliver Upton 2021-08-19 22:36 ` [PATCH 2/6] KVM: arm64: Clean up SMC64 PSCI filtering for AArch32 guests Oliver Upton 2021-08-19 22:36 ` Oliver Upton 2021-08-19 22:36 ` [PATCH 3/6] KVM: arm64: Encapsulate reset request logic in a helper function Oliver Upton 2021-08-19 22:36 ` Oliver Upton 2021-08-19 22:36 ` [PATCH 4/6] KVM: arm64: Add support for SYSTEM_SUSPEND PSCI call Oliver Upton 2021-08-19 22:36 ` Oliver Upton 2021-08-19 22:36 ` [PATCH 5/6] selftests: KVM: Promote PSCI hypercalls to asm volatile Oliver Upton 2021-08-19 22:36 ` Oliver Upton 2021-08-19 22:36 ` [PATCH 6/6] selftests: KVM: Test SYSTEM_SUSPEND PSCI call Oliver Upton 2021-08-19 22:36 ` Oliver Upton 2021-08-19 23:41 ` [PATCH] Documentation: kvm: Document KVM_SYSTEM_EVENT_SUSPEND exit type Oliver Upton 2021-08-19 23:41 ` Oliver Upton 2021-08-22 19:56 ` [PATCH 0/6] KVM: arm64: Implement PSCI SYSTEM_SUSPEND support Oliver Upton 2021-08-22 19:56 ` Oliver Upton 2021-08-26 10:51 ` Marc Zyngier 2021-08-26 10:51 ` Marc Zyngier 2021-08-26 18:37 ` Oliver Upton 2021-08-26 18:37 ` Oliver Upton 2021-08-27 21:58 ` [RFC kvmtool PATCH 0/2] " Oliver Upton 2021-08-27 21:58 ` Oliver Upton 2021-08-27 21:58 ` [RFC kvmtool PATCH 1/2] TESTONLY: KVM: Update KVM headers Oliver Upton 2021-08-27 21:58 ` Oliver Upton 2021-08-27 21:58 ` [RFC kvmtool PATCH 2/2] arm64: Add support for KVM_CAP_ARM_SYSTEM_SUSPEND Oliver Upton 2021-08-27 21:58 ` Oliver Upton 2021-09-06 9:12 ` [PATCH 0/6] KVM: arm64: Implement PSCI SYSTEM_SUSPEND support Marc Zyngier 2021-09-06 9:12 ` Marc Zyngier 2021-09-07 16:30 ` Oliver Upton 2021-09-07 16:30 ` Oliver Upton 2021-09-07 17:43 ` Marc Zyngier 2021-09-07 17:43 ` Marc Zyngier 2021-09-07 18:14 ` Oliver Upton 2021-09-07 18:14 ` Oliver Upton 2021-09-21 9:45 ` Marc Zyngier 2021-09-21 9:45 ` Marc Zyngier 2021-09-21 18:22 ` Oliver Upton 2021-09-21 18:22 ` Oliver Upton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210819223640.3564975-1-oupton@google.com \ --to=oupton@google.com \ --cc=alexandru.elisei@arm.com \ --cc=drjones@redhat.com \ --cc=james.morse@arm.com \ --cc=jingzhangos@google.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=maz@kernel.org \ --cc=pshier@google.com \ --cc=rananta@google.com \ --cc=ricarkol@google.com \ --cc=suzuki.poulose@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.