All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
	Sergey Shtylyov <s.shtylyov@omp.ru>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Sergei Shtylyov <sergei.shtylyov@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Adam Ford <aford173@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>
Subject: [PATCH net-next 10/13] ravb: Factorise ravb_set_features
Date: Wed, 25 Aug 2021 08:01:51 +0100	[thread overview]
Message-ID: <20210825070154.14336-11-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20210825070154.14336-1-biju.das.jz@bp.renesas.com>

RZ/G2L supports HW checksum on RX and TX whereas R-Car supports on RX.
Factorise ravb_set_features to support this feature.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/net/ethernet/renesas/ravb.h      |  1 +
 drivers/net/ethernet/renesas/ravb_main.c | 15 +++++++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
index 9879690c5cd8..9e284238ed83 100644
--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h
@@ -985,6 +985,7 @@ struct ravb_hw_info {
 	void *(*alloc_rx_desc)(struct net_device *ndev, int q);
 	bool (*receive)(struct net_device *ndev, int *quota, int q);
 	void (*set_rate)(struct net_device *ndev);
+	int (*set_rx_csum_feature)(struct net_device *ndev, netdev_features_t features);
 	const char (*gstrings_stats)[ETH_GSTRING_LEN];
 	size_t gstrings_size;
 	netdev_features_t net_hw_features;
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 1f9d9f54bf1b..1789309c4c03 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1901,8 +1901,8 @@ static void ravb_set_rx_csum(struct net_device *ndev, bool enable)
 	spin_unlock_irqrestore(&priv->lock, flags);
 }
 
-static int ravb_set_features(struct net_device *ndev,
-			     netdev_features_t features)
+static int ravb_set_features_rx_csum(struct net_device *ndev,
+				     netdev_features_t features)
 {
 	netdev_features_t changed = ndev->features ^ features;
 
@@ -1914,6 +1914,15 @@ static int ravb_set_features(struct net_device *ndev,
 	return 0;
 }
 
+static int ravb_set_features(struct net_device *ndev,
+			     netdev_features_t features)
+{
+	struct ravb_private *priv = netdev_priv(ndev);
+	const struct ravb_hw_info *info = priv->info;
+
+	return info->set_rx_csum_feature(ndev, features);
+}
+
 static const struct net_device_ops ravb_netdev_ops = {
 	.ndo_open		= ravb_open,
 	.ndo_stop		= ravb_close,
@@ -1980,6 +1989,7 @@ static const struct ravb_hw_info ravb_gen3_hw_info = {
 	.alloc_rx_desc = ravb_alloc_rx_desc,
 	.receive = ravb_rcar_rx,
 	.set_rate = ravb_set_rate,
+	.set_rx_csum_feature = ravb_set_features_rx_csum,
 	.gstrings_stats = ravb_gstrings_stats,
 	.gstrings_size = sizeof(ravb_gstrings_stats),
 	.net_hw_features = NETIF_F_RXCSUM,
@@ -1998,6 +2008,7 @@ static const struct ravb_hw_info ravb_gen2_hw_info = {
 	.alloc_rx_desc = ravb_alloc_rx_desc,
 	.receive = ravb_rcar_rx,
 	.set_rate = ravb_set_rate,
+	.set_rx_csum_feature = ravb_set_features_rx_csum,
 	.gstrings_stats = ravb_gstrings_stats,
 	.gstrings_size = sizeof(ravb_gstrings_stats),
 	.net_hw_features = NETIF_F_RXCSUM,
-- 
2.17.1


  parent reply	other threads:[~2021-08-25  7:02 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  7:01 [PATCH net-next 00/13] Add Factorisation code to support Gigabit Ethernet driver Biju Das
2021-08-25  7:01 ` [PATCH net-next 01/13] ravb: Remove the macros NUM_TX_DESC_GEN[23] Biju Das
2021-08-25 14:30   ` Sergey Shtylyov
2021-08-25  7:01 ` [PATCH net-next 02/13] ravb: Add multi_irq to struct ravb_hw_info Biju Das
2021-08-25 18:49   ` Sergey Shtylyov
2021-08-25 19:10     ` Sergey Shtylyov
2021-08-25  7:01 ` [PATCH net-next 03/13] ravb: Add no_ptp_cfg_active " Biju Das
2021-08-25 20:17   ` Sergey Shtylyov
2021-08-25  7:01 ` [PATCH net-next 04/13] ravb: Add ptp_cfg_active " Biju Das
2021-08-25 20:38   ` Sergey Shtylyov
2021-08-26  6:20     ` Biju Das
2021-08-26 10:29       ` Sergey Shtylyov
2021-08-26 10:34         ` Biju Das
2021-08-26 10:42           ` Sergey Shtylyov
2021-08-26 10:52             ` Biju Das
2021-08-26 18:06               ` Sergei Shtylyov
2021-08-26 18:57                 ` Andrew Lunn
2021-08-26 19:02                   ` Sergey Shtylyov
2021-08-26 19:09                     ` Andrew Lunn
2021-08-26 19:37                       ` Biju Das
2021-08-26 20:03                         ` Sergey Shtylyov
2021-08-27  6:36                           ` Biju Das
2021-08-27 15:48                             ` Sergey Shtylyov
2021-08-27 15:55                               ` Biju Das
2021-08-25  7:01 ` [PATCH net-next 05/13] ravb: Factorise ravb_ring_free function Biju Das
2021-08-25 20:53   ` Sergey Shtylyov
2021-08-25  7:01 ` [PATCH net-next 06/13] ravb: Factorise ravb_ring_format function Biju Das
2021-08-26 18:54   ` Sergey Shtylyov
2021-08-26 19:34     ` Biju Das
2021-08-25  7:01 ` [PATCH net-next 07/13] ravb: Factorise ravb_ring_init function Biju Das
2021-08-26 20:27   ` Sergey Shtylyov
2021-08-25  7:01 ` [PATCH net-next 08/13] ravb: Factorise ravb_rx function Biju Das
2021-08-26 20:41   ` Sergey Shtylyov
2021-08-27  6:28     ` Biju Das
2021-08-25  7:01 ` [PATCH net-next 09/13] ravb: Factorise ravb_adjust_link function Biju Das
2021-08-25  7:01 ` Biju Das [this message]
2021-08-27 19:16   ` [PATCH net-next 10/13] ravb: Factorise ravb_set_features Sergey Shtylyov
2021-08-28  9:20     ` Biju Das
2021-08-28 11:35       ` Sergey Shtylyov
2021-08-28 12:45         ` Biju Das
2021-08-25  7:01 ` [PATCH net-next 11/13] ravb: Factorise ravb_dmac_init function Biju Das
2021-08-27 19:36   ` Sergey Shtylyov
2021-08-28  9:28     ` Biju Das
2021-08-25  7:01 ` [PATCH net-next 12/13] ravb: Factorise ravb_emac_init function Biju Das
2021-08-27 19:52   ` Sergey Shtylyov
2021-08-28  9:34     ` Biju Das
2021-08-25  7:01 ` [PATCH net-next 13/13] ravb: Add reset support Biju Das
2021-08-27 20:17   ` Sergey Shtylyov
2021-08-28  9:41     ` Biju Das
2021-08-25 10:30 ` [PATCH net-next 00/13] Add Factorisation code to support Gigabit Ethernet driver patchwork-bot+netdevbpf
2021-08-25 10:57   ` Sergey Shtylyov
2021-08-25 13:46     ` Andrew Lunn
2021-08-25 14:06       ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825070154.14336-11-biju.das.jz@bp.renesas.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=aford173@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=biju.das@bp.renesas.com \
    --cc=davem@davemloft.net \
    --cc=geert+renesas@glider.be \
    --cc=kuba@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=s.shtylyov@omp.ru \
    --cc=sergei.shtylyov@gmail.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.