All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
To: broonie@kernel.org, liam.r.girdwood@linux.intel.com,
	hdegoede@redhat.com, cezary.rojewski@intel.com,
	pierre-louis.bossart@linux.intel.com, yang.jie@linux.intel.com
Cc: alsa-devel@alsa-project.org
Subject: [PATCH] ASoC: Intel: bytcr_rt5640: Make rt5640_jack_gpio/rt5640_jack2_gpio static
Date: Wed, 25 Aug 2021 15:25:19 +0300	[thread overview]
Message-ID: <20210825122519.3364-1-peter.ujfalusi@linux.intel.com> (raw)

Marking the two jack gpio as static fixes the following Sparse errors:
sound/soc/intel/boards/bytcr_rt5640.c:468:26: error: symbol 'rt5640_jack_gpio' was not declared. Should it be static?
sound/soc/intel/boards/bytcr_rt5640.c:475:26: error: symbol 'rt5640_jack2_gpio' was not declared. Should it be static?

Fixes: 9ba00856686ad ("ASoC: Intel: bytcr_rt5640: Add support for HP Elite Pad 1000G2 jack-detect")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
 sound/soc/intel/boards/bytcr_rt5640.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 05667a33d919..a6e837290c7d 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -465,14 +465,14 @@ static struct snd_soc_jack_pin rt5640_pins2[] = {
 	},
 };
 
-struct snd_soc_jack_gpio rt5640_jack_gpio = {
+static struct snd_soc_jack_gpio rt5640_jack_gpio = {
 	.name = "hp-detect",
 	.report = SND_JACK_HEADSET,
 	.invert = true,
 	.debounce_time = 200,
 };
 
-struct snd_soc_jack_gpio rt5640_jack2_gpio = {
+static struct snd_soc_jack_gpio rt5640_jack2_gpio = {
 	.name = "hp2-detect",
 	.report = SND_JACK_HEADSET,
 	.invert = true,
-- 
2.33.0


             reply	other threads:[~2021-08-25 12:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 12:25 Peter Ujfalusi [this message]
2021-08-25 15:06 ` [PATCH] ASoC: Intel: bytcr_rt5640: Make rt5640_jack_gpio/rt5640_jack2_gpio static Mark Brown
2021-08-25 15:06   ` Mark Brown
2021-08-25 15:07 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825122519.3364-1-peter.ujfalusi@linux.intel.com \
    --to=peter.ujfalusi@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.