All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	bcousson@baylibre.com, Tony Lindgren <tony@atomide.com>,
	Tero Kristo <t-kristo@ti.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	"Ryan J . Barnett" <ryan.barnett@collins.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-input@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-clk@vger.kernel.org,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH 22/40] mfd: ti_am335x_tscadc: Add TSC prefix in certain macros
Date: Wed, 25 Aug 2021 17:25:00 +0200	[thread overview]
Message-ID: <20210825152518.379386-23-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20210825152518.379386-1-miquel.raynal@bootlin.com>

While the register list (and names) between ADC0 and ADC1 are pretty
close, the bits inside changed a little bit. To avoid any future
confusion, let's add the TSC prefix when some bits are in a register
that is common to both revisions of the ADC, but are specific to the
am33xx hardware.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/mfd/ti_am335x_tscadc.c       | 10 +++++-----
 include/linux/mfd/ti_am335x_tscadc.h | 16 ++++++++--------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
index dd303523f9a3..02477ce827d0 100644
--- a/drivers/mfd/ti_am335x_tscadc.c
+++ b/drivers/mfd/ti_am335x_tscadc.c
@@ -215,15 +215,15 @@ static	int ti_tscadc_probe(struct platform_device *pdev)
 	regmap_write(tscadc->regmap, REG_CLKDIV, tscadc->clk_div);
 
 	/* Set the control register bits */
-	tscadc->ctrl = CNTRLREG_STEPCONFIGWRT | CNTRLREG_STEPID;
+	tscadc->ctrl = CNTRLREG_TSC_STEPCONFIGWRT | CNTRLREG_STEPID;
 	regmap_write(tscadc->regmap, REG_CTRL, tscadc->ctrl);
 
 	if (tsc_wires > 0) {
-		tscadc->ctrl |= CNTRLREG_TSCENB;
+		tscadc->ctrl |= CNTRLREG_TSC_ENB;
 		if (tsc_wires == 5)
-			tscadc->ctrl |= CNTRLREG_5WIRE;
+			tscadc->ctrl |= CNTRLREG_TSC_5WIRE;
 		else
-			tscadc->ctrl |= CNTRLREG_4WIRE;
+			tscadc->ctrl |= CNTRLREG_TSC_4WIRE;
 	}
 
 	tscadc_idle_config(tscadc);
@@ -322,7 +322,7 @@ static const struct ti_tscadc_data tscdata = {
 	.compat_tscmag = "ti,am3359-tsc",
 	.name_adc = "TI-am335x-adc",
 	.compat_adc = "ti,am3359-adc",
-	.target_clk_rate = ADC_CLK,
+	.target_clk_rate = TSC_ADC_CLK,
 };
 
 static const struct of_device_id ti_tscadc_dt_ids[] = {
diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
index a900fae8354c..d5e2ff8dc84a 100644
--- a/include/linux/mfd/ti_am335x_tscadc.h
+++ b/include/linux/mfd/ti_am335x_tscadc.h
@@ -120,14 +120,14 @@
 /* Control register */
 #define CNTRLREG_SSENB		BIT(0)
 #define CNTRLREG_STEPID		BIT(1)
-#define CNTRLREG_STEPCONFIGWRT	BIT(2)
+#define CNTRLREG_TSC_STEPCONFIGWRT BIT(2)
 #define CNTRLREG_POWERDOWN	BIT(4)
-#define CNTRLREG_AFE_CTRL_MASK	(3 << 5)
-#define CNTRLREG_AFE_CTRL(val)	((val) << 5)
-#define CNTRLREG_4WIRE		CNTRLREG_AFE_CTRL(1)
-#define CNTRLREG_5WIRE		CNTRLREG_AFE_CTRL(2)
-#define CNTRLREG_8WIRE		CNTRLREG_AFE_CTRL(3)
-#define CNTRLREG_TSCENB		BIT(7)
+#define CNTRLREG_TSC_AFE_CTRL_MASK (3 << 5)
+#define CNTRLREG_TSC_AFE_CTRL(val) ((val) << 5)
+#define CNTRLREG_TSC_4WIRE	CNTRLREG_TSC_AFE_CTRL(1)
+#define CNTRLREG_TSC_5WIRE	CNTRLREG_TSC_AFE_CTRL(2)
+#define CNTRLREG_TSC_8WIRE	CNTRLREG_TSC_AFE_CTRL(3)
+#define CNTRLREG_TSC_ENB	BIT(7)
 
 /* FIFO READ Register */
 #define FIFOREAD_DATA_MASK (0xfff << 0)
@@ -141,7 +141,7 @@
 #define SEQ_STATUS BIT(5)
 #define CHARGE_STEP		0x11
 
-#define ADC_CLK			3000000
+#define TSC_ADC_CLK		3000000
 #define TOTAL_STEPS		16
 #define TOTAL_CHANNELS		8
 #define FIFO1_THRESHOLD		19
-- 
2.27.0


  parent reply	other threads:[~2021-08-25 15:34 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 15:24 [PATCH 00/40] TI AM437X ADC1 Miquel Raynal
2021-08-25 15:24 ` [PATCH 01/40] clk: ti: am43xx: Add clkctrl data for am43xx ADC1 Miquel Raynal
2021-08-25 15:24 ` [PATCH 02/40] dt-bindings: mfd: ti,am3359-tscadc: Add a yaml description for this MFD Miquel Raynal
2021-08-30 12:47   ` Jonathan Cameron
2021-09-02 17:35     ` Miquel Raynal
2021-08-31 19:33   ` Rob Herring
2021-08-25 15:24 ` [PATCH 03/40] dt-bindings: touchscreen: ti,am3359-tsc: New yaml description Miquel Raynal
2021-08-30 13:36   ` Jonathan Cameron
2021-09-02 17:45     ` Miquel Raynal
2021-09-05 11:58       ` Jonathan Cameron
2021-08-31 19:37   ` Rob Herring
2021-09-01  7:42     ` Miquel Raynal
2021-08-25 15:24 ` [PATCH 04/40] dt-bindings: iio: adc: ti,am3359-adc: " Miquel Raynal
2021-08-30 12:31   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 05/40] dt-bindings: touchscreen: ti,am3359-tsc: Remove deprecated text file Miquel Raynal
2021-08-30 12:39   ` Jonathan Cameron
2021-08-31 19:38   ` Rob Herring
2021-08-25 15:24 ` [PATCH 06/40] dt-bindings: mfd: ti,am3359-tscadc: Describe am4372 MFD compatible Miquel Raynal
2021-08-30 12:34   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 07/40] dt-bindings: iio: adc: ti,am3359-adc: Describe am4372 ADC compatible Miquel Raynal
2021-08-30 12:35   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 08/40] mfd: ti_am335x_tscadc: Replace license text with SPDX tag Miquel Raynal
2021-08-30 12:38   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 09/40] mfd: ti_am335x_tscadc: Fix style Miquel Raynal
2021-08-30 12:49   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 10/40] mfd: ti_am335x_tscadc: Drop extra spacing when declaring stack variables Miquel Raynal
2021-08-30 12:52   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 11/40] mfd: ti_am335x_tscadc: Get rid of useless gotos Miquel Raynal
2021-08-30 13:39   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 12/40] mfd: ti_am335x_tscadc: Move the driver structure allocation earlier Miquel Raynal
2021-08-30 14:25   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 13/40] mfd: ti_am335x_tscadc: Reword the comment explaining the dividers Miquel Raynal
2021-08-30 13:43   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 14/40] mfd: ti_am335x_tscadc: Don't search the tree for our clock Miquel Raynal
2021-08-25 15:24 ` [PATCH 15/40] mfd: ti_am335x_tscadc: Simplify divisor calculation Miquel Raynal
2021-08-30 13:47   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 16/40] mfd: ti_am335x_tscadc: Use driver data Miquel Raynal
2021-08-30 14:46   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 17/40] mfd: ti_am335x_tscadc: Mimic the probe from resume() Miquel Raynal
2021-08-25 15:24 ` [PATCH 18/40] mfd: ti_am335x_tscadc: Drop useless variables from the driver structure Miquel Raynal
2021-08-25 15:24 ` [PATCH 19/40] mfd: ti_am335x_tscadc: Always provide an idle configuration Miquel Raynal
2021-08-30 14:49   ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 20/40] mfd: ti_am335x_tscadc: Gather the ctrl register logic at one place Miquel Raynal
2021-08-30 13:56   ` Jonathan Cameron
2021-09-02 19:42     ` Miquel Raynal
2021-09-05 11:13       ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 21/40] mfd: ti_am335x_tscadc: Rename the subsystem enable macro Miquel Raynal
2021-08-30 14:50   ` Jonathan Cameron
2021-08-25 15:25 ` Miquel Raynal [this message]
2021-08-30 14:52   ` [PATCH 22/40] mfd: ti_am335x_tscadc: Add TSC prefix in certain macros Jonathan Cameron
2021-08-25 15:25 ` [PATCH 23/40] mfd: ti_am335x_tscadc: Rename a variable Miquel Raynal
2021-08-30 14:53   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 24/40] mfd: ti_am335x_tscadc: Fix an error message Miquel Raynal
2021-08-30 13:58   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 25/40] mfd: ti_am335x_tscadc: Add a boolean to clarify the presence of a touchscreen Miquel Raynal
2021-08-30 13:59   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 26/40] mfd: ti_am335x_tscadc: Introduce has_tsc Miquel Raynal
2021-08-30 14:02   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 27/40] mfd: ti_am335x_tscadc: Move control register configuration Miquel Raynal
2021-08-30 14:03   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 28/40] mfd: ti_am335x_tscadc: Add ADC1/magnetic reader support Miquel Raynal
2021-08-30 14:10   ` Jonathan Cameron
2021-09-02 18:31     ` Miquel Raynal
2021-09-02 20:03     ` Miquel Raynal
2021-09-01 19:26   ` Grygorii Strashko
2021-09-02  6:47     ` Miquel Raynal
2021-09-02  9:57       ` Grygorii Strashko
2021-08-25 15:25 ` [PATCH 29/40] mfd: ti_am335x_tscadc: Support the correctly spelled DT property Miquel Raynal
2021-08-30 14:11   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 30/40] iio: adc: ti_am335x_adc: Replace license text with SPDX tag Miquel Raynal
2021-08-30 14:12   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 31/40] iio: adc: ti_am335x_adc: Fix style Miquel Raynal
2021-08-30 14:16   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 32/40] iio: adc: ti_am335x_adc: Get rid of useless gotos Miquel Raynal
2021-08-30 14:18   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 33/40] iio: adc: ti_am335x_adc: Gather the checks on the delays Miquel Raynal
2021-08-30 14:19   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 34/40] iio: adc: ti_am335x_adc: Add a unit to the timeout delay Miquel Raynal
2021-08-30 14:20   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 35/40] iio: adc: ti_am335x_adc: Wait the idle state to avoid stalls Miquel Raynal
2021-08-30 14:22   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 36/40] iio: adc: ti_am335x_adc: Add the scale information Miquel Raynal
2021-08-30 14:23   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 37/40] iio: adc: ti_am335x_adc: Add the am437x compatible Miquel Raynal
2021-08-30 14:24   ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 38/40] ARM: dts: am437x-cm-t43: Use a correctly spelled DT property Miquel Raynal
2021-08-25 15:25 ` [PATCH 39/40] ARM: dts: am43xx: Describe the magnetic reader/ADC1 hardware module Miquel Raynal
2021-08-25 15:25 ` [PATCH 40/40] ARM: dts: am437x-gp-evm: enable ADC1 Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825152518.379386-23-miquel.raynal@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=ryan.barnett@collins.com \
    --cc=sboyd@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.