All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hao Xu <haoxu@linux.alibaba.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
	Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: [PATCH 1/2] io_uring: remove redundant req_set_fail()
Date: Fri, 27 Aug 2021 17:46:08 +0800	[thread overview]
Message-ID: <20210827094609.36052-2-haoxu@linux.alibaba.com> (raw)
In-Reply-To: <20210827094609.36052-1-haoxu@linux.alibaba.com>

req_set_fail() in io_submit_sqe() is redundant, remove it.

Signed-off-by: Hao Xu <haoxu@linux.alibaba.com>
---
 fs/io_uring.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index d9534c72dc4b..3598319b1340 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -6631,7 +6631,6 @@ static int io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req,
 fail_req:
 		if (link->head) {
 			/* fail even hard links since we don't submit */
-			req_set_fail(link->head);
 			io_req_complete_failed(link->head, -ECANCELED);
 			link->head = NULL;
 		}
-- 
2.24.4


  reply	other threads:[~2021-08-27  9:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27  9:46 [PATCH for-5.15 v3 0/2] fix failed linkchain code logic Hao Xu
2021-08-27  9:46 ` Hao Xu [this message]
2021-08-27  9:46 ` [PATCH 2/2] io_uring: " Hao Xu
2021-08-27 11:01 ` [PATCH for-5.15 v3 0/2] " Pavel Begunkov
2021-08-27 13:27 ` Jens Axboe
2021-08-27 17:04   ` Hao Xu
  -- strict thread matches above, loose matches on Subject: below --
2021-08-23  3:25 [PATCH for-5.15 v2 " Hao Xu
2021-08-23  3:25 ` [PATCH 1/2] io_uring: remove redundant req_set_fail() Hao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210827094609.36052-2-haoxu@linux.alibaba.com \
    --to=haoxu@linux.alibaba.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=joseph.qi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.