All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Shawn C <shawn.c.lee@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com,
	vandita.kulkarni@intel.com, cooper.chiou@intel.com,
	william.tseng@intel.com, Lee Shawn C <shawn.c.lee@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>
Subject: [Intel-gfx] [v3 2/5] drm/i915/dsi: refine send MIPI DCS command sequence
Date: Thu,  2 Sep 2021 20:14:26 +0800	[thread overview]
Message-ID: <20210902121429.27606-3-shawn.c.lee@intel.com> (raw)
In-Reply-To: <20210902121429.27606-1-shawn.c.lee@intel.com>

According to chapter "Sending Commands to the Panel" in bspec #29738
and #49188. If driver try to send DCS long pakcet, we have to program
TX payload register at first. And configure TX header HW register later.
DSC long packet would not be sent properly if we don't follow this
sequence.

Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: William Tseng <william.tseng@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
---
 drivers/gpu/drm/i915/display/icl_dsi.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index 44289003b709..060bc8fb0d30 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -1831,11 +1831,6 @@ static ssize_t gen11_dsi_host_transfer(struct mipi_dsi_host *host,
 	if (msg->flags & MIPI_DSI_MSG_USE_LPM)
 		enable_lpdt = true;
 
-	/* send packet header */
-	ret  = dsi_send_pkt_hdr(intel_dsi_host, dsi_pkt, enable_lpdt);
-	if (ret < 0)
-		return ret;
-
 	/* only long packet contains payload */
 	if (mipi_dsi_packet_format_is_long(msg->type)) {
 		ret = dsi_send_pkt_payld(intel_dsi_host, dsi_pkt);
@@ -1843,6 +1838,11 @@ static ssize_t gen11_dsi_host_transfer(struct mipi_dsi_host *host,
 			return ret;
 	}
 
+	/* send packet header */
+	ret  = dsi_send_pkt_hdr(intel_dsi_host, dsi_pkt, enable_lpdt);
+	if (ret < 0)
+		return ret;
+
 	//TODO: add payload receive code if needed
 
 	ret = sizeof(dsi_pkt.header) + dsi_pkt.payload_length;
-- 
2.17.1


  parent reply	other threads:[~2021-09-02 12:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 12:14 [Intel-gfx] [v3 0/5] DSI driver improvement Lee Shawn C
2021-09-02 12:14 ` [Intel-gfx] [v3 1/5] drm/i915/dsi: wait for header and payload credit available Lee Shawn C
2021-09-02 12:14 ` Lee Shawn C [this message]
2021-09-02 12:14 ` [Intel-gfx] [v3 3/5] drm/i915: Get proper min cdclk if vDSC enabled Lee Shawn C
2021-09-08 11:29   ` Jani Nikula
2021-09-02 12:14 ` [Intel-gfx] [v3 4/5] drm/i915/dsi: Retrieve max brightness level from VBT Lee Shawn C
2021-09-08 11:19   ` Jani Nikula
2021-09-02 12:14 ` [Intel-gfx] [v3 5/5] drm/i915/dsi: Read/write proper brightness value via MIPI DCS command Lee Shawn C
2021-09-02 15:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for DSI driver improvement (rev3) Patchwork
2021-09-02 15:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-02 19:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-08 13:51   ` Lee, Shawn C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210902121429.27606-3-shawn.c.lee@intel.com \
    --to=shawn.c.lee@intel.com \
    --cc=cooper.chiou@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=vandita.kulkarni@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=william.tseng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.