From: Kevin Stefanov <kevin.stefanov@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Stefanov <kevin.stefanov@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS
Date: Thu, 9 Sep 2021 17:34:39 +0100 [thread overview]
Message-ID: <20210909163441.44418-2-kevin.stefanov@citrix.com> (raw)
In-Reply-To: <20210909163441.44418-1-kevin.stefanov@citrix.com>
The spec requires 64-byte alignment, not 16.
Signed-off-by: Kevin Stefanov <kevin.stefanov@citrix.com>
---
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Note: This does not fix the FACS alignment inside guests yet. See next
patch.
---
tools/libacpi/build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c
index a61dd5583a..fe2db66a62 100644
--- a/tools/libacpi/build.c
+++ b/tools/libacpi/build.c
@@ -532,7 +532,7 @@ int acpi_build_tables(struct acpi_ctxt *ctxt, struct acpi_config *config)
* Fill in high-memory data structures, starting at @buf.
*/
- facs = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_facs), 16);
+ facs = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_facs), 64);
if (!facs) goto oom;
memcpy(facs, &Facs, sizeof(struct acpi_20_facs));
--
2.25.1
next prev parent reply other threads:[~2021-09-09 16:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 16:34 [PATCH 0/3] Fix alignment of FACS in guests Kevin Stefanov
2021-09-09 16:34 ` Kevin Stefanov [this message]
2021-09-09 17:03 ` [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS Andrew Cooper
2021-09-10 14:50 ` [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS [and 1 more messages] Ian Jackson
2021-09-13 7:08 ` Jan Beulich
2021-09-10 7:55 ` [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS Jan Beulich
2021-09-09 16:34 ` [PATCH 2/3] tools/libxl: Correctly aligned buffer for ACPI tables Kevin Stefanov
2021-09-10 8:19 ` Jan Beulich
2021-09-09 16:34 ` [PATCH 3/3] tools/libxl: Only allocate 64 bytes for RSDP Kevin Stefanov
2021-09-10 8:36 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909163441.44418-2-kevin.stefanov@citrix.com \
--to=kevin.stefanov@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.