From: Eric Snowberg <eric.snowberg@oracle.com>
To: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
zohar@linux.ibm.com, dhowells@redhat.com, dwmw2@infradead.org,
herbert@gondor.apana.org.au, davem@davemloft.net,
jarkko@kernel.org, jmorris@namei.org, serge@hallyn.com
Cc: eric.snowberg@oracle.com, keescook@chromium.org,
gregkh@linuxfoundation.org, torvalds@linux-foundation.org,
scott.branden@broadcom.com, weiyongjun1@huawei.com,
nayna@linux.ibm.com, ebiggers@google.com, ardb@kernel.org,
nramas@linux.microsoft.com, lszubowi@redhat.com,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-security-module@vger.kernel.org,
James.Bottomley@HansenPartnership.com, pjones@redhat.com,
konrad.wilk@oracle.com
Subject: [PATCH v6 00/13] Enroll kernel keys thru MOK
Date: Tue, 14 Sep 2021 17:14:03 -0400 [thread overview]
Message-ID: <20210914211416.34096-1-eric.snowberg@oracle.com> (raw)
Back in 2013 Linus requested a feature to allow end-users to have the
ability "to add their own keys and sign modules they trust". This was
his *second* order outlined here [1]. There have been many attempts
over the years to solve this problem, all have been rejected. Many
of the failed attempts loaded all preboot firmware keys into the kernel,
including the Secure Boot keys. Many distributions carry one of these
rejected attempts [2], [3], [4]. This series tries to solve this problem
with a solution that takes into account all the problems brought up in
the previous attempts.
On UEFI based systems, this series introduces a new Linux kernel keyring
containing the Machine Owner Keys (MOK) called machine. It also defines
a new MOK variable in shim. This variable allows the end-user to decide
if they want to load MOK keys into the machine keyring. Mimi has suggested
that only CA keys contained within the MOK be loaded into the machine
keyring. All other certs will load into the platform keyring instead.
By default, nothing changes; MOK keys are not loaded into the machine
keyring. They are only loaded after the end-user makes the decision
themselves. The end-user would set this through mokutil using a new
--trust-mok option [5]. This would work similar to how the kernel uses
MOK variables to enable/disable signature validation as well as use/ignore
the db. Any kernel operation that uses either the builtin or secondary
trusted keys as a trust source shall also reference the new machine
keyring as a trust source.
Secure Boot keys will never be loaded into the machine keyring. They
will always be loaded into the platform keyring. If an end-user wanted
to load one, they would need to enroll it into the MOK.
Steps required by the end user:
Sign kernel module with user created key:
$ /usr/src/kernels/$(uname -r)/scripts/sign-file sha512 \
machine_signing_key.priv machine_signing_key.x509 my_module.ko
Import the key into the MOK
$ mokutil --import machine_signing_key.x509
Setup the kernel to load MOK keys into the .machine keyring
$ mokutil --trust-mok
Then reboot, the MokManager will load and ask if you want to trust the
MOK key and enroll the MOK into the MOKList. Afterwards the signed kernel
module will load.
I have included links to both the mokutil [5] and shim [6] changes I
have made to support this new functionality.
[1] https://marc.info/?l=linux-kernel&m=136185386310140&w=2
[2] https://lore.kernel.org/lkml/1479737095.2487.34.camel@linux.vnet.ibm.com/
[3] https://lore.kernel.org/lkml/1556221605.24945.3.camel@HansenPartnership.com/
[4] https://lore.kernel.org/linux-integrity/1e41f22b1f11784f1e943f32bf62034d4e054cdb.camel@HansenPartnership.com/
[5] https://github.com/esnowberg/mokutil/tree/0.3.0-mokvars-v2
[6] https://github.com/esnowberg/shim/tree/mokvars-v2
Eric Snowberg (13):
integrity: Introduce a Linux keyring called machine
integrity: Do not allow machine keyring updates following init
KEYS: CA link restriction
integrity: restrict INTEGRITY_KEYRING_MACHINE to restrict_link_by_ca
integrity: add new keyring handler for mok keys
KEYS: Rename get_builtin_and_secondary_restriction
KEYS: add a reference to machine keyring
KEYS: Introduce link restriction for machine keys
KEYS: integrity: change link restriction to trust the machine keyring
KEYS: link secondary_trusted_keys to machine trusted keys
integrity: store reference to machine keyring
integrity: Trust MOK keys if MokListTrustedRT found
integrity: Only use machine keyring when uefi_check_trust_mok_keys is
true
certs/system_keyring.c | 44 +++++++++-
crypto/asymmetric_keys/restrict.c | 40 +++++++++
include/crypto/public_key.h | 5 ++
include/keys/system_keyring.h | 14 +++
security/integrity/Kconfig | 12 +++
security/integrity/Makefile | 1 +
security/integrity/digsig.c | 23 ++++-
security/integrity/integrity.h | 17 +++-
.../platform_certs/keyring_handler.c | 17 +++-
.../platform_certs/keyring_handler.h | 5 ++
security/integrity/platform_certs/load_uefi.c | 4 +-
.../platform_certs/machine_keyring.c | 85 +++++++++++++++++++
12 files changed, 257 insertions(+), 10 deletions(-)
create mode 100644 security/integrity/platform_certs/machine_keyring.c
base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
--
2.18.4
next reply other threads:[~2021-09-14 21:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 21:14 Eric Snowberg [this message]
2021-09-14 21:14 ` [PATCH v6 01/13] integrity: Introduce a Linux keyring called machine Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 02/13] integrity: Do not allow machine keyring updates following init Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 03/13] KEYS: CA link restriction Eric Snowberg
2021-09-16 4:21 ` kernel test robot
2021-09-16 4:21 ` kernel test robot
2021-09-16 5:46 ` kernel test robot
2021-09-16 5:46 ` kernel test robot
2021-09-16 20:05 ` Nayna
2021-09-14 21:14 ` [PATCH v6 04/13] integrity: restrict INTEGRITY_KEYRING_MACHINE to restrict_link_by_ca Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 05/13] integrity: add new keyring handler for mok keys Eric Snowberg
2021-09-16 3:16 ` kernel test robot
2021-09-16 3:16 ` kernel test robot
2021-09-14 21:14 ` [PATCH v6 06/13] KEYS: Rename get_builtin_and_secondary_restriction Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 07/13] KEYS: add a reference to machine keyring Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 08/13] KEYS: Introduce link restriction for machine keys Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 09/13] KEYS: integrity: change link restriction to trust the machine keyring Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 10/13] KEYS: link secondary_trusted_keys to machine trusted keys Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 11/13] integrity: store reference to machine keyring Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 12/13] integrity: Trust MOK keys if MokListTrustedRT found Eric Snowberg
2021-09-16 22:19 ` Peter Jones
2021-09-17 2:00 ` Eric Snowberg
2021-09-17 15:03 ` Peter Jones
2021-09-17 16:06 ` Eric Snowberg
2021-09-14 21:14 ` [PATCH v6 13/13] integrity: Only use machine keyring when uefi_check_trust_mok_keys is true Eric Snowberg
2021-09-15 17:57 ` [PATCH v6 00/13] Enroll kernel keys thru MOK Jarkko Sakkinen
2021-09-15 21:28 ` Eric Snowberg
2021-09-16 15:15 ` Jarkko Sakkinen
2021-09-16 22:14 ` Peter Jones
2021-09-17 1:58 ` Eric Snowberg
2021-09-21 21:03 ` Jarkko Sakkinen
2021-09-16 20:03 ` Nayna
2021-09-17 1:55 ` Eric Snowberg
2021-09-17 18:02 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914211416.34096-1-eric.snowberg@oracle.com \
--to=eric.snowberg@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=ebiggers@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lszubowi@redhat.com \
--cc=nayna@linux.ibm.com \
--cc=nramas@linux.microsoft.com \
--cc=pjones@redhat.com \
--cc=scott.branden@broadcom.com \
--cc=serge@hallyn.com \
--cc=torvalds@linux-foundation.org \
--cc=weiyongjun1@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.