[PATCH RFC] gitweb: Handle non-ASCII email addresses - Jan-Benedict Glaw

From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: git@vger.kernel.org
Subject: [PATCH RFC] gitweb: Handle non-ASCII email addresses
Date: Wed, 15 Sep 2021 21:26:47 +0200	[thread overview]
Message-ID: <20210915192647.6fnk7ktwldz7uubf@lug-owl.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

Hi!

I accidentally had a bad user.email setting ("jbglaw@ług-owl.de"
instead of "jbglaw@lug-owl.de") and this leads to incomplete HTML
being generated by gitweb, along with an error message:

index.cgi: Wide character in subroutine entry at /usr/share/gitweb/index.cgi line 2208.

This patch may fix it, but I'm NOT a Perl guy:

--- a/gitweb/gitweb.perl	2021-09-15 20:23:13.788195846 +0200
+++ b/gitweb/gitweb.perl	2021-09-15 20:24:19.911806868 +0200
@@ -2193,7 +2193,7 @@
 	my $size = shift;
 	$avatar_cache{$email} ||=
 		"//www.gravatar.com/avatar/" .
-			md5_hex($email) . "?s=";
+			md5_hex(utf8::is_utf8($email)? Encode::encode_utf8($email): $email) . "?s=";
 	return $avatar_cache{$email} . $size;
 }


Comments?

Thanks,
  Jan-Benedict

-- 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
