All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cai Huoqing <caihuoqing@baidu.com>
To: <caihuoqing@baidu.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] Input: mms114 - Make use of the helper function dev_err_probe()
Date: Thu, 16 Sep 2021 23:33:25 +0800	[thread overview]
Message-ID: <20210916153326.14734-1-caihuoqing@baidu.com> (raw)

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/input/touchscreen/mms114.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
index 9fa3b0e421be..4b36db084d86 100644
--- a/drivers/input/touchscreen/mms114.c
+++ b/drivers/input/touchscreen/mms114.c
@@ -525,20 +525,14 @@ static int mms114_probe(struct i2c_client *client,
 	i2c_set_clientdata(client, data);
 
 	data->core_reg = devm_regulator_get(&client->dev, "avdd");
-	if (IS_ERR(data->core_reg)) {
-		error = PTR_ERR(data->core_reg);
-		dev_err(&client->dev,
-			"Unable to get the Core regulator (%d)\n", error);
-		return error;
-	}
+	if (IS_ERR(data->core_reg))
+		return dev_err_probe(&client->dev, PTR_ERR(data->core_reg),
+				     "Unable to get the Core regulator\n");
 
 	data->io_reg = devm_regulator_get(&client->dev, "vdd");
-	if (IS_ERR(data->io_reg)) {
-		error = PTR_ERR(data->io_reg);
-		dev_err(&client->dev,
-			"Unable to get the IO regulator (%d)\n", error);
-		return error;
-	}
+	if (IS_ERR(data->io_reg))
+		return dev_err_probe(&client->dev, PTR_ERR(data->io_reg),
+				     "Unable to get the IO regulator\n");
 
 	error = devm_request_threaded_irq(&client->dev, client->irq,
 					  NULL, mms114_interrupt,
-- 
2.25.1


                 reply	other threads:[~2021-09-16 15:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210916153326.14734-1-caihuoqing@baidu.com \
    --to=caihuoqing@baidu.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.