From: Marc Zyngier <maz@kernel.org> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Mark Rutland <mark.rutland@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Peter Shier <pshier@google.com>, Raghavendra Rao Ananta <rananta@google.com>, Ricardo Koller <ricarkol@google.com>, Oliver Upton <oupton@google.com>, Will Deacon <will@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Linus Walleij <linus.walleij@linaro.org>, kernel-team@android.com Subject: [PATCH v2 00/16] clocksource/arm_arch_timer: Add basic ARMv8.6 support Date: Wed, 22 Sep 2021 22:19:25 +0100 [thread overview] Message-ID: <20210922211941.2756270-1-maz@kernel.org> (raw) This is v2 of the series enabling ARMv8.6 support for timer subsystem, and was prompted by a discussion with Oliver around the fact that an ARMv8.6 implementation must have a 1GHz counter, which leads to a number of things to break in the timer code: - the counter rollover can come pretty quickly as we only advertise a 56bit counter, - the maximum timer delta can be remarkably small, as we use the countdown interface which is limited to 32bit... Thankfully, there is a way out: we can compute the minimal width of the counter based on the guarantees that the architecture gives us, and we can use the 64bit comparator interface instead of the countdown to program the timer. Finally, we start making use of the ARMv8.6 ECV features by switching accesses to the counters to a self-synchronising register, removing the need for an ISB. Hopefully, implementations will *not* just stick an invisible ISB there... A side effect of the switch to CVAL is that XGene-1 breaks. I have added a workaround to keep it alive. I have added Oliver's original patch[0] to the series and tweaked a couple of things. Blame me if I broke anything. The whole things has been tested on Juno (sysreg + MMIO timers), XGene-1 (broken sysreg timers), FVP (FEAT_ECV, CNT*CTSS_EL0). * From v1: - New patch adding a bunch of BUILD_BUG()s for register accesses we don't expect. This makes subsequent patches much simpler. - New patch moving the ISBs for workaround in a way that makes more sense for the self-synchronising accessors. - Rework the XGene-1 workaround to rely solely on MIDR. - Split the CNTVCTSS trap handling in its own patch. - Rebased on 5.15-rc2 - Collected RBs, with thanks. [0] https://lore.kernel.org/r/20210807191428.3488948-1-oupton@google.com [1] https://lore.kernel.org/r/20210809152651.2297337-2-maz@kernel.org Marc Zyngier (15): clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors clocksource/arm_arch_timer: Extend write side of timer register accessors to u64 clocksource/arm_arch_timer: Move system register timer programming over to CVAL clocksource/arm_arch_timer: Move drop _tval from erratum function names clocksource/arm_arch_timer: Fix MMIO base address vs callback ordering issue clocksource/arm_arch_timer: Move MMIO timer programming over to CVAL clocksource/arm_arch_timer: Advertise 56bit timer to the core code clocksource/arm_arch_timer: Work around broken CVAL implementations clocksource/arm_arch_timer: Remove any trace of the TVAL programming interface clocksource/arm_arch_timer: Drop unnecessary ISB on CVAL programming clocksource/arch_arm_timer: Move workaround synchronisation around arm64: Add a capability for FEAT_ECV arm64: Add CNT{P,V}CTSS_EL0 alternatives to cnt{p,v}ct_el0 arm64: Add handling of CNTVCTSS traps Oliver Upton (1): clocksource/arm_arch_timer: Fix masking for high freq counters arch/arm/include/asm/arch_timer.h | 37 ++-- arch/arm64/include/asm/arch_timer.h | 78 +++++---- arch/arm64/include/asm/esr.h | 6 + arch/arm64/include/asm/sysreg.h | 3 + arch/arm64/kernel/cpufeature.c | 10 ++ arch/arm64/kernel/traps.c | 11 ++ arch/arm64/tools/cpucaps | 1 + drivers/clocksource/arm_arch_timer.c | 243 ++++++++++++++++----------- include/clocksource/arm_arch_timer.h | 2 +- 9 files changed, 245 insertions(+), 146 deletions(-) -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Mark Rutland <mark.rutland@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Peter Shier <pshier@google.com>, Raghavendra Rao Ananta <rananta@google.com>, Ricardo Koller <ricarkol@google.com>, Oliver Upton <oupton@google.com>, Will Deacon <will@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Linus Walleij <linus.walleij@linaro.org>, kernel-team@android.com Subject: [PATCH v2 00/16] clocksource/arm_arch_timer: Add basic ARMv8.6 support Date: Wed, 22 Sep 2021 22:19:25 +0100 [thread overview] Message-ID: <20210922211941.2756270-1-maz@kernel.org> (raw) This is v2 of the series enabling ARMv8.6 support for timer subsystem, and was prompted by a discussion with Oliver around the fact that an ARMv8.6 implementation must have a 1GHz counter, which leads to a number of things to break in the timer code: - the counter rollover can come pretty quickly as we only advertise a 56bit counter, - the maximum timer delta can be remarkably small, as we use the countdown interface which is limited to 32bit... Thankfully, there is a way out: we can compute the minimal width of the counter based on the guarantees that the architecture gives us, and we can use the 64bit comparator interface instead of the countdown to program the timer. Finally, we start making use of the ARMv8.6 ECV features by switching accesses to the counters to a self-synchronising register, removing the need for an ISB. Hopefully, implementations will *not* just stick an invisible ISB there... A side effect of the switch to CVAL is that XGene-1 breaks. I have added a workaround to keep it alive. I have added Oliver's original patch[0] to the series and tweaked a couple of things. Blame me if I broke anything. The whole things has been tested on Juno (sysreg + MMIO timers), XGene-1 (broken sysreg timers), FVP (FEAT_ECV, CNT*CTSS_EL0). * From v1: - New patch adding a bunch of BUILD_BUG()s for register accesses we don't expect. This makes subsequent patches much simpler. - New patch moving the ISBs for workaround in a way that makes more sense for the self-synchronising accessors. - Rework the XGene-1 workaround to rely solely on MIDR. - Split the CNTVCTSS trap handling in its own patch. - Rebased on 5.15-rc2 - Collected RBs, with thanks. [0] https://lore.kernel.org/r/20210807191428.3488948-1-oupton@google.com [1] https://lore.kernel.org/r/20210809152651.2297337-2-maz@kernel.org Marc Zyngier (15): clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors clocksource/arm_arch_timer: Extend write side of timer register accessors to u64 clocksource/arm_arch_timer: Move system register timer programming over to CVAL clocksource/arm_arch_timer: Move drop _tval from erratum function names clocksource/arm_arch_timer: Fix MMIO base address vs callback ordering issue clocksource/arm_arch_timer: Move MMIO timer programming over to CVAL clocksource/arm_arch_timer: Advertise 56bit timer to the core code clocksource/arm_arch_timer: Work around broken CVAL implementations clocksource/arm_arch_timer: Remove any trace of the TVAL programming interface clocksource/arm_arch_timer: Drop unnecessary ISB on CVAL programming clocksource/arch_arm_timer: Move workaround synchronisation around arm64: Add a capability for FEAT_ECV arm64: Add CNT{P,V}CTSS_EL0 alternatives to cnt{p,v}ct_el0 arm64: Add handling of CNTVCTSS traps Oliver Upton (1): clocksource/arm_arch_timer: Fix masking for high freq counters arch/arm/include/asm/arch_timer.h | 37 ++-- arch/arm64/include/asm/arch_timer.h | 78 +++++---- arch/arm64/include/asm/esr.h | 6 + arch/arm64/include/asm/sysreg.h | 3 + arch/arm64/kernel/cpufeature.c | 10 ++ arch/arm64/kernel/traps.c | 11 ++ arch/arm64/tools/cpucaps | 1 + drivers/clocksource/arm_arch_timer.c | 243 ++++++++++++++++----------- include/clocksource/arm_arch_timer.h | 2 +- 9 files changed, 245 insertions(+), 146 deletions(-) -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-09-22 21:19 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-22 21:19 Marc Zyngier [this message] 2021-09-22 21:19 ` [PATCH v2 00/16] clocksource/arm_arch_timer: Add basic ARMv8.6 support Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 01/16] clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 02/16] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 03/16] clocksource/arm_arch_timer: Extend write side of timer register accessors to u64 Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 04/16] clocksource/arm_arch_timer: Move system register timer programming over to CVAL Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 05/16] clocksource/arm_arch_timer: Move drop _tval from erratum function names Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 06/16] clocksource/arm_arch_timer: Fix MMIO base address vs callback ordering issue Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 07/16] clocksource/arm_arch_timer: Move MMIO timer programming over to CVAL Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 08/16] clocksource/arm_arch_timer: Advertise 56bit timer to the core code Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 09/16] clocksource/arm_arch_timer: Work around broken CVAL implementations Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 10/16] clocksource/arm_arch_timer: Remove any trace of the TVAL programming interface Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 11/16] clocksource/arm_arch_timer: Drop unnecessary ISB on CVAL programming Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 12/16] clocksource/arm_arch_timer: Fix masking for high freq counters Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 13/16] clocksource/arch_arm_timer: Move workaround synchronisation around Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 14/16] arm64: Add a capability for FEAT_ECV Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier 2021-09-29 16:03 ` Will Deacon 2021-09-29 16:03 ` Will Deacon 2021-09-30 7:42 ` Marc Zyngier 2021-09-30 7:42 ` Marc Zyngier 2021-09-30 8:30 ` Will Deacon 2021-09-30 8:30 ` Will Deacon 2021-09-22 21:19 ` [PATCH v2 15/16] arm64: Add CNT{P,V}CTSS_EL0 alternatives to cnt{p,v}ct_el0 Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 15/16] arm64: Add CNT{P, V}CTSS_EL0 alternatives to cnt{p, v}ct_el0 Marc Zyngier 2021-09-22 21:19 ` [PATCH v2 16/16] arm64: Add handling of CNTVCTSS traps Marc Zyngier 2021-09-22 21:19 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210922211941.2756270-1-maz@kernel.org \ --to=maz@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=kernel-team@android.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=oupton@google.com \ --cc=pshier@google.com \ --cc=rananta@google.com \ --cc=ricarkol@google.com \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.