From: <yipeng.chen@amd.com>
To: <harry.wentland@amd.com>, <sunpeng.li@amd.com>,
<alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<airlied@linux.ie>, <daniel@ffwll.ch>, <qingqing.zhuo@amd.com>,
<Aric.Cyr@amd.com>, <Anson.Jacob@amd.com>, <bindu.r@amd.com>,
<martin.tsai@amd.com>, <bing.guo@amd.com>, <roy.chan@amd.com>,
<george.shen@amd.com>, <joshua.aberback@amd.com>,
<Ashley.Thomas2@amd.com>, <Jing.Zhou@amd.com>,
<dale.zhao@amd.com>
Cc: <amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<ching-shih.li@amd.com>,
"Yipeng Chen (Jasber)" <yipeng.chen@amd.com>,
Roman Li <Roman.Li@amd.com>, Anthony Koo <Anthony.Koo@amd.com>
Subject: [PATCH v2] drm/amd/display: Fix randomly flicking on overlay with enabled ABM
Date: Fri, 24 Sep 2021 09:34:41 +0800 [thread overview]
Message-ID: <20210924013441.97128-1-yipeng.chen@amd.com> (raw)
From: "Yipeng Chen (Jasber)" <yipeng.chen@amd.com>
[Why]
Enabled ABM (level != 0) would raise short pulse irq DC_IRQ_SOURCE_HPD1RX
randomly with PSR error LINK_CRC_ERROR. Actually there is no hot plugging
on EDP panel. After correcting CRC error, there is no need to send drm
hotplug event.
[How]
Returning false would skip doing hot-plug when handle_hpd_irq_psr_sink()
handled irq. Hot-plug process causes visible flicking on overlay.
Signed-off-by: Yipeng Chen (Jasber) <yipeng.chen@amd.com>
Reviewed-by: Roman Li <Roman.Li@amd.com>
Reviewed-by: Anthony Koo <Anthony.Koo@amd.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 1e4794e2825c..9b9fbe5e9bd4 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -3007,7 +3007,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd
if (handle_hpd_irq_psr_sink(link))
/* PSR-related error was detected and handled */
- return true;
+ return false;
/* If PSR-related error handled, Main link may be off,
* so do not handle as a normal sink status change interrupt.
--
2.25.1
reply other threads:[~2021-09-24 1:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924013441.97128-1-yipeng.chen@amd.com \
--to=yipeng.chen@amd.com \
--cc=Anson.Jacob@amd.com \
--cc=Anthony.Koo@amd.com \
--cc=Aric.Cyr@amd.com \
--cc=Ashley.Thomas2@amd.com \
--cc=Jing.Zhou@amd.com \
--cc=Roman.Li@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bindu.r@amd.com \
--cc=bing.guo@amd.com \
--cc=ching-shih.li@amd.com \
--cc=christian.koenig@amd.com \
--cc=dale.zhao@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.shen@amd.com \
--cc=harry.wentland@amd.com \
--cc=joshua.aberback@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.tsai@amd.com \
--cc=qingqing.zhuo@amd.com \
--cc=roy.chan@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.