All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yanan Wang <wangyanan55@huawei.com>
To: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Andrew Jones" <drjones@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Pierre Morel <pmorel@linux.ibm.com>,
	Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
	Cornelia Huck <cohuck@redhat.com>,
	qemu-devel@nongnu.org, Yanan Wang <wangyanan55@huawei.com>,
	qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
	"Michael S . Tsirkin" <mst@redhat.com>,
	wanghaibin.wang@huawei.com, qemu-ppc@nongnu.org,
	Igor Mammedov <imammedo@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v11 07/14] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split
Date: Tue, 28 Sep 2021 11:57:48 +0800	[thread overview]
Message-ID: <20210928035755.11684-8-wangyanan55@huawei.com> (raw)
In-Reply-To: <20210928035755.11684-1-wangyanan55@huawei.com>

Since commit 80d7835749 (qemu-options: rewrite help for -smp options),
the preference of sockets/cores in -smp parsing is considered liable
to change, and actually we are going to change it in a coming commit.
So it'll be more stable to use detailed -smp CLIs in the testcases
that have strong dependency on the parsing results.

Currently, test_def_cpu_split use "-smp 8" and will get 8 CPU sockets
based on current parsing rule. But if we change to prefer cores over
sockets we will get one CPU socket with 8 cores, and this testcase
will not get expected numa set by default on x86_64 (Ok on aarch64).

So now explicitly use "-smp 8,sockets=8" to avoid affect from parsing
logic change.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
---
 tests/qtest/numa-test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/numa-test.c b/tests/qtest/numa-test.c
index fd7a2e80a0..90bf68a5b3 100644
--- a/tests/qtest/numa-test.c
+++ b/tests/qtest/numa-test.c
@@ -42,7 +42,8 @@ static void test_def_cpu_split(const void *data)
     g_autofree char *s = NULL;
     g_autofree char *cli = NULL;
 
-    cli = make_cli(data, "-machine smp.cpus=8 -numa node,memdev=ram -numa node");
+    cli = make_cli(data, "-machine smp.cpus=8,smp.sockets=8 "
+                         "-numa node,memdev=ram -numa node");
     qts = qtest_init(cli);
 
     s = qtest_hmp(qts, "info numa");
-- 
2.19.1



  parent reply	other threads:[~2021-09-28  4:04 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  3:57 [PATCH v11 00/14] machine: smp parsing fixes and improvement Yanan Wang
2021-09-28  3:57 ` [PATCH v11 01/14] machine: Deprecate "parameter=0" SMP configurations Yanan Wang
2021-09-28  9:58   ` Daniel P. Berrangé
2021-09-28 11:15     ` wangyanan (Y)
2021-09-28  3:57 ` [PATCH v11 02/14] machine: Minor refactor/fix for the smp parsers Yanan Wang
2021-09-28 10:06   ` Daniel P. Berrangé
2021-09-28  3:57 ` [PATCH v11 03/14] machine: Uniformly use maxcpus to calculate the omitted parameters Yanan Wang
2021-09-28 10:09   ` Daniel P. Berrangé
2021-09-28  3:57 ` [PATCH v11 04/14] machine: Set the value of cpus to match maxcpus if it's omitted Yanan Wang
2021-09-28 10:10   ` Daniel P. Berrangé
2021-09-28  3:57 ` [PATCH v11 05/14] machine: Improve the error reporting of smp parsing Yanan Wang
2021-09-28 10:13   ` Daniel P. Berrangé
2021-09-28 10:50   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 06/14] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_cpu_cfg Yanan Wang
2021-09-28 10:17   ` Daniel P. Berrangé
2021-09-28 10:51   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` Yanan Wang [this message]
2021-09-28 10:19   ` [PATCH v11 07/14] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split Daniel P. Berrangé
2021-09-28 10:51   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 08/14] machine: Prefer cores over sockets in smp parsing since 6.2 Yanan Wang
2021-09-28 10:21   ` Daniel P. Berrangé
2021-09-28  3:57 ` [PATCH v11 09/14] machine: Use ms instead of global current_machine in sanity-check Yanan Wang
2021-09-28 10:21   ` Daniel P. Berrangé
2021-09-28 10:52   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 10/14] machine: Tweak the order of topology members in struct CpuTopology Yanan Wang
2021-09-28 10:23   ` Daniel P. Berrangé
2021-09-28 10:58   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 11/14] machine: Make smp_parse generic enough for all arches Yanan Wang
2021-09-28 10:25   ` Daniel P. Berrangé
2021-09-28 10:57   ` Philippe Mathieu-Daudé
2021-09-28 10:58     ` Daniel P. Berrangé
2021-09-28 11:02       ` Philippe Mathieu-Daudé
2021-09-28 11:07       ` wangyanan (Y)
2021-09-28 12:25     ` Markus Armbruster
2021-09-28 12:53       ` wangyanan (Y)
2021-09-28  3:57 ` [PATCH v11 12/14] machine: Remove smp_parse callback from MachineClass Yanan Wang
2021-09-28 10:25   ` Daniel P. Berrangé
2021-09-28 10:58   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 13/14] machine: Move smp_prefer_sockets to struct SMPCompatProps Yanan Wang
2021-09-28 10:26   ` Daniel P. Berrangé
2021-09-28  3:57 ` [PATCH v11 14/14] machine: Put all sanity-check in the generic SMP parser Yanan Wang
2021-09-28 10:38   ` Daniel P. Berrangé
2021-09-28 11:01   ` Philippe Mathieu-Daudé
2021-09-28 11:20     ` wangyanan (Y)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210928035755.11684-8-wangyanan55@huawei.com \
    --to=wangyanan55@huawei.com \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=drjones@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pankaj.gupta.linux@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pmorel@linux.ibm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=wanghaibin.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.