From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: t.gummerer@gmail.com, avarab@gmail.com, pclouds@gmail.com,
jonathantanmy@google.com,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH 3/3] config.mak.dev: simplify compiler check for multiple compilers
Date: Tue, 28 Sep 2021 02:10:54 -0700 [thread overview]
Message-ID: <20210928091054.78895-4-carenas@gmail.com> (raw)
In-Reply-To: <20210928091054.78895-1-carenas@gmail.com>
1da1580e4c (Makefile: detect compiler and enable more warnings in
DEVELOPER=1, 2018-04-14), includes an $(or) of two different filters
to check for both gcc and clang versions.
As shown in a previous patch, a simpler syntax is available so apply
the same logic here also for consistency.
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
config.mak.dev | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config.mak.dev b/config.mak.dev
index 90c47d2782..b66fae8665 100644
--- a/config.mak.dev
+++ b/config.mak.dev
@@ -31,7 +31,7 @@ ifneq ($(filter clang4,$(COMPILER_FEATURES)),)
DEVELOPER_CFLAGS += -Wtautological-constant-out-of-range-compare
endif
-ifneq ($(or $(filter gcc6,$(COMPILER_FEATURES)),$(filter clang4,$(COMPILER_FEATURES))),)
+ifneq ($(filter clang4 gcc6,$(COMPILER_FEATURES)),)
DEVELOPER_CFLAGS += -Wextra
# if a function is public, there should be a prototype and the right
# header file should be included. If not, it should be static.
--
2.33.0.955.gee03ddbf0e
next prev parent reply other threads:[~2021-09-28 9:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 9:10 [PATCH 0/3] Makefile: tighten pedantic flag Carlo Marcelo Arenas Belón
2021-09-28 9:10 ` [PATCH 1/3] Makefile: restrict -Wpedantic and -Wno-pedantic-ms-format better Carlo Marcelo Arenas Belón
2021-09-28 11:46 ` Ævar Arnfjörð Bjarmason
2021-09-28 23:39 ` Junio C Hamano
2021-09-28 9:10 ` [PATCH 2/3] Makefile: avoid multiple -Wall in CFLAGS Carlo Marcelo Arenas Belón
2021-09-28 9:19 ` Ævar Arnfjörð Bjarmason
2021-09-28 11:03 ` Carlo Arenas
2021-09-28 21:19 ` Junio C Hamano
2021-09-28 23:22 ` Carlo Arenas
2021-09-29 4:08 ` Junio C Hamano
2021-09-28 9:10 ` Carlo Marcelo Arenas Belón [this message]
2021-09-28 12:07 ` [PATCH 3/3] config.mak.dev: simplify compiler check for multiple compilers Ævar Arnfjörð Bjarmason
2021-09-28 21:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928091054.78895-4-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=pclouds@gmail.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.