All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: linux-trace-devel@vger.kernel.org
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 3/5] trace-cruncher: Correct misleading error message
Date: Fri,  1 Oct 2021 16:33:44 +0300	[thread overview]
Message-ID: <20211001133346.8217-4-y.karadz@gmail.com> (raw)
In-Reply-To: <20211001133346.8217-1-y.karadz@gmail.com>

Indeed, the callback function can be included from a plugin, but this
is an option. In the default case it will be searched in '__main__'.

Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
 src/ftracepy-utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ftracepy-utils.c b/src/ftracepy-utils.c
index e49132d..b0f5e0e 100644
--- a/src/ftracepy-utils.c
+++ b/src/ftracepy-utils.c
@@ -2039,7 +2039,7 @@ static PyObject *get_callback_func(const char *plugin_name, const char * py_call
 	py_func = PyObject_GetAttrString(py_module, py_callback);
 	if (!py_func || !PyCallable_Check(py_func)) {
 		TfsError_fmt(NULL,
-			     "Failed to import callback from plugin \'%s\'",
+			     "Failed to import callback from \'%s\'",
 			     plugin_name);
 		return NULL;
 	}
-- 
2.30.2


  parent reply	other threads:[~2021-10-01 13:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 13:33 [PATCH 0/5] trace-cruncher: Improve error messages Yordan Karadzhov (VMware)
2021-10-01 13:33 ` [PATCH 1/5] trace-cruncher: Error on fail to destroy Yordan Karadzhov (VMware)
2021-10-01 13:33 ` [PATCH 2/5] trace-cruncher: Proper type name for the python objects Yordan Karadzhov (VMware)
2021-10-01 13:33 ` Yordan Karadzhov (VMware) [this message]
2021-10-01 13:33 ` [PATCH 4/5] trace-cruncher: Proper labeling of the libtracefs errors Yordan Karadzhov (VMware)
2021-10-01 13:33 ` [PATCH 5/5] trace-cruncher: Proper labeling of non " Yordan Karadzhov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001133346.8217-4-y.karadz@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.