From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>, Po Liu <po.liu@nxp.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Michael Walle <michael@walle.cc>, Rui Sousa <rui.sousa@nxp.com>,
Yangbo Lu <yangbo.lu@nxp.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
UNGLinuxDriver@microchip.com
Subject: [PATCH v2 net 00/10] Felix DSA driver fixes
Date: Tue, 12 Oct 2021 14:40:34 +0300 [thread overview]
Message-ID: <20211012114044.2526146-1-vladimir.oltean@nxp.com> (raw)
This is an assorted collection of fixes for issues seen on the NXP
LS1028A switch.
- PTP packet drops due to switch congestion result in catastrophic
damage to the driver's state
- loops are not blocked by STP if using the ocelot-8021q tagger
- driver uses the wrong CPU port when two of them are defined in DT
- module autoloading is broken* with both tagging protocol drivers
(ocelot and ocelot-8021q)
*I did notice that a similar fix but for a different driver did get
applied to "net-next" instead of "net" despite my deliberate targeting
of the branch that goes towards "stable". I don't know why, it is an
issue that is really bothering some people.
https://patchwork.kernel.org/project/netdevbpf/cover/20210922143726.2431036-1-vladimir.oltean@nxp.com/
Changes in v2:
- Stop printing that we aren't going to take TX timestamps if we don't
have TX timestamping anyway, and we are just carrying PTP frames for a
cascaded DSA switch.
- Shorten the deferred xmit kthread name so that it fits the 16
character limit (TASK_COMM_LEN)
Vladimir Oltean (10):
net: mscc: ocelot: make use of all 63 PTP timestamp identifiers
net: mscc: ocelot: avoid overflowing the PTP timestamp FIFO
net: mscc: ocelot: warn when a PTP IRQ is raised for an unknown skb
net: mscc: ocelot: deny TX timestamping of non-PTP packets
net: mscc: ocelot: cross-check the sequence id from the timestamp FIFO
with the skb PTP header
net: dsa: tag_ocelot: break circular dependency with ocelot switch lib
driver
net: dsa: tag_ocelot_8021q: break circular dependency with ocelot
switch lib
net: dsa: felix: purge skb from TX timestamping queue if it cannot be
sent
net: dsa: tag_ocelot_8021q: fix inability to inject STP BPDUs into
BLOCKING ports
net: dsa: felix: break at first CPU port during init and teardown
drivers/net/dsa/ocelot/felix.c | 149 +++++++++++++++++++++++--
drivers/net/dsa/ocelot/felix.h | 1 +
drivers/net/ethernet/mscc/ocelot.c | 103 +++++++++++------
drivers/net/ethernet/mscc/ocelot_net.c | 1 +
include/linux/dsa/ocelot.h | 49 ++++++++
include/soc/mscc/ocelot.h | 55 +--------
include/soc/mscc/ocelot_ptp.h | 3 +
net/dsa/Kconfig | 4 -
net/dsa/tag_ocelot.c | 1 -
net/dsa/tag_ocelot_8021q.c | 40 ++++---
10 files changed, 291 insertions(+), 115 deletions(-)
--
2.25.1
next reply other threads:[~2021-10-12 11:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 11:40 Vladimir Oltean [this message]
2021-10-12 11:40 ` [PATCH v2 net 01/10] net: mscc: ocelot: make use of all 63 PTP timestamp identifiers Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 02/10] net: mscc: ocelot: avoid overflowing the PTP timestamp FIFO Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 03/10] net: mscc: ocelot: warn when a PTP IRQ is raised for an unknown skb Vladimir Oltean
2021-10-12 21:41 ` Florian Fainelli
2021-10-12 11:40 ` [PATCH v2 net 04/10] net: mscc: ocelot: deny TX timestamping of non-PTP packets Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 05/10] net: mscc: ocelot: cross-check the sequence id from the timestamp FIFO with the skb PTP header Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 06/10] net: dsa: tag_ocelot: break circular dependency with ocelot switch lib driver Vladimir Oltean
2021-10-12 21:32 ` Florian Fainelli
2021-10-12 11:40 ` [PATCH v2 net 07/10] net: dsa: tag_ocelot_8021q: break circular dependency with ocelot switch lib Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 08/10] net: dsa: felix: purge skb from TX timestamping queue if it cannot be sent Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 09/10] net: dsa: tag_ocelot_8021q: fix inability to inject STP BPDUs into BLOCKING ports Vladimir Oltean
2021-10-12 21:42 ` Florian Fainelli
2021-10-12 11:40 ` [PATCH v2 net 10/10] net: dsa: felix: break at first CPU port during init and teardown Vladimir Oltean
2021-10-12 21:31 ` Florian Fainelli
2021-10-13 2:40 ` [PATCH v2 net 00/10] Felix DSA driver fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012114044.2526146-1-vladimir.oltean@nxp.com \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=po.liu@nxp.com \
--cc=rui.sousa@nxp.com \
--cc=vivien.didelot@gmail.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.