From: Shayne Chen <shayne.chen@mediatek.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
"Evelyn Tsai" <evelyn.tsai@mediatek.com>,
linux-mediatek <linux-mediatek@lists.infradead.org>,
Shayne Chen <shayne.chen@mediatek.com>
Subject: [PATCH v6 6/8] mt76: mt7915: fix muar_idx in mt7915_mcu_alloc_sta_req()
Date: Fri, 15 Oct 2021 11:29:36 +0800 [thread overview]
Message-ID: <20211015032938.7493-6-shayne.chen@mediatek.com> (raw)
In-Reply-To: <20211015032938.7493-1-shayne.chen@mediatek.com>
For broadcast/multicast wcid, the muar_idx should be 0xe.
Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
---
v6: remove line break of fix tag
---
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
index cd31cb1..9ad7e8e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
@@ -586,7 +586,7 @@ mt7915_mcu_alloc_sta_req(struct mt7915_dev *dev, struct mt7915_vif *mvif,
.bss_idx = mvif->idx,
.wlan_idx_lo = msta ? to_wcid_lo(msta->wcid.idx) : 0,
.wlan_idx_hi = msta ? to_wcid_hi(msta->wcid.idx) : 0,
- .muar_idx = msta ? mvif->omac_idx : 0,
+ .muar_idx = msta && msta->wcid.sta ? mvif->omac_idx : 0xe,
.is_tlv_append = 1,
};
struct sk_buff *skb;
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Shayne Chen <shayne.chen@mediatek.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
"Evelyn Tsai" <evelyn.tsai@mediatek.com>,
linux-mediatek <linux-mediatek@lists.infradead.org>,
Shayne Chen <shayne.chen@mediatek.com>
Subject: [PATCH v6 6/8] mt76: mt7915: fix muar_idx in mt7915_mcu_alloc_sta_req()
Date: Fri, 15 Oct 2021 11:29:36 +0800 [thread overview]
Message-ID: <20211015032938.7493-6-shayne.chen@mediatek.com> (raw)
In-Reply-To: <20211015032938.7493-1-shayne.chen@mediatek.com>
For broadcast/multicast wcid, the muar_idx should be 0xe.
Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
---
v6: remove line break of fix tag
---
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
index cd31cb1..9ad7e8e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
@@ -586,7 +586,7 @@ mt7915_mcu_alloc_sta_req(struct mt7915_dev *dev, struct mt7915_vif *mvif,
.bss_idx = mvif->idx,
.wlan_idx_lo = msta ? to_wcid_lo(msta->wcid.idx) : 0,
.wlan_idx_hi = msta ? to_wcid_hi(msta->wcid.idx) : 0,
- .muar_idx = msta ? mvif->omac_idx : 0,
+ .muar_idx = msta && msta->wcid.sta ? mvif->omac_idx : 0xe,
.is_tlv_append = 1,
};
struct sk_buff *skb;
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-10-15 3:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 3:29 [PATCH v6 1/8] mt76: mt7915: introduce mt7915_mcu_beacon_check_caps() Shayne Chen
2021-10-15 3:29 ` Shayne Chen
2021-10-15 3:29 ` [PATCH v6 2/8] mt76: mt7915: fix txbf starec TLV issues Shayne Chen
2021-10-15 3:29 ` Shayne Chen
2021-10-15 3:29 ` [PATCH v6 3/8] mt76: mt7915: improve starec readability of txbf Shayne Chen
2021-10-15 3:29 ` Shayne Chen
2021-10-15 3:29 ` [PATCH v6 4/8] mt76: mt7915: fix sta_rec_wtbl tag len Shayne Chen
2021-10-15 3:29 ` Shayne Chen
2021-10-15 3:29 ` [PATCH v6 5/8] mt76: mt7915: rework starec TLV tags Shayne Chen
2021-10-15 3:29 ` Shayne Chen
2021-10-15 3:29 ` Shayne Chen [this message]
2021-10-15 3:29 ` [PATCH v6 6/8] mt76: mt7915: fix muar_idx in mt7915_mcu_alloc_sta_req() Shayne Chen
2021-10-15 3:29 ` [PATCH v6 7/8] mt76: mt7915: set VTA bit in tx descriptor Shayne Chen
2021-10-15 3:29 ` Shayne Chen
2021-10-15 3:29 ` [PATCH v6 8/8] mt76: mt7915: set muru platform type Shayne Chen
2021-10-15 3:29 ` Shayne Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015032938.7493-6-shayne.chen@mediatek.com \
--to=shayne.chen@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.