All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huacai Chen <chenhuacai@loongson.cn>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Xuefeng Li <lixuefeng@loongson.cn>,
	Huacai Chen <chenhuacai@gmail.com>,
	Huacai Chen <chenhuacai@loongson.cn>
Subject: [PATCH V7 03/11] PCI/VGA: Split out vga_arb_update_default_device()
Date: Fri, 15 Oct 2021 14:15:04 +0800	[thread overview]
Message-ID: <20211015061512.2941859-4-chenhuacai@loongson.cn> (raw)
In-Reply-To: <20211015061512.2941859-1-chenhuacai@loongson.cn>

This patch is the first step of the rework: If there's no default VGA
device, and we find a VGA device that owns the legacy VGA resources, we
make that device the default. Split this logic out from vga_arbiter_add_
pci_device() into a new function, vga_arb_update_default_device().

Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/gpu/vga/vgaarb.c | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
index 29e725ebaa43..f8f95244d499 100644
--- a/drivers/gpu/vga/vgaarb.c
+++ b/drivers/gpu/vga/vgaarb.c
@@ -579,6 +579,21 @@ static bool vga_arb_integrated_gpu(struct device *dev)
 }
 #endif
 
+static void vga_arb_update_default_device(struct vga_device *vgadev)
+{
+	struct pci_dev *pdev = vgadev->pdev;
+
+	/*
+	 * If we don't have a default VGA device yet, and this device owns
+	 * the legacy VGA resources, make it the default.
+	 */
+	if (!vga_default_device() &&
+	    ((vgadev->owns & VGA_RSRC_LEGACY_MASK) == VGA_RSRC_LEGACY_MASK)) {
+		vgaarb_info(&pdev->dev, "setting as boot VGA device\n");
+		vga_set_default_device(pdev);
+	}
+}
+
 /*
  * Rules for using a bridge to control a VGA descendant decoding: if a bridge
  * has only one VGA descendant then it can be used to control the VGA routing
@@ -706,15 +721,7 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev)
 		bus = bus->parent;
 	}
 
-	/* Deal with VGA default device. Use first enabled one
-	 * by default if arch doesn't have it's own hook
-	 */
-	if (!vga_default_device() &&
-	    ((vgadev->owns & VGA_RSRC_LEGACY_MASK) == VGA_RSRC_LEGACY_MASK)) {
-		vgaarb_info(&pdev->dev, "setting as boot VGA device\n");
-		vga_set_default_device(pdev);
-	}
-
+	vga_arb_update_default_device(vgadev);
 	vga_arbiter_check_bridge_sharing(vgadev);
 
 	/* Add to the list */
-- 
2.27.0


  parent reply	other threads:[~2021-10-15  6:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  6:15 [PATCH V7 00/11] PCI/VGA: Rework default VGA device selection Huacai Chen
2021-10-15  6:15 ` [PATCH V7 01/11] PCI/VGA: Prefer vga_default_device() Huacai Chen
2021-10-15  6:15 ` [PATCH V7 02/11] PCI/VGA: Move vga_arb_integrated_gpu() earlier in file Huacai Chen
2021-10-15  6:15 ` Huacai Chen [this message]
2021-10-15  6:15 ` [PATCH V7 04/11] PCI/VGA: Prefer VGA device with legacy I/O enabled Huacai Chen
2021-10-15  6:15 ` [PATCH V7 05/11] PCI/VGA: Prefer VGA device belongs to integrated GPU Huacai Chen
2021-10-15  6:15 ` [PATCH V7 06/11] PCI/VGA: Prefer VGA device owns the firmware framebuffer Huacai Chen
2021-10-15  6:15 ` [PATCH V7 07/11] PCI/VGA: Remove vga_arb_select_default_device() Huacai Chen
2021-10-15  6:15 ` [PATCH V7 08/11] PCI/VGA: Remove empty vga_arb_device_card_gone() Huacai Chen
2021-10-15  6:58 ` [PATCH V7 09/11] PCI/VGA: Log bridge control messages when adding devices Huacai Chen
2021-10-15  6:58   ` [PATCH V7 10/11] PCI/VGA: Use unsigned format string to print lock counts Huacai Chen
2021-10-15  6:58   ` [PATCH V7 11/11] PCI/VGA: Replace full MIT license text with SPDX identifier Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015061512.2941859-4-chenhuacai@loongson.cn \
    --to=chenhuacai@loongson.cn \
    --cc=airlied@linux.ie \
    --cc=bhelgaas@google.com \
    --cc=chenhuacai@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.