All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, lukasz.luba@arm.com,
	sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com,
	linux@armlinux.org.uk, gregkh@linuxfoundation.org,
	rafael@kernel.org, viresh.kumar@linaro.org, amitk@kernel.org,
	daniel.lezcano@linaro.org, amit.kachhap@gmail.com,
	thara.gopinath@linaro.org, bjorn.andersson@linaro.org,
	agross@kernel.org
Subject: [PATCH v2 2/5] thermal: cpufreq_cooling: Use new thermal pressure update function
Date: Fri, 15 Oct 2021 15:45:47 +0100	[thread overview]
Message-ID: <20211015144550.23719-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20211015144550.23719-1-lukasz.luba@arm.com>

Thermal pressure provides a new API, which allows to use CPU frequency
as an argument. That removes the need of local conversion to capacity.
Use this new function and remove old conversion code.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 drivers/thermal/cpufreq_cooling.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
index 43b1ae8a7789..835c091ce818 100644
--- a/drivers/thermal/cpufreq_cooling.c
+++ b/drivers/thermal/cpufreq_cooling.c
@@ -462,7 +462,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
 	struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata;
 	struct cpumask *cpus;
 	unsigned int frequency;
-	unsigned long max_capacity, capacity;
 	int ret;
 
 	/* Request state should be less than max_level */
@@ -479,10 +478,7 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
 	if (ret >= 0) {
 		cpufreq_cdev->cpufreq_state = state;
 		cpus = cpufreq_cdev->policy->related_cpus;
-		max_capacity = arch_scale_cpu_capacity(cpumask_first(cpus));
-		capacity = frequency * max_capacity;
-		capacity /= cpufreq_cdev->policy->cpuinfo.max_freq;
-		arch_set_thermal_pressure(cpus, max_capacity - capacity);
+		arch_thermal_pressure_update(cpus, frequency);
 		ret = 0;
 	}
 
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, lukasz.luba@arm.com,
	sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com,
	linux@armlinux.org.uk, gregkh@linuxfoundation.org,
	rafael@kernel.org, viresh.kumar@linaro.org, amitk@kernel.org,
	daniel.lezcano@linaro.org, amit.kachhap@gmail.com,
	thara.gopinath@linaro.org, bjorn.andersson@linaro.org,
	agross@kernel.org
Subject: [PATCH v2 2/5] thermal: cpufreq_cooling: Use new thermal pressure update function
Date: Fri, 15 Oct 2021 15:45:47 +0100	[thread overview]
Message-ID: <20211015144550.23719-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20211015144550.23719-1-lukasz.luba@arm.com>

Thermal pressure provides a new API, which allows to use CPU frequency
as an argument. That removes the need of local conversion to capacity.
Use this new function and remove old conversion code.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 drivers/thermal/cpufreq_cooling.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
index 43b1ae8a7789..835c091ce818 100644
--- a/drivers/thermal/cpufreq_cooling.c
+++ b/drivers/thermal/cpufreq_cooling.c
@@ -462,7 +462,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
 	struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata;
 	struct cpumask *cpus;
 	unsigned int frequency;
-	unsigned long max_capacity, capacity;
 	int ret;
 
 	/* Request state should be less than max_level */
@@ -479,10 +478,7 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
 	if (ret >= 0) {
 		cpufreq_cdev->cpufreq_state = state;
 		cpus = cpufreq_cdev->policy->related_cpus;
-		max_capacity = arch_scale_cpu_capacity(cpumask_first(cpus));
-		capacity = frequency * max_capacity;
-		capacity /= cpufreq_cdev->policy->cpuinfo.max_freq;
-		arch_set_thermal_pressure(cpus, max_capacity - capacity);
+		arch_thermal_pressure_update(cpus, frequency);
 		ret = 0;
 	}
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-10-15 14:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15 14:45 [PATCH v2 0/5] Refactor thermal pressure update to avoid code duplication Lukasz Luba
2021-10-15 14:45 ` Lukasz Luba
2021-10-15 14:45 ` [PATCH v2 1/5] arch_topology: Introduce thermal pressure update function Lukasz Luba
2021-10-15 14:45   ` Lukasz Luba
2021-10-26 16:51   ` Dietmar Eggemann
2021-10-26 16:51     ` Dietmar Eggemann
2021-10-27  8:56     ` Lukasz Luba
2021-10-27  8:56       ` Lukasz Luba
2021-10-27 13:35       ` Dietmar Eggemann
2021-10-27 13:35         ` Dietmar Eggemann
2021-10-27 18:43   ` Bjorn Andersson
2021-10-27 18:43     ` Bjorn Andersson
2021-10-28  7:16     ` Lukasz Luba
2021-10-28  7:16       ` Lukasz Luba
2021-10-28 23:12       ` Bjorn Andersson
2021-10-28 23:12         ` Bjorn Andersson
2021-10-28  5:44   ` Viresh Kumar
2021-10-28  5:44     ` Viresh Kumar
2021-10-28  7:19     ` Lukasz Luba
2021-10-28  7:19       ` Lukasz Luba
2021-10-15 14:45 ` Lukasz Luba [this message]
2021-10-15 14:45   ` [PATCH v2 2/5] thermal: cpufreq_cooling: Use new " Lukasz Luba
2021-10-26 16:51   ` Dietmar Eggemann
2021-10-26 16:51     ` Dietmar Eggemann
2021-10-27  9:00     ` Lukasz Luba
2021-10-27  9:00       ` Lukasz Luba
2021-10-15 14:45 ` [PATCH v2 3/5] cpufreq: qcom-cpufreq-hw: Update offline CPUs per-cpu thermal pressure Lukasz Luba
2021-10-15 14:45   ` Lukasz Luba
2021-10-15 14:45 ` [PATCH v2 4/5] cpufreq: qcom-cpufreq-hw: Use new thermal pressure update function Lukasz Luba
2021-10-15 14:45   ` Lukasz Luba
2021-10-15 14:45 ` [PATCH v2 5/5] arch_topology: Remove unused topology_set_thermal_pressure() and related Lukasz Luba
2021-10-15 14:45   ` Lukasz Luba
2021-10-25 16:43 ` [PATCH v2 0/5] Refactor thermal pressure update to avoid code duplication Lukasz Luba
2021-10-25 16:43   ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015144550.23719-3-lukasz.luba@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=agross@kernel.org \
    --cc=amit.kachhap@gmail.com \
    --cc=amitk@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=rafael@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=thara.gopinath@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.