From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Menzel <pmenzel@molgen.mpg.de>,
"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>
Subject: [PATCH 0/2] KVM: x86: Enhance vendor module error messages
Date: Mon, 18 Oct 2021 11:39:27 -0700 [thread overview]
Message-ID: <20211018183929.897461-1-seanjc@google.com> (raw)
Paul Menzel encountered the bad userspace behavior of spamming KVM module
loading on all CPUs, which was mitigated by commit ef935c25fd64 ("kvm: x86:
Limit the number of "kvm: disabled by bios" messages"), except this time
userspace is extra "clever" and spams both kvm_intel and kvm_amd. Because
the "already loaded the other module" message isn't ratelimited, the bogus
module load managed to spam the kernel log.
Patch 1 addresses another suggestion from Paul by incorporating the vendor
module name into the error messages.
Patch 2 addresses the original report by prioritizing the hardware/bios
support messages over the "already loaded" error. In additional to
reducing spam, doing so also ensures consistent messaging if a vendor
module isn't supported regardless of what other modules may be loaded.
[*] https://lkml.kernel.org/r/20210818114956.7171-1-pmenzel@molgen.mpg.de
Sean Christopherson (2):
KVM: x86: Add vendor name to kvm_x86_ops, use it for error messages
KVM: x86: Defer "already loaded" check until after basic support
checks
arch/x86/include/asm/kvm_host.h | 2 ++
arch/x86/kvm/svm/svm.c | 2 ++
arch/x86/kvm/vmx/vmx.c | 2 ++
arch/x86/kvm/x86.c | 17 +++++++++--------
4 files changed, 15 insertions(+), 8 deletions(-)
--
2.33.0.1079.g6e70778dc9-goog
next reply other threads:[~2021-10-18 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 18:39 Sean Christopherson [this message]
2021-10-18 18:39 ` [PATCH 1/2] KVM: x86: Add vendor name to kvm_x86_ops, use it for error messages Sean Christopherson
2021-10-21 8:08 ` Vitaly Kuznetsov
2021-10-21 17:48 ` Sean Christopherson
2021-10-22 6:33 ` Vitaly Kuznetsov
2021-10-18 18:39 ` [PATCH 2/2] KVM: x86: Defer "already loaded" check until after basic support checks Sean Christopherson
2021-10-20 14:55 ` [PATCH 0/2] KVM: x86: Enhance vendor module error messages Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018183929.897461-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=pbonzini@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.