All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olga Kornievskaia <olga.kornievskaia@gmail.com>
To: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
	steved@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 1/7] NFSv4.2 add tracepoint to SEEK
Date: Mon, 18 Oct 2021 18:03:08 -0400	[thread overview]
Message-ID: <20211018220314.85115-2-olga.kornievskaia@gmail.com> (raw)
In-Reply-To: <20211018220314.85115-1-olga.kornievskaia@gmail.com>

From: Olga Kornievskaia <kolga@netapp.com>

Add a tracepoint to the SEEK operation.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
 fs/nfs/nfs42proc.c |  1 +
 fs/nfs/nfs4trace.h | 65 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)

diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
index a24349512ffe..87c0dcb8823b 100644
--- a/fs/nfs/nfs42proc.c
+++ b/fs/nfs/nfs42proc.c
@@ -678,6 +678,7 @@ static loff_t _nfs42_proc_llseek(struct file *filep,
 
 	status = nfs4_call_sync(server->client, server, &msg,
 				&args.seq_args, &res.seq_res, 0);
+	trace_nfs4_llseek(inode, &args, &res, status);
 	if (status == -ENOTSUPP)
 		server->caps &= ~NFS_CAP_SEEK;
 	if (status)
diff --git a/fs/nfs/nfs4trace.h b/fs/nfs/nfs4trace.h
index 7a2567aa2b86..81dcbfca7f74 100644
--- a/fs/nfs/nfs4trace.h
+++ b/fs/nfs/nfs4trace.h
@@ -2417,6 +2417,71 @@ TRACE_EVENT(ff_layout_commit_error,
 		)
 );
 
+TRACE_DEFINE_ENUM(NFS4_CONTENT_DATA);
+TRACE_DEFINE_ENUM(NFS4_CONTENT_HOLE);
+
+#define show_llseek_mode(what)			\
+	__print_symbolic(what,			\
+		{ NFS4_CONTENT_DATA, "DATA" },		\
+		{ NFS4_CONTENT_HOLE, "HOLE" })
+
+TRACE_EVENT(nfs4_llseek,
+		TP_PROTO(
+			const struct inode *inode,
+			const struct nfs42_seek_args *args,
+			const struct nfs42_seek_res *res,
+			int error
+		),
+
+		TP_ARGS(inode, args, res, error),
+
+		TP_STRUCT__entry(
+			__field(unsigned long, error)
+			__field(u32, fhandle)
+			__field(u32, fileid)
+			__field(dev_t, dev)
+			__field(int, stateid_seq)
+			__field(u32, stateid_hash)
+			__field(loff_t, offset_s)
+			__field(u32, what)
+			__field(loff_t, offset_r)
+			__field(u32, eof)
+		),
+
+		TP_fast_assign(
+			const struct nfs_inode *nfsi = NFS_I(inode);
+			const struct nfs_fh *fh = args->sa_fh;
+
+			__entry->fileid = nfsi->fileid;
+			__entry->dev = inode->i_sb->s_dev;
+			__entry->fhandle = nfs_fhandle_hash(fh);
+			__entry->offset_s = args->sa_offset;
+			__entry->error = error < 0 ? -error : 0;
+			__entry->stateid_seq =
+				be32_to_cpu(args->sa_stateid.seqid);
+			__entry->stateid_hash =
+				nfs_stateid_hash(&args->sa_stateid);
+			__entry->what = args->sa_what;
+			__entry->offset_r = error < 0 ? 0 : res->sr_offset;
+			__entry->eof = error < 0 ? 0 : res->sr_eof;
+		),
+
+		TP_printk(
+			"error=%ld (%s) fileid=%02x:%02x:%llu fhandle=0x%08x "
+			"stateid=%d:0x%08x offset_s=%llu what=%s "
+			"offset_r=%llu eof=%u",
+			-__entry->error,
+			show_nfsv4_errors(__entry->error),
+			MAJOR(__entry->dev), MINOR(__entry->dev),
+			(unsigned long long)__entry->fileid,
+			__entry->fhandle,
+			__entry->stateid_seq, __entry->stateid_hash,
+			__entry->offset_s,
+			show_llseek_mode(__entry->what),
+			__entry->offset_r,
+			__entry->eof
+		)
+);
 
 #endif /* CONFIG_NFS_V4_1 */
 
-- 
2.27.0


  reply	other threads:[~2021-10-18 22:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 22:03 [PATCH 0/7] NFSv4.2 add tracepoints to sparse files and copy Olga Kornievskaia
2021-10-18 22:03 ` Olga Kornievskaia [this message]
2021-10-19 17:08   ` [PATCH 1/7] NFSv4.2 add tracepoint to SEEK Anna Schumaker
2021-10-27  7:50   ` kernel test robot
2021-10-27  7:50     ` kernel test robot
2021-10-18 22:03 ` [PATCH 2/7] NFSv4.2 add tracepoints to FALLOCATE and DEALLOCATE Olga Kornievskaia
2021-10-27 11:14   ` kernel test robot
2021-10-18 22:03 ` [PATCH 3/7] NFSv4.2 add tracepoint to COPY Olga Kornievskaia
2021-10-19 15:31   ` Chuck Lever III
2021-10-19 15:51     ` Olga Kornievskaia
2021-10-19 16:01       ` Chuck Lever III
2021-10-27 14:28   ` kernel test robot
2021-10-27 14:28     ` kernel test robot
2021-10-18 22:03 ` [PATCH 4/7] NFSv4.2 add tracepoint to CLONE Olga Kornievskaia
2021-10-18 22:03 ` [PATCH 5/7] NFSv4.2 add tracepoint to CB_OFFLOAD Olga Kornievskaia
2021-10-19 15:16   ` Chuck Lever III
2021-10-19 16:01     ` Olga Kornievskaia
2021-10-19 16:35       ` Chuck Lever III
2021-10-18 22:03 ` [PATCH 6/7] NFSv4.2 add tracepoint to COPY_NOTIFY Olga Kornievskaia
2021-10-18 22:03 ` [PATCH 7/7] NFSv4.2 add tracepoint to OFFLOAD_CANCEL Olga Kornievskaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211018220314.85115-2-olga.kornievskaia@gmail.com \
    --to=olga.kornievskaia@gmail.com \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.