All of lore.kernel.org
 help / color / mirror / Atom feed
From: wangyugui <wangyugui@e16-tech.com>
To: linux-rdma@vger.kernel.org
Cc: selvin.xavier@broadcom.com, eddie.wai@broadcom.com,
	wangyugui@e16-tech.com
Subject: [PATCH] infiniband: change some kmalloc to kvmalloc to support CONFIG_PROVE_LOCKING=y
Date: Tue, 19 Oct 2021 08:26:56 +0800	[thread overview]
Message-ID: <20211019002656.17745-1-wangyugui@e16-tech.com> (raw)

When CONFIG_PROVE_LOCKING=y, one kmalloc of infiniband hit the max alloc size limitation.

WARNING: CPU: 36 PID: 8 at mm/page_alloc.c:5350 __alloc_pages+0x27e/0x3e0
 Call Trace:
  kmalloc_order+0x2a/0xb0
  kmalloc_order_trace+0x19/0xf0
  __kmalloc+0x231/0x270
  ib_setup_port_attrs+0xd8/0x870 [ib_core]
  ib_register_device+0x419/0x4e0 [ib_core]
  bnxt_re_task+0x208/0x2d0 [bnxt_re]

change this kmalloc to kvmalloc to support CONFIG_PROVE_LOCKING=y

Signed-off-by: wangyugui <wangyugui@e16-tech.com>
---
 drivers/infiniband/core/sysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index 6146c3c1cbe5..8d709986b88c 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -757,7 +757,7 @@ static void ib_port_release(struct kobject *kobj)
 	if (port->hw_stats_data)
 		kfree(port->hw_stats_data->stats);
 	kfree(port->hw_stats_data);
-	kfree(port);
+	kvfree(port);
 }
 
 static void ib_port_gid_attr_release(struct kobject *kobj)
@@ -1189,7 +1189,7 @@ static struct ib_port *setup_port(struct ib_core_device *coredev, int port_num,
 	struct ib_port *p;
 	int ret;
 
-	p = kzalloc(struct_size(p, attrs_list,
+	p = kvzalloc(struct_size(p, attrs_list,
 				attr->gid_tbl_len + attr->pkey_tbl_len),
 		    GFP_KERNEL);
 	if (!p)
-- 
2.32.0


             reply	other threads:[~2021-10-19  0:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19  0:26 wangyugui [this message]
2021-10-19 11:37 ` [PATCH] infiniband: change some kmalloc to kvmalloc to support CONFIG_PROVE_LOCKING=y Jason Gunthorpe
2021-10-19 12:43   ` Wang Yugui
2021-10-20 23:03 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019002656.17745-1-wangyugui@e16-tech.com \
    --to=wangyugui@e16-tech.com \
    --cc=eddie.wai@broadcom.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=selvin.xavier@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.