All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Shuah Khan <shuah@kernel.org>
Cc: Alan Hayward <alan.hayward@arm.com>,
	Luis Machado <luis.machado@arm.com>,
	Salil Akerkar <Salil.Akerkar@arm.com>,
	Basant Kumar Dwivedi <Basant.KumarDwivedi@arm.com>,
	Szabolcs Nagy <szabolcs.nagy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH v3 23/42] arm64/sme: Implement support for TPIDR2
Date: Tue, 19 Oct 2021 18:22:28 +0100	[thread overview]
Message-ID: <20211019172247.3045838-24-broonie@kernel.org> (raw)
In-Reply-To: <20211019172247.3045838-1-broonie@kernel.org>

The Scalable Matrix Extension introduces support for a new thread specific
data register TPIDR2 intended for use by libc. The kernel must save the
value of TPIDR2 on context switch and should ensure that all new threads
start off with a default value of 0. Add a field to the thread_struct to
store TPIDR2 and context switch it with the other thread specific data.

In case there are future extensions which also use TPIDR2 we introduce
system_supports_tpidr2() and use that rather than system_supports_sme()
for TPIDR2 handling.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/include/asm/cpufeature.h |  5 +++++
 arch/arm64/include/asm/processor.h  |  1 +
 arch/arm64/kernel/fpsimd.c          |  4 ++++
 arch/arm64/kernel/process.c         | 14 ++++++++++++--
 4 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h
index 9a183267b341..8d0cff410b40 100644
--- a/arch/arm64/include/asm/cpufeature.h
+++ b/arch/arm64/include/asm/cpufeature.h
@@ -740,6 +740,11 @@ static __always_inline bool system_supports_sme(void)
 		cpus_have_const_cap(ARM64_SME);
 }
 
+static __always_inline bool system_supports_tpidr2(void)
+{
+	return system_supports_sme();
+}
+
 static __always_inline bool system_supports_cnp(void)
 {
 	return IS_ENABLED(CONFIG_ARM64_CNP) &&
diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
index a62d2f8045bf..51eca2513cb5 100644
--- a/arch/arm64/include/asm/processor.h
+++ b/arch/arm64/include/asm/processor.h
@@ -168,6 +168,7 @@ struct thread_struct {
 	u64			mte_ctrl;
 #endif
 	u64			sctlr_user;
+	u64			tpidr2_el0;
 };
 
 static inline unsigned int thread_get_vl(struct thread_struct *thread,
diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
index 96780b6821b6..a619ce38eddc 100644
--- a/arch/arm64/kernel/fpsimd.c
+++ b/arch/arm64/kernel/fpsimd.c
@@ -1101,6 +1101,10 @@ void sme_kernel_enable(const struct arm64_cpu_capabilities *__always_unused p)
 	/* Allow SME in kernel */
 	write_sysreg(read_sysreg(CPACR_EL1) | CPACR_EL1_SMEN_EL1EN, CPACR_EL1);
 	isb();
+
+	/* Allow EL0 to access TPIDR2 */
+	write_sysreg(read_sysreg(SCTLR_EL1) | SCTLR_ELx_ENTP2, SCTLR_EL1);
+	isb();
 }
 
 /*
diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index 40adb8cdbf5a..3f4279ad68bc 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -249,6 +249,8 @@ void show_regs(struct pt_regs *regs)
 static void tls_thread_flush(void)
 {
 	write_sysreg(0, tpidr_el0);
+	if (system_supports_tpidr2())
+		write_sysreg_s(0, SYS_TPIDR2_EL0);
 
 	if (is_compat_task()) {
 		current->thread.uw.tp_value = 0;
@@ -342,6 +344,8 @@ int copy_thread(unsigned long clone_flags, unsigned long stack_start,
 		 * out-of-sync with the saved value.
 		 */
 		*task_user_tls(p) = read_sysreg(tpidr_el0);
+		if (system_supports_tpidr2())
+			p->thread.tpidr2_el0 = read_sysreg_s(SYS_TPIDR2_EL0);
 
 		if (stack_start) {
 			if (is_compat_thread(task_thread_info(p)))
@@ -352,10 +356,12 @@ int copy_thread(unsigned long clone_flags, unsigned long stack_start,
 
 		/*
 		 * If a TLS pointer was passed to clone, use it for the new
-		 * thread.
+		 * thread.  We also reset TPIDR2 if it's in use.
 		 */
-		if (clone_flags & CLONE_SETTLS)
+		if (clone_flags & CLONE_SETTLS) {
 			p->thread.uw.tp_value = tls;
+			p->thread.tpidr2_el0 = 0;
+		}
 	} else {
 		/*
 		 * A kthread has no context to ERET to, so ensure any buggy
@@ -386,6 +392,8 @@ int copy_thread(unsigned long clone_flags, unsigned long stack_start,
 void tls_preserve_current_state(void)
 {
 	*task_user_tls(current) = read_sysreg(tpidr_el0);
+	if (system_supports_tpidr2() && !is_compat_task())
+		current->thread.tpidr2_el0 = read_sysreg_s(SYS_TPIDR2_EL0);
 }
 
 static void tls_thread_switch(struct task_struct *next)
@@ -398,6 +406,8 @@ static void tls_thread_switch(struct task_struct *next)
 		write_sysreg(0, tpidrro_el0);
 
 	write_sysreg(*task_user_tls(next), tpidr_el0);
+	if (system_supports_tpidr2())
+		write_sysreg_s(next->thread.tpidr2_el0, SYS_TPIDR2_EL0);
 }
 
 /*
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Shuah Khan <shuah@kernel.org>
Cc: Alan Hayward <alan.hayward@arm.com>,
	Luis Machado <luis.machado@arm.com>,
	Salil Akerkar <Salil.Akerkar@arm.com>,
	Basant Kumar Dwivedi <Basant.KumarDwivedi@arm.com>,
	Szabolcs Nagy <szabolcs.nagy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH v3 23/42] arm64/sme: Implement support for TPIDR2
Date: Tue, 19 Oct 2021 18:22:28 +0100	[thread overview]
Message-ID: <20211019172247.3045838-24-broonie@kernel.org> (raw)
In-Reply-To: <20211019172247.3045838-1-broonie@kernel.org>

The Scalable Matrix Extension introduces support for a new thread specific
data register TPIDR2 intended for use by libc. The kernel must save the
value of TPIDR2 on context switch and should ensure that all new threads
start off with a default value of 0. Add a field to the thread_struct to
store TPIDR2 and context switch it with the other thread specific data.

In case there are future extensions which also use TPIDR2 we introduce
system_supports_tpidr2() and use that rather than system_supports_sme()
for TPIDR2 handling.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/include/asm/cpufeature.h |  5 +++++
 arch/arm64/include/asm/processor.h  |  1 +
 arch/arm64/kernel/fpsimd.c          |  4 ++++
 arch/arm64/kernel/process.c         | 14 ++++++++++++--
 4 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h
index 9a183267b341..8d0cff410b40 100644
--- a/arch/arm64/include/asm/cpufeature.h
+++ b/arch/arm64/include/asm/cpufeature.h
@@ -740,6 +740,11 @@ static __always_inline bool system_supports_sme(void)
 		cpus_have_const_cap(ARM64_SME);
 }
 
+static __always_inline bool system_supports_tpidr2(void)
+{
+	return system_supports_sme();
+}
+
 static __always_inline bool system_supports_cnp(void)
 {
 	return IS_ENABLED(CONFIG_ARM64_CNP) &&
diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
index a62d2f8045bf..51eca2513cb5 100644
--- a/arch/arm64/include/asm/processor.h
+++ b/arch/arm64/include/asm/processor.h
@@ -168,6 +168,7 @@ struct thread_struct {
 	u64			mte_ctrl;
 #endif
 	u64			sctlr_user;
+	u64			tpidr2_el0;
 };
 
 static inline unsigned int thread_get_vl(struct thread_struct *thread,
diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
index 96780b6821b6..a619ce38eddc 100644
--- a/arch/arm64/kernel/fpsimd.c
+++ b/arch/arm64/kernel/fpsimd.c
@@ -1101,6 +1101,10 @@ void sme_kernel_enable(const struct arm64_cpu_capabilities *__always_unused p)
 	/* Allow SME in kernel */
 	write_sysreg(read_sysreg(CPACR_EL1) | CPACR_EL1_SMEN_EL1EN, CPACR_EL1);
 	isb();
+
+	/* Allow EL0 to access TPIDR2 */
+	write_sysreg(read_sysreg(SCTLR_EL1) | SCTLR_ELx_ENTP2, SCTLR_EL1);
+	isb();
 }
 
 /*
diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index 40adb8cdbf5a..3f4279ad68bc 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -249,6 +249,8 @@ void show_regs(struct pt_regs *regs)
 static void tls_thread_flush(void)
 {
 	write_sysreg(0, tpidr_el0);
+	if (system_supports_tpidr2())
+		write_sysreg_s(0, SYS_TPIDR2_EL0);
 
 	if (is_compat_task()) {
 		current->thread.uw.tp_value = 0;
@@ -342,6 +344,8 @@ int copy_thread(unsigned long clone_flags, unsigned long stack_start,
 		 * out-of-sync with the saved value.
 		 */
 		*task_user_tls(p) = read_sysreg(tpidr_el0);
+		if (system_supports_tpidr2())
+			p->thread.tpidr2_el0 = read_sysreg_s(SYS_TPIDR2_EL0);
 
 		if (stack_start) {
 			if (is_compat_thread(task_thread_info(p)))
@@ -352,10 +356,12 @@ int copy_thread(unsigned long clone_flags, unsigned long stack_start,
 
 		/*
 		 * If a TLS pointer was passed to clone, use it for the new
-		 * thread.
+		 * thread.  We also reset TPIDR2 if it's in use.
 		 */
-		if (clone_flags & CLONE_SETTLS)
+		if (clone_flags & CLONE_SETTLS) {
 			p->thread.uw.tp_value = tls;
+			p->thread.tpidr2_el0 = 0;
+		}
 	} else {
 		/*
 		 * A kthread has no context to ERET to, so ensure any buggy
@@ -386,6 +392,8 @@ int copy_thread(unsigned long clone_flags, unsigned long stack_start,
 void tls_preserve_current_state(void)
 {
 	*task_user_tls(current) = read_sysreg(tpidr_el0);
+	if (system_supports_tpidr2() && !is_compat_task())
+		current->thread.tpidr2_el0 = read_sysreg_s(SYS_TPIDR2_EL0);
 }
 
 static void tls_thread_switch(struct task_struct *next)
@@ -398,6 +406,8 @@ static void tls_thread_switch(struct task_struct *next)
 		write_sysreg(0, tpidrro_el0);
 
 	write_sysreg(*task_user_tls(next), tpidr_el0);
+	if (system_supports_tpidr2())
+		write_sysreg_s(next->thread.tpidr2_el0, SYS_TPIDR2_EL0);
 }
 
 /*
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-10-19 17:24 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 17:22 [PATCH v3 00/42] arm64/sme: Initial support for the Scalable Matrix Extension Mark Brown
2021-10-19 17:22 ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 01/42] arm64/fp: Reindent fpsimd_save() Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 02/42] arm64/sve: Remove sve_load_from_fpsimd_state() Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 03/42] arm64/sve: Make sve_state_size() static Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 04/42] arm64/sve: Make access to FFR optional Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 05/42] arm64/sve: Rename find_supported_vector_length() Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 06/42] arm64/sve: Use accessor functions for vector lengths in thread_struct Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 07/42] arm64/sve: Put system wide vector length information into structs Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-22 11:23   ` Catalin Marinas
2021-10-22 11:23     ` Catalin Marinas
2021-10-22 13:49     ` Mark Brown
2021-10-22 13:49       ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 08/42] arm64/sve: Explicitly load vector length when restoring SVE state Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 09/42] arm64/sve: Track vector lengths for tasks in an array Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 10/42] arm64/sve: Make sysctl interface for SVE reusable by SME Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-21  9:55   ` Will Deacon
2021-10-21  9:55     ` Will Deacon
2021-10-21 12:15     ` Mark Brown
2021-10-21 12:15       ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 11/42] arm64/sve: Generalise vector length configuration prctl() for SME Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 12/42] kselftest/arm64: Parameterise ptrace vector length information Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 13/42] kselftest/arm64: Allow signal tests to trigger from a function Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 14/42] tools/nolibc: Implement gettid() Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 15/42] arm64/sme: Provide ABI documentation for SME Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 16/42] arm64/sme: System register and exception syndrome definitions Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 17/42] arm64/sme: Define macros for manually encoding SME instructions Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 18/42] arm64/sme: Early CPU setup for SME Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 19/42] arm64/sme: Basic enumeration support Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 20/42] arm64/sme: Identify supported SME vector lengths at boot Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 21/42] arm64/sme: Implement sysctl to set the default vector length Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 22/42] arm64/sme: Implement vector length configuration prctl()s Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` Mark Brown [this message]
2021-10-19 17:22   ` [PATCH v3 23/42] arm64/sme: Implement support for TPIDR2 Mark Brown
2021-10-19 17:22 ` [PATCH v3 24/42] arm64/sme: Implement SVCR context switching Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 25/42] arm64/sme: Implement streaming SVE " Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 26/42] arm64/sme: Implement ZA " Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 27/42] arm64/sme: Implement traps and syscall handling for SME Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 28/42] arm64/sme: Implement streaming SVE signal handling Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 29/42] arm64/sme: Implement ZA " Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 30/42] arm64/sme: Implement ptrace support for streaming mode SVE registers Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 31/42] arm64/sme: Add ptrace support for ZA Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 32/42] arm64/sme: Disable streaming mode and ZA when flushing CPU state Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 33/42] arm64/sme: Save and restore streaming mode over EFI runtime calls Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 34/42] arm64/sme: Provide Kconfig for SME Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 35/42] kselftest/arm64: sme: Add streaming SME support to vlset Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 36/42] kselftest/arm64: Add tests for TPIDR2 Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 37/42] kselftest/arm64: Extend vector configuration API tests to cover SME Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 38/42] kselftest/arm64: sme: Provide streaming mode SVE stress test Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 39/42] kselftest/arm64: Add stress test for SME ZA context switching Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 40/42] kselftest/arm64: signal: Add SME signal handling tests Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 41/42] kselftest/arm64: Add streaming SVE to SVE ptrace tests Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-19 17:22 ` [PATCH v3 42/42] kselftest/arm64: Add coverage for the ZA ptrace interface Mark Brown
2021-10-19 17:22   ` Mark Brown
2021-10-21 10:05 ` [PATCH v3 00/42] arm64/sme: Initial support for the Scalable Matrix Extension Will Deacon
2021-10-21 10:05   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019172247.3045838-24-broonie@kernel.org \
    --to=broonie@kernel.org \
    --cc=Basant.KumarDwivedi@arm.com \
    --cc=Salil.Akerkar@arm.com \
    --cc=alan.hayward@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luis.machado@arm.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=szabolcs.nagy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.