All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
	Hridya Valsaraju <hridya@google.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
	Shuah Khan <shuah@kernel.org>, Tom Zanussi <zanussi@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 1/5] tracing: Add support for creating hist trigger variables from literal
Date: Tue, 19 Oct 2021 17:26:00 -0400	[thread overview]
Message-ID: <20211019172600.0f211c98@gandalf.local.home> (raw)
In-Reply-To: <CAC_TJvfT-1SeEhDnVjRfcv1SjKmZbcdy=cBVXYeB1GLTv+=e+w@mail.gmail.com>

On Tue, 19 Oct 2021 14:21:04 -0700
Kalesh Singh <kaleshsingh@google.com> wrote:

> Addition and subtraction are already supported operations. The use
> case given in Documentation/trace/histogram.rst is for calculating
> latencies. I don't have a use case where the constants may be needed
> in the addition/subtraction, but for simplicity and completeness we
> support them for all operations.

Perhaps we should state that it's mostly added for completeness then.

Thanks,

-- Steve

  reply	other threads:[~2021-10-19 21:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 19:52 [PATCH 0/5] tracing: Extend histogram triggers expression parsing Kalesh Singh
2021-09-15 19:52 ` [PATCH 1/5] tracing: Add support for creating hist trigger variables from literal Kalesh Singh
2021-10-19 20:48   ` Steven Rostedt
2021-10-19 21:21     ` Kalesh Singh
2021-10-19 21:26       ` Steven Rostedt [this message]
2021-10-19 21:49         ` Kalesh Singh
2021-09-15 19:52 ` [PATCH 2/5] tracing: Add division and multiplication support for hist triggers Kalesh Singh
2021-10-19 20:45   ` Steven Rostedt
2021-10-19 21:24     ` Kalesh Singh
2021-09-15 19:52 ` [PATCH 3/5] tracing: Fix operator precedence for hist triggers expression Kalesh Singh
2021-09-15 19:52 ` [PATCH 4/5] tracing/selftests: Add tests for hist trigger expression parsing Kalesh Singh
2021-09-15 19:52 ` [PATCH 5/5] tracing/histogram: Document expression arithmetic and constants Kalesh Singh
2021-09-15 20:09 ` [PATCH 0/5] tracing: Extend histogram triggers expression parsing Kalesh Singh
2021-09-30 22:58   ` Namhyung Kim
2021-10-02  0:54     ` Kalesh Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019172600.0f211c98@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=corbet@lwn.net \
    --cc=hridya@google.com \
    --cc=kaleshsingh@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.