From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pavel Begunkov <asml.silence@gmail.com>, linux-block@vger.kernel.org
Subject: [PATCH 3/4] block: optimise blk_flush_plug_list
Date: Wed, 20 Oct 2021 16:41:18 +0200 [thread overview]
Message-ID: <20211020144119.142582-4-hch@lst.de> (raw)
In-Reply-To: <20211020144119.142582-1-hch@lst.de>
From: Pavel Begunkov <asml.silence@gmail.com>
Don't call flush_plug_callbacks if there are no plug callbacks.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
[hch: split from a larger patch]
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/blk-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index e6ad5b51d0c3d..63fee1f82bd7d 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1639,8 +1639,8 @@ EXPORT_SYMBOL(blk_check_plugged);
void blk_flush_plug_list(struct blk_plug *plug, bool from_schedule)
{
- flush_plug_callbacks(plug, from_schedule);
-
+ if (!list_empty(&plug->cb_list))
+ flush_plug_callbacks(plug, from_schedule);
if (!rq_list_empty(plug->mq_list))
blk_mq_flush_plug_list(plug, from_schedule);
if (unlikely(!from_schedule && plug->cached_rq))
--
2.30.2
next prev parent reply other threads:[~2021-10-20 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 14:41 cleanup and optimize block plug handling Christoph Hellwig
2021-10-20 14:41 ` [PATCH 1/4] blk-mq: only flush requests from the plug in blk_mq_submit_bio Christoph Hellwig
2021-10-20 14:41 ` [PATCH 2/4] blk-mq: move blk_mq_flush_plug_list to block/blk-mq.h Christoph Hellwig
2021-10-20 14:41 ` Christoph Hellwig [this message]
2021-10-20 14:41 ` [PATCH 4/4] block: cleanup the flush plug helpers Christoph Hellwig
2021-10-22 20:09 ` Nathan Chancellor
2021-10-23 1:38 ` Jens Axboe
2021-10-20 16:10 ` cleanup and optimize block plug handling Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020144119.142582-4-hch@lst.de \
--to=hch@lst.de \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.