From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Rob Herring <robh+dt@kernel.org>, Vignesh Raghavendra <vigneshr@ti.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Mark Brown <broonie@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Geert Uytterhoeven <geert+renesas@glider.be>, Wolfram Sang <wsa+renesas@sang-engineering.com>, Sergei Shtylyov <sergei.shtylyov@gmail.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar <prabhakar.csengg@gmail.com>, Biju Das <biju.das.jz@bp.renesas.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Subject: [PATCH v2 4/7] mtd: hyperbus: rpc-if: Check return value of rpcif_sw_init() Date: Mon, 25 Oct 2021 21:56:28 +0100 [thread overview] Message-ID: <20211025205631.21151-5-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw) In-Reply-To: <20211025205631.21151-1-prabhakar.mahadev-lad.rj@bp.renesas.com> rpcif_sw_init() can fail so make sure we check the return value of it and on error exit rpcif_hb_probe() callback with error code. Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v1->v2: * Included RB tags --- drivers/mtd/hyperbus/rpc-if.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/hyperbus/rpc-if.c b/drivers/mtd/hyperbus/rpc-if.c index ecb050ba95cd..367b0d72bf62 100644 --- a/drivers/mtd/hyperbus/rpc-if.c +++ b/drivers/mtd/hyperbus/rpc-if.c @@ -124,7 +124,9 @@ static int rpcif_hb_probe(struct platform_device *pdev) if (!hyperbus) return -ENOMEM; - rpcif_sw_init(&hyperbus->rpc, pdev->dev.parent); + error = rpcif_sw_init(&hyperbus->rpc, pdev->dev.parent); + if (error) + return error; platform_set_drvdata(pdev, hyperbus); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Rob Herring <robh+dt@kernel.org>, Vignesh Raghavendra <vigneshr@ti.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Mark Brown <broonie@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Geert Uytterhoeven <geert+renesas@glider.be>, Wolfram Sang <wsa+renesas@sang-engineering.com>, Sergei Shtylyov <sergei.shtylyov@gmail.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar <prabhakar.csengg@gmail.com>, Biju Das <biju.das.jz@bp.renesas.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Subject: [PATCH v2 4/7] mtd: hyperbus: rpc-if: Check return value of rpcif_sw_init() Date: Mon, 25 Oct 2021 21:56:28 +0100 [thread overview] Message-ID: <20211025205631.21151-5-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw) In-Reply-To: <20211025205631.21151-1-prabhakar.mahadev-lad.rj@bp.renesas.com> rpcif_sw_init() can fail so make sure we check the return value of it and on error exit rpcif_hb_probe() callback with error code. Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v1->v2: * Included RB tags --- drivers/mtd/hyperbus/rpc-if.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/hyperbus/rpc-if.c b/drivers/mtd/hyperbus/rpc-if.c index ecb050ba95cd..367b0d72bf62 100644 --- a/drivers/mtd/hyperbus/rpc-if.c +++ b/drivers/mtd/hyperbus/rpc-if.c @@ -124,7 +124,9 @@ static int rpcif_hb_probe(struct platform_device *pdev) if (!hyperbus) return -ENOMEM; - rpcif_sw_init(&hyperbus->rpc, pdev->dev.parent); + error = rpcif_sw_init(&hyperbus->rpc, pdev->dev.parent); + if (error) + return error; platform_set_drvdata(pdev, hyperbus); -- 2.17.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-10-25 20:57 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-25 20:56 [PATCH v2 0/7] Add SPI Multi I/O Bus Controller support for RZ/G2L Lad Prabhakar 2021-10-25 20:56 ` Lad Prabhakar 2021-10-25 20:56 ` [PATCH v2 1/7] dt-bindings: memory: renesas,rpc-if: Add support for the R9A07G044 Lad Prabhakar 2021-10-25 20:56 ` [PATCH v2 1/7] dt-bindings: memory: renesas, rpc-if: " Lad Prabhakar 2021-11-16 10:31 ` (subset) [PATCH v2 1/7] dt-bindings: memory: renesas,rpc-if: " Krzysztof Kozlowski 2021-11-16 10:31 ` (subset) [PATCH v2 1/7] dt-bindings: memory: renesas, rpc-if: " Krzysztof Kozlowski 2021-10-25 20:56 ` [PATCH v2 2/7] dt-bindings: memory: renesas,rpc-if: Add optional interrupts property Lad Prabhakar 2021-10-25 20:56 ` [PATCH v2 2/7] dt-bindings: memory: renesas, rpc-if: " Lad Prabhakar 2021-11-16 10:31 ` (subset) [PATCH v2 2/7] dt-bindings: memory: renesas,rpc-if: " Krzysztof Kozlowski 2021-11-16 10:31 ` (subset) [PATCH v2 2/7] dt-bindings: memory: renesas, rpc-if: " Krzysztof Kozlowski 2021-10-25 20:56 ` [PATCH v2 3/7] spi: spi-rpc-if: Check return value of rpcif_sw_init() Lad Prabhakar 2021-10-25 20:56 ` Lad Prabhakar 2021-10-25 20:56 ` Lad Prabhakar [this message] 2021-10-25 20:56 ` [PATCH v2 4/7] mtd: hyperbus: rpc-if: " Lad Prabhakar 2021-10-25 20:56 ` [PATCH v2 5/7] memory: renesas-rpc-if: Return error in case devm_ioremap_resource() fails Lad Prabhakar 2021-10-25 20:56 ` Lad Prabhakar 2021-10-27 7:17 ` Geert Uytterhoeven 2021-10-27 7:17 ` Geert Uytterhoeven 2021-10-27 7:21 ` Geert Uytterhoeven 2021-10-27 7:21 ` Geert Uytterhoeven 2021-11-16 10:31 ` (subset) " Krzysztof Kozlowski 2021-11-16 10:31 ` Krzysztof Kozlowski 2021-10-25 20:56 ` [PATCH v2 6/7] memory: renesas-rpc-if: Drop usage of RPCIF_DIRMAP_SIZE macro Lad Prabhakar 2021-10-25 20:56 ` Lad Prabhakar 2021-10-27 7:22 ` Geert Uytterhoeven 2021-10-27 7:22 ` Geert Uytterhoeven 2021-11-16 10:31 ` (subset) " Krzysztof Kozlowski 2021-11-16 10:31 ` Krzysztof Kozlowski 2021-10-25 20:56 ` [PATCH v2 7/7] memory: renesas-rpc-if: Add support for RZ/G2L Lad Prabhakar 2021-10-25 20:56 ` Lad Prabhakar 2021-10-26 14:46 ` Krzysztof Kozlowski 2021-10-26 14:46 ` Krzysztof Kozlowski 2021-10-27 16:16 ` Lad, Prabhakar 2021-10-27 16:16 ` Lad, Prabhakar 2021-11-02 11:48 ` Wolfram Sang 2021-11-02 11:48 ` Wolfram Sang 2021-11-02 23:25 ` Lad, Prabhakar 2021-11-02 23:25 ` Lad, Prabhakar 2021-11-03 8:41 ` Wolfram Sang 2021-11-03 8:41 ` Wolfram Sang 2021-11-03 9:12 ` Lad, Prabhakar 2021-11-03 9:12 ` Lad, Prabhakar 2021-11-15 13:03 ` Wolfram Sang 2021-11-15 13:03 ` Wolfram Sang 2021-11-16 11:11 ` (subset) " Krzysztof Kozlowski 2021-11-16 11:11 ` Krzysztof Kozlowski 2021-10-26 14:48 ` [PATCH v2 0/7] Add SPI Multi I/O Bus Controller " Krzysztof Kozlowski 2021-10-26 14:48 ` Krzysztof Kozlowski 2021-10-26 19:07 ` (subset) " Mark Brown 2021-10-26 19:07 ` Mark Brown 2021-11-16 10:33 ` Krzysztof Kozlowski 2021-11-16 10:33 ` Krzysztof Kozlowski 2021-11-16 10:40 ` Lad, Prabhakar 2021-11-16 10:40 ` Lad, Prabhakar 2021-11-16 11:11 ` Krzysztof Kozlowski 2021-11-16 11:11 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211025205631.21151-5-prabhakar.mahadev-lad.rj@bp.renesas.com \ --to=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=biju.das.jz@bp.renesas.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ --cc=p.zabel@pengutronix.de \ --cc=prabhakar.csengg@gmail.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=sergei.shtylyov@gmail.com \ --cc=vigneshr@ti.com \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.