From: Sergey Shtylyov <s.shtylyov@omp.ru> To: <linux-usb@vger.kernel.org>, Alan Stern <stern@rowland.harvard.edu>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, <linux-arm-kernel@lists.infradead.org> Subject: [PATCH v2 08/22] usb: host: ohci-at91: deny IRQ0 Date: Tue, 26 Oct 2021 20:39:29 +0300 [thread overview] Message-ID: <20211026173943.6829-9-s.shtylyov@omp.ru> (raw) In-Reply-To: <20211026173943.6829-1-s.shtylyov@omp.ru> If platform_get_irq() returns IRQ0 (considered invalid according to Linus) the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ at all. Deny IRQ0 right away, returning -EINVAL from the probe() method... Fixes: fb5f1834c322 ("usb: ohci-at91: fix irq and iomem resource retrieval") Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Acked-by: Alan Stern <stern@rowland.harvard.edu> --- Changes in version 2: - added Alan's ACK. drivers/usb/host/ohci-at91.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index a24aea3d2759..6a7276a730d1 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -181,6 +181,8 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver, dev_dbg(dev, "hcd probe: missing irq resource\n"); return irq; } + if (!irq) + return -EINVAL; hcd = usb_create_hcd(driver, dev, "at91"); if (!hcd) -- 2.26.3
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Shtylyov <s.shtylyov@omp.ru> To: <linux-usb@vger.kernel.org>, Alan Stern <stern@rowland.harvard.edu>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 08/22] usb: host: ohci-at91: deny IRQ0 Date: Tue, 26 Oct 2021 20:39:29 +0300 [thread overview] Message-ID: <20211026173943.6829-9-s.shtylyov@omp.ru> (raw) In-Reply-To: <20211026173943.6829-1-s.shtylyov@omp.ru> If platform_get_irq() returns IRQ0 (considered invalid according to Linus) the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ at all. Deny IRQ0 right away, returning -EINVAL from the probe() method... Fixes: fb5f1834c322 ("usb: ohci-at91: fix irq and iomem resource retrieval") Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Acked-by: Alan Stern <stern@rowland.harvard.edu> --- Changes in version 2: - added Alan's ACK. drivers/usb/host/ohci-at91.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index a24aea3d2759..6a7276a730d1 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -181,6 +181,8 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver, dev_dbg(dev, "hcd probe: missing irq resource\n"); return irq; } + if (!irq) + return -EINVAL; hcd = usb_create_hcd(driver, dev, "at91"); if (!hcd) -- 2.26.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-26 17:39 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-26 17:39 [PATCH v2 00/22] Explicitly deny IRQ0 in the USB host drivers Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 01/22] usb: host: ehci-exynos: deny IRQ0 Sergey Shtylyov 2021-10-26 17:39 ` Sergey Shtylyov 2021-10-30 8:54 ` Greg Kroah-Hartman 2021-10-30 8:54 ` Greg Kroah-Hartman 2021-11-01 20:39 ` Sergey Shtylyov 2021-11-01 20:39 ` Sergey Shtylyov 2021-11-02 13:55 ` Greg Kroah-Hartman 2021-11-02 13:55 ` Greg Kroah-Hartman 2021-11-02 20:45 ` Sergey Shtylyov 2021-11-02 20:45 ` Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 02/22] usb: host: ehci-mv: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 03/22] usb: host: ehci-npcm7xx: " Sergey Shtylyov 2021-10-26 17:39 ` Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 04/22] usb: host: ehci-omap: " Sergey Shtylyov 2021-10-30 19:49 ` kernel test robot 2021-10-30 19:49 ` kernel test robot 2021-10-26 17:39 ` [PATCH v2 05/22] usb: host: ehci-platform: " Sergey Shtylyov 2021-10-26 17:39 ` Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 06/22] usb: host: ehci-spear: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 07/22] usb: host: ehci-st: " Sergey Shtylyov 2021-10-26 17:39 ` Sergey Shtylyov 2021-10-27 6:08 ` Patrice CHOTARD 2021-10-27 6:08 ` Patrice CHOTARD 2021-10-26 17:39 ` Sergey Shtylyov [this message] 2021-10-26 17:39 ` [PATCH v2 08/22] usb: host: ohci-at91: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 09/22] usb: host: ohci-da8xx: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 10/22] usb: host: ohci-exynos: " Sergey Shtylyov 2021-10-26 17:39 ` Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 11/22] usb: host: ohci-nxp: " Sergey Shtylyov 2021-10-26 17:39 ` Sergey Shtylyov 2021-10-26 18:25 ` Vladimir Zapolskiy 2021-10-26 18:25 ` Vladimir Zapolskiy 2021-10-26 17:39 ` [PATCH v2 12/22] usb: host: ohci-omap: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 13/22] usb: host: ohci-platform: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 14/22] usb: host: ohci-pxa27x: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 15/22] usb: host: ohci-sm501: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 16/22] usb: host: ohci-spear: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 17/22] usb: host: ohci-st: " Sergey Shtylyov 2021-10-26 17:39 ` Sergey Shtylyov 2021-10-27 6:08 ` Patrice CHOTARD 2021-10-27 6:08 ` Patrice CHOTARD 2021-10-26 17:39 ` [PATCH v2 18/22] usb: host: ohci-tmio: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 19/22] usb: host: xhci-histb: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 20/22] usb: host: xhci-mtk: " Sergey Shtylyov 2021-10-26 17:39 ` Sergey Shtylyov 2021-10-26 17:39 ` Sergey Shtylyov 2021-10-27 8:54 ` Chunfeng Yun 2021-10-27 8:54 ` Chunfeng Yun 2021-10-27 8:54 ` Chunfeng Yun 2021-10-27 9:18 ` Chunfeng Yun 2021-10-27 9:18 ` Chunfeng Yun 2021-10-27 9:18 ` Chunfeng Yun 2021-10-27 9:25 ` Sergey Shtylyov 2021-10-27 9:25 ` Sergey Shtylyov 2021-10-27 9:25 ` Sergey Shtylyov 2021-10-27 9:35 ` Chunfeng Yun 2021-10-27 9:35 ` Chunfeng Yun 2021-10-27 9:35 ` Chunfeng Yun 2021-10-26 17:39 ` [PATCH v2 21/22] usb: host: xhci-plat: " Sergey Shtylyov 2021-10-26 17:39 ` [PATCH v2 22/22] usb: host: xhci-tegra: " Sergey Shtylyov 2021-10-30 22:08 ` kernel test robot 2021-10-30 22:08 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211026173943.6829-9-s.shtylyov@omp.ru \ --to=s.shtylyov@omp.ru \ --cc=alexandre.belloni@bootlin.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-usb@vger.kernel.org \ --cc=ludovic.desroches@microchip.com \ --cc=nicolas.ferre@microchip.com \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.